From: Brian Masney <masneyb@onstation.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Stephen Boyd <sboyd@kernel.org>,
"thierry.reding@gmail.com" <thierry.reding@gmail.com>,
Andy Gross <agross@kernel.org>,
David Brown <david.brown@linaro.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
MSM <linux-arm-msm@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH RESEND] ARM: dts: qcom: msm8974-hammerhead: add device tree bindings for vibrator
Date: Mon, 24 Jun 2019 20:54:34 -0400 [thread overview]
Message-ID: <20190625005434.GA6401@onstation.org> (raw)
In-Reply-To: <CACRpkdYTaM+sBs-bhaXVtAwFtp6+_PWWJ_k9jobd7qB41HubDg@mail.gmail.com>
On Tue, Jun 25, 2019 at 12:29:29AM +0200, Linus Walleij wrote:
> On Sun, Jun 23, 2019 at 12:53 PM Brian Masney <masneyb@onstation.org> wrote:
>
> > 2) Do what Linus suggests above. We can use v1 of this series from last
> > September (see below for link) that adds this to the pwm subsystem.
> > The locking would need to be added so that it won't conflict with the
> > clk subsystem. This can be tied into the input subsystem with the
> > existing pwm-vibra driver.
>
> What I imagined was that the clk driver would double as a pwm driver.
> Just register both interfaces.
>
> There are already plenty of combines clk+reset drivers for example.
>
> Otherwise I'm all for this approach (but that's just me).
I agree that this makes sense. I especially like that it'll allow us
to use the existing pwm-vibra driver in the input subsystem with this
approach.
Brian
next prev parent reply other threads:[~2019-06-25 0:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-16 8:50 [PATCH RESEND] ARM: dts: qcom: msm8974-hammerhead: add device tree bindings for vibrator Brian Masney
2019-05-20 14:21 ` Stephen Boyd
2019-05-22 8:23 ` Brian Masney
2019-05-24 1:20 ` Stephen Boyd
2019-05-29 9:13 ` Linus Walleij
2019-05-29 10:12 ` Brian Masney
2019-05-31 10:51 ` Linus Walleij
2019-06-23 10:53 ` Brian Masney
2019-06-24 22:29 ` Linus Walleij
2019-06-25 0:54 ` Brian Masney [this message]
2019-06-27 23:49 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190625005434.GA6401@onstation.org \
--to=masneyb@onstation.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).