From: Sean Paul <sean@poorly.run>
To: Dave Airlie <airlied@gmail.com>
Cc: Rob Clark <robdclark@gmail.com>,
Sean Paul <seanpaul@chromium.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
freedreno <freedreno@lists.freedesktop.org>,
dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [Freedreno] [pull] drm/msm: msm-next for 5.3
Date: Thu, 27 Jun 2019 11:07:35 -0400 [thread overview]
Message-ID: <20190627150735.GJ25413@art_vandelay> (raw)
In-Reply-To: <CAPM=9txROe0mxv+w=v3trMbn7pPxj5wbjkh5=RJarsDbGwV7BA@mail.gmail.com>
On Thu, Jun 27, 2019 at 12:21:39PM +1000, Dave Airlie wrote:
> On Wed, 26 Jun 2019 at 08:34, Rob Clark <robdclark@gmail.com> wrote:
> >
> > Hi Dave,
> >
>
> Naughty naughty rebase.
>
> dim: f47bee2ba447 ("drm/msm/a3xx: remove TPL1 regs from snapshot"):
> Subject in fixes line doesn't match referenced commit:
> dim: 7198e6b03155 drm/msm: add a3xx gpu support
> dim: fc19cbb785d7 ("drm/msm/mdp5: Fix mdp5_cfg_init error return"):
> Subject in fixes line doesn't match referenced commit:
> dim: 2e362e1772b8 (drm/msm/mdp5: introduce mdp5_cfg module)
Hi Dave,
Was chatting with Rob about this on IRC and these failures aren't due to a
rebase (we were quite careful to avoid rebasing this cycle). The issue seems to
be that the commit messages use the format,
Fixes: <hash> <subject>
for Fixes tags and dim does this when comparing the subject:
if [[ "$fixes_subject" != "(\"$orig_subject\")" ]] ; then
So dim is being quite strict about adding parens and quotations to the subject
in fixes lines and failing as a result.
IMO since the hashes are correct this formatting should be fine.
Ok with you?
Sean
PS- If it's fine to format like this, we might want to change the dim check to
something like:
if [[ "$orig_subject" != *"$fixes_subject"* ]] ; then
>
> Please fix or squash those and resend.
>
> Dave.
> _______________________________________________
> Freedreno mailing list
> Freedreno@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/freedreno
--
Sean Paul, Software Engineer, Google / Chromium OS
prev parent reply other threads:[~2019-06-27 15:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-25 22:34 [pull] drm/msm: msm-next for 5.3 Rob Clark
2019-06-27 2:21 ` Dave Airlie
2019-06-27 15:07 ` Sean Paul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190627150735.GJ25413@art_vandelay \
--to=sean@poorly.run \
--cc=airlied@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=robdclark@gmail.com \
--cc=seanpaul@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).