From: Rob Clark <robdclark@gmail.com>
To: dri-devel@lists.freedesktop.org
Cc: linux-arm-msm@vger.kernel.org, Sean Paul <seanpaul@chromium.org>,
Rob Clark <robdclark@chromium.org>,
Andrzej Hajda <a.hajda@samsung.com>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
linux-kernel@vger.kernel.org
Subject: [PATCH 3/3] drm/bridge: ti-sn65dsi86: correct dsi mode_flags
Date: Tue, 2 Jul 2019 08:44:18 -0700 [thread overview]
Message-ID: <20190702154419.20812-4-robdclark@gmail.com> (raw)
In-Reply-To: <20190702154419.20812-1-robdclark@gmail.com>
From: Rob Clark <robdclark@chromium.org>
Noticed while comparing register dump of how bootloader configures DSI
vs how kernel configures. It seems the bridge still works either way,
but fixing this clears the 'CHA_DATATYPE_ERR' error status bit.
Signed-off-by: Rob Clark <robdclark@chromium.org>
---
drivers/gpu/drm/bridge/ti-sn65dsi86.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
index a6f27648c015..c8fb45e7b06d 100644
--- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c
+++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
@@ -342,8 +342,7 @@ static int ti_sn_bridge_attach(struct drm_bridge *bridge)
/* TODO: setting to 4 lanes always for now */
dsi->lanes = 4;
dsi->format = MIPI_DSI_FMT_RGB888;
- dsi->mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_SYNC_PULSE |
- MIPI_DSI_MODE_EOT_PACKET | MIPI_DSI_MODE_VIDEO_HSE;
+ dsi->mode_flags = MIPI_DSI_MODE_VIDEO;
/* check if continuous dsi clock is required or not */
pm_runtime_get_sync(pdata->dev);
--
2.20.1
next prev parent reply other threads:[~2019-07-02 15:44 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20190702154436epcas2p3fdaaa095c15a116a0be7e5313469151f@epcas2p3.samsung.com>
2019-07-02 15:44 ` [PATCH 0/3] drm/bridge: ti-sn65dsi86: debugfs and mode_flags fix Rob Clark
2019-07-02 15:44 ` [PATCH 1/3] drm/bridge: ti-sn65dsi86: add link to datasheet Rob Clark
2019-07-02 17:03 ` Jeffrey Hugo
2019-07-04 12:26 ` Andrzej Hajda
2019-07-04 12:32 ` Laurent Pinchart
2019-07-02 15:44 ` [PATCH 2/3] drm/bridge: ti-sn65dsi86: add debugfs Rob Clark
2019-07-02 17:05 ` Jeffrey Hugo
2019-07-04 12:31 ` Andrzej Hajda
2019-07-04 12:35 ` Laurent Pinchart
2019-07-04 13:56 ` Rob Clark
2019-07-04 21:10 ` Laurent Pinchart
2019-07-02 15:44 ` Rob Clark [this message]
2019-07-02 17:09 ` [PATCH 3/3] drm/bridge: ti-sn65dsi86: correct dsi mode_flags Jeffrey Hugo
2019-07-02 17:12 ` Rob Clark
2019-07-02 17:23 ` Jeffrey Hugo
2019-07-04 12:33 ` Andrzej Hajda
2019-07-04 13:18 ` [PATCH 0/3] drm/bridge: ti-sn65dsi86: debugfs and mode_flags fix Andrzej Hajda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190702154419.20812-4-robdclark@gmail.com \
--to=robdclark@gmail.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=a.hajda@samsung.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robdclark@chromium.org \
--cc=seanpaul@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).