From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>
Cc: sboyd@kernel.org, david.brown@linaro.org,
jassisinghbrar@gmail.com, mark.rutland@arm.com,
mturquette@baylibre.com, robh+dt@kernel.org, will.deacon@arm.com,
arnd@arndb.de, horms+renesas@verge.net.au, heiko@sntech.de,
sibis@codeaurora.org, enric.balletbo@collabora.com,
jagan@amarulasolutions.com, olof@lixom.net, vkoul@kernel.org,
niklas.cassel@linaro.org, georgi.djakov@linaro.org,
amit.kucheria@linaro.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org,
linux-arm-msm@vger.kernel.org, khasim.mohammed@linaro.org
Subject: Re: [PATCH v3 02/14] mbox: qcom: add APCS child device for QCS404
Date: Thu, 11 Jul 2019 07:44:24 -0700 [thread overview]
Message-ID: <20190711144424.GD7234@tuxbook-pro> (raw)
In-Reply-To: <20190625164733.11091-3-jorge.ramirez-ortiz@linaro.org>
On Tue 25 Jun 09:47 PDT 2019, Jorge Ramirez-Ortiz wrote:
> There is clock controller functionality in the APCS hardware block of
> qcs404 devices similar to msm8916.
>
> Co-developed-by: Niklas Cassel <niklas.cassel@linaro.org>
> Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org>
> Signed-off-by: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>
> ---
> drivers/mailbox/qcom-apcs-ipc-mailbox.c | 18 ++++++++++--------
> 1 file changed, 10 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/mailbox/qcom-apcs-ipc-mailbox.c b/drivers/mailbox/qcom-apcs-ipc-mailbox.c
> index 705e17a5479c..a05dc3aabac7 100644
> --- a/drivers/mailbox/qcom-apcs-ipc-mailbox.c
> +++ b/drivers/mailbox/qcom-apcs-ipc-mailbox.c
> @@ -89,16 +89,18 @@ static int qcom_apcs_ipc_probe(struct platform_device *pdev)
> return ret;
> }
>
> - if (of_device_is_compatible(np, "qcom,msm8916-apcs-kpss-global")) {
> - apcs->clk = platform_device_register_data(&pdev->dev,
> - "qcom-apcs-msm8916-clk",
> - -1, NULL, 0);
> - if (IS_ERR(apcs->clk))
> - dev_err(&pdev->dev, "failed to register APCS clk\n");
> - }
> -
> platform_set_drvdata(pdev, apcs);
>
> + if (!of_device_is_compatible(np, "qcom,msm8916-apcs-kpss-global") &&
> + !of_device_is_compatible(np, "qcom,qcs404-apcs-apps-global"))
If the remainder of the function was a long snippet I think this would
motivate the somewhat unusual early return. But I think it would be
cleaner to just add to the existing conditional.
Regards,
Bjorn
> + return 0;
> +
> + apcs->clk = platform_device_register_data(&pdev->dev,
> + "qcom-apcs-msm8916-clk",
> + -1, NULL, 0);
> + if (IS_ERR(apcs->clk))
> + dev_err(&pdev->dev, "failed to register APCS clk\n");
> +
> return 0;
> }
>
> --
> 2.21.0
>
next prev parent reply other threads:[~2019-07-11 14:43 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-25 16:47 [PATCH v3 00/14] Support CPU frequency scaling on QCS404 Jorge Ramirez-Ortiz
2019-06-25 16:47 ` [PATCH v3 01/14] clk: qcom: gcc: limit GPLL0_AO_OUT operating frequency Jorge Ramirez-Ortiz
2019-07-11 15:30 ` Bjorn Andersson
2019-06-25 16:47 ` [PATCH v3 02/14] mbox: qcom: add APCS child device for QCS404 Jorge Ramirez-Ortiz
2019-07-11 14:44 ` Bjorn Andersson [this message]
2019-07-31 14:10 ` Jorge Ramirez
2019-06-25 16:47 ` [PATCH v3 03/14] mbox: qcom: replace integer with valid macro Jorge Ramirez-Ortiz
2019-07-11 14:37 ` Bjorn Andersson
2019-06-25 16:47 ` [PATCH v3 04/14] dt-bindings: mailbox: qcom: Add clock-name optional property Jorge Ramirez-Ortiz
2019-07-11 14:45 ` Bjorn Andersson
2019-06-25 16:47 ` [PATCH v3 05/14] clk: qcom: apcs-msm8916: get parent clock names from DT Jorge Ramirez-Ortiz
2019-07-11 14:58 ` Bjorn Andersson
2019-06-25 16:47 ` [PATCH v3 06/14] clk: qcom: hfpll: " Jorge Ramirez-Ortiz
2019-07-11 15:07 ` Bjorn Andersson
2019-06-25 16:47 ` [PATCH v3 07/14] clk: qcom: hfpll: register as clock provider Jorge Ramirez-Ortiz
2019-07-11 15:07 ` Bjorn Andersson
2019-06-25 16:47 ` [PATCH v3 08/14] clk: qcom: hfpll: CLK_IGNORE_UNUSED Jorge Ramirez-Ortiz
2019-07-11 15:16 ` Bjorn Andersson
2019-07-31 14:30 ` Jorge Ramirez
2019-06-25 16:47 ` [PATCH v3 09/14] arm64: dts: qcom: msm8916: Add the clocks for the APCS mux/divider Jorge Ramirez-Ortiz
2019-07-11 15:24 ` Bjorn Andersson
2019-06-25 16:47 ` [PATCH v3 10/14] arm64: dts: qcom: qcs404: Add OPP table Jorge Ramirez-Ortiz
2019-07-11 15:25 ` Bjorn Andersson
2019-06-25 16:47 ` [PATCH v3 11/14] arm64: dts: qcom: qcs404: Add HFPLL node Jorge Ramirez-Ortiz
2019-07-11 15:25 ` Bjorn Andersson
2019-06-25 16:47 ` [PATCH v3 12/14] arm64: dts: qcom: qcs404: Add the clocks for APCS mux/divider Jorge Ramirez-Ortiz
2019-07-11 15:27 ` Bjorn Andersson
2019-06-25 16:47 ` [PATCH v3 13/14] arm64: dts: qcom: qcs404: Add DVFS support Jorge Ramirez-Ortiz
2019-06-26 9:08 ` Niklas Cassel
2019-06-26 9:10 ` Niklas Cassel
2019-07-11 15:29 ` Bjorn Andersson
2019-06-25 16:47 ` [PATCH v3 14/14] arm64: defconfig: Enable HFPLL Jorge Ramirez-Ortiz
2019-07-11 15:27 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190711144424.GD7234@tuxbook-pro \
--to=bjorn.andersson@linaro.org \
--cc=amit.kucheria@linaro.org \
--cc=arnd@arndb.de \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=enric.balletbo@collabora.com \
--cc=georgi.djakov@linaro.org \
--cc=heiko@sntech.de \
--cc=horms+renesas@verge.net.au \
--cc=jagan@amarulasolutions.com \
--cc=jassisinghbrar@gmail.com \
--cc=jorge.ramirez-ortiz@linaro.org \
--cc=khasim.mohammed@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mturquette@baylibre.com \
--cc=niklas.cassel@linaro.org \
--cc=olof@lixom.net \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=sibis@codeaurora.org \
--cc=vkoul@kernel.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).