linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Vivek Gautam <vivek.gautam@codeaurora.org>
Cc: agross@kernel.org, linux-arm-msm@vger.kernel.org,
	jcrouse@codeaurora.org, rishabhb@codeaurora.org,
	vnkgutta@codeaurora.org, evgreen@chromium.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] soc: qcom: llcc: Rename llcc-sdm845 to llcc-plat
Date: Thu, 11 Jul 2019 08:38:16 -0700	[thread overview]
Message-ID: <20190711153816.GQ7234@tuxbook-pro> (raw)
In-Reply-To: <20190711110340.16672-1-vivek.gautam@codeaurora.org>

On Thu 11 Jul 04:03 PDT 2019, Vivek Gautam wrote:

> To avoid adding files for each future supported SoCs rename
> the file to a generic name - llcc-plat, so that llcc configuration
> tables for other SoCs can be added in the same driver.
> 

We've had a generic LLCC Kconfig option and then a specific SDM845 one,
with this change we have two different generic options and both would
either always be enabled or disabled.

So I think you should drop QCOM_SDM845_LLCC and build both llcc-slice
and llcc-plat into the same qcom_llcc.ko instead.

Regards,
Bjorn

> Signed-off-by: Vivek Gautam <vivek.gautam@codeaurora.org>
> ---
>  drivers/soc/qcom/Kconfig                        | 10 +++++-----
>  drivers/soc/qcom/Makefile                       |  2 +-
>  drivers/soc/qcom/{llcc-sdm845.c => llcc-plat.c} |  0
>  3 files changed, 6 insertions(+), 6 deletions(-)
>  rename drivers/soc/qcom/{llcc-sdm845.c => llcc-plat.c} (100%)
> 
> diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig
> index a6d1bfb17279..8110d415b18e 100644
> --- a/drivers/soc/qcom/Kconfig
> +++ b/drivers/soc/qcom/Kconfig
> @@ -62,13 +62,13 @@ config QCOM_LLCC
>  	  to clients that use the LLCC. Say yes here to enable LLCC slice
>  	  driver.
>  
> -config QCOM_SDM845_LLCC
> -	tristate "Qualcomm Technologies, Inc. SDM845 LLCC driver"
> +config QCOM_PLAT_LLCC
> +	tristate "Qualcomm Technologies, Inc. platform LLCC driver"
>  	depends on QCOM_LLCC
>  	help
> -	  Say yes here to enable the LLCC driver for SDM845. This provides
> -	  data required to configure LLCC so that clients can start using the
> -	  LLCC slices.
> +	  Say yes here to enable the LLCC driver for Qcom platforms, such as
> +	  SDM845. This provides data required to configure LLCC so that
> +	  clients can start using the LLCC slices.
>  
>  config QCOM_MDT_LOADER
>  	tristate
> diff --git a/drivers/soc/qcom/Makefile b/drivers/soc/qcom/Makefile
> index eeb088beb15f..3bf26667d7ee 100644
> --- a/drivers/soc/qcom/Makefile
> +++ b/drivers/soc/qcom/Makefile
> @@ -21,6 +21,6 @@ obj-$(CONFIG_QCOM_SMSM)	+= smsm.o
>  obj-$(CONFIG_QCOM_WCNSS_CTRL) += wcnss_ctrl.o
>  obj-$(CONFIG_QCOM_APR) += apr.o
>  obj-$(CONFIG_QCOM_LLCC) += llcc-slice.o
> -obj-$(CONFIG_QCOM_SDM845_LLCC) += llcc-sdm845.o
> +obj-$(CONFIG_QCOM_PLAT_LLCC) += llcc-plat.o
>  obj-$(CONFIG_QCOM_RPMHPD) += rpmhpd.o
>  obj-$(CONFIG_QCOM_RPMPD) += rpmpd.o
> diff --git a/drivers/soc/qcom/llcc-sdm845.c b/drivers/soc/qcom/llcc-plat.c
> similarity index 100%
> rename from drivers/soc/qcom/llcc-sdm845.c
> rename to drivers/soc/qcom/llcc-plat.c
> -- 
> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
> of Code Aurora Forum, hosted by The Linux Foundation
> 

  parent reply	other threads:[~2019-07-11 15:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-11 11:03 [PATCH 1/2] soc: qcom: llcc: Rename llcc-sdm845 to llcc-plat Vivek Gautam
2019-07-11 11:03 ` [PATCH 2/2] soc: qcom: llcc-plat: Make the driver more generic Vivek Gautam
2019-07-11 16:00   ` Bjorn Andersson
2019-07-12 11:29     ` Vivek Gautam
2019-07-11 15:38 ` Bjorn Andersson [this message]
2019-07-12 11:06   ` [PATCH 1/2] soc: qcom: llcc: Rename llcc-sdm845 to llcc-plat Vivek Gautam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190711153816.GQ7234@tuxbook-pro \
    --to=bjorn.andersson@linaro.org \
    --cc=agross@kernel.org \
    --cc=evgreen@chromium.org \
    --cc=jcrouse@codeaurora.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rishabhb@codeaurora.org \
    --cc=vivek.gautam@codeaurora.org \
    --cc=vnkgutta@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).