From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16982C742A5 for ; Fri, 12 Jul 2019 08:49:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E68C72084B for ; Fri, 12 Jul 2019 08:49:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725877AbfGLIta (ORCPT ); Fri, 12 Jul 2019 04:49:30 -0400 Received: from antares.kleine-koenig.org ([94.130.110.236]:42758 "EHLO antares.kleine-koenig.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726078AbfGLIta (ORCPT ); Fri, 12 Jul 2019 04:49:30 -0400 X-Greylist: delayed 337 seconds by postgrey-1.27 at vger.kernel.org; Fri, 12 Jul 2019 04:49:29 EDT Received: by antares.kleine-koenig.org (Postfix, from userid 1000) id 999A471D4A0; Fri, 12 Jul 2019 10:43:51 +0200 (CEST) Date: Fri, 12 Jul 2019 10:43:46 +0200 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Marc Gonzalez Cc: Antti Palosaari , Mauro Carvalho Chehab , Jonathan =?iso-8859-1?Q?Neusch=E4fer?= , linux-media , LKML , MSM , Brad Love , Bjorn Andersson Subject: Re: [PATCH v3] media: si2168: Refactor command setup code Message-ID: <20190712084343.GA28962@taurus.defre.kleine-koenig.org> References: <544859b5-108a-1909-d612-64f67a02aeec@free.fr> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="5mCyUwZo2JvN/JJP" Content-Disposition: inline In-Reply-To: <544859b5-108a-1909-d612-64f67a02aeec@free.fr> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org --5mCyUwZo2JvN/JJP Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hello, On Thu, Jul 04, 2019 at 12:33:22PM +0200, Marc Gonzalez wrote: > Refactor the command setup code, and let the compiler determine > the size of each command. >=20 > Reviewed-by: Jonathan Neusch=E4fer > Signed-off-by: Marc Gonzalez > --- > Changes from v1: > - Use a real function to populate struct si2168_cmd *cmd, and a trivial > macro wrapping it (macro because sizeof). > Changes from v2: > - Fix header mess > - Add Jonathan's tag > --- > drivers/media/dvb-frontends/si2168.c | 146 +++++++++------------------ > 1 file changed, 45 insertions(+), 101 deletions(-) >=20 > diff --git a/drivers/media/dvb-frontends/si2168.c b/drivers/media/dvb-fro= ntends/si2168.c > index c64b360ce6b5..5e81e076369c 100644 > --- a/drivers/media/dvb-frontends/si2168.c > +++ b/drivers/media/dvb-frontends/si2168.c > @@ -12,6 +12,16 @@ > =20 > static const struct dvb_frontend_ops si2168_ops; > =20 > +static void cmd_setup(struct si2168_cmd *cmd, char *args, int wlen, int = rlen) I'd add an "inline" here. And you could add a const for *args. > +{ > + memcpy(cmd->args, args, wlen); > + cmd->wlen =3D wlen; > + cmd->rlen =3D rlen; > +} > + > +#define CMD_SETUP(cmd, args, rlen) \ > + cmd_setup(cmd, args, sizeof(args) - 1, rlen) Here is the chance to add some static checking. Also it is a good habit to put parens around macro arguments. Something like: #define CMD_SETUP(cmd, args, rlen) ({ \ BUILD_BUG_ON(sizeof((args)) - 1 > SI2168_ARGLEN); cmd_setup((cmd), (args), __must_be_array((args)) + sizeof((args)) - 1, (rl= en)); Maybe let this macro live in drivers/media/dvb-frontends/si2168_priv.h where struct si2168_cmd is defined? I looked over the transformations in the rest of the patch and this looks good. Best regards Uwe --5mCyUwZo2JvN/JJP Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAl0oSDwACgkQwfwUeK3K 7AkeBAf+I6QEDR298PCHto1ijeLdlLRFE7Ietsd+QeVUPOfW8FqfEowGHGd9gmPd kzR3NzgupP4MFxxw00BVwxf9iOeBMo94Q6ggPzBDI4X5BE71jFhwo3+QkJM7XuyX TAHq3pZ5aMInl27Kw54PxqCYRHPozZ4JxnsVys6kJvh/JkaiRMQApxm69ry10J23 u/gBDTnC80FsAjJ0QRSGBzjPytcx0UeAf/RXPodE5mtz0PAiyVefyK6+NRXrxEcW mZqfi8T4azYGcijVK4qU+bSAkRjwwk8Xdthkby1C7IhjR0yOSh2g0ZyH0hG3w4Xi M+2jYIacxtSrd3sDzOvT3k6eB7DS9w== =yXyE -----END PGP SIGNATURE----- --5mCyUwZo2JvN/JJP--