From: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
To: Brad Love <brad@nextdimension.cc>
Cc: "Marc Gonzalez" <marc.w.gonzalez@free.fr>,
"Antti Palosaari" <crope@iki.fi>,
"Jonathan Neuschäfer" <j.neuschaefer@gmx.net>,
linux-media <linux-media@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
MSM <linux-arm-msm@vger.kernel.org>,
"Bjorn Andersson" <bjorn.andersson@linaro.org>
Subject: Re: [PATCH v3] media: si2168: Refactor command setup code
Date: Fri, 12 Jul 2019 14:45:37 -0300 [thread overview]
Message-ID: <20190712144537.2bad2482@coco.lan> (raw)
In-Reply-To: <bde6e367-61a4-7501-2459-eecad5db1d1b@nextdimension.cc>
Em Fri, 12 Jul 2019 10:47:17 -0500
Brad Love <brad@nextdimension.cc> escreveu:
> Hi Marc,
>
> Replying inline.
>
>
> On 04/07/2019 05.33, Marc Gonzalez wrote:
> > Refactor the command setup code, and let the compiler determine
> > the size of each command.
> >
> > Reviewed-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
> > Signed-off-by: Marc Gonzalez <marc.w.gonzalez@free.fr>
> > ---
> > Changes from v1:
> > - Use a real function to populate struct si2168_cmd *cmd, and a trivial
> > macro wrapping it (macro because sizeof).
> > Changes from v2:
> > - Fix header mess
> > - Add Jonathan's tag
> > ---
> > drivers/media/dvb-frontends/si2168.c | 146 +++++++++------------------
> > 1 file changed, 45 insertions(+), 101 deletions(-)
> >
> > diff --git a/drivers/media/dvb-frontends/si2168.c b/drivers/media/dvb-frontends/si2168.c
> > index c64b360ce6b5..5e81e076369c 100644
> > --- a/drivers/media/dvb-frontends/si2168.c
> > +++ b/drivers/media/dvb-frontends/si2168.c
> > @@ -12,6 +12,16 @@
> >
> > static const struct dvb_frontend_ops si2168_ops;
> >
> > +static void cmd_setup(struct si2168_cmd *cmd, char *args, int wlen, int rlen)
> > +{
> > + memcpy(cmd->args, args, wlen);
> > + cmd->wlen = wlen;
> > + cmd->rlen = rlen;
> > +}
> > +
>
>
> struct si2168_cmd.args is u8, not char. I also think const should apply
> to the pointer.
>
>
> > +#define CMD_SETUP(cmd, args, rlen) \
> > + cmd_setup(cmd, args, sizeof(args) - 1, rlen)
> > +
>
>
> This is only a valid helper if args is a null terminated string. It just
> so happens that every instance in this driver is, but that could be a
> silent pitfall if someone used a u8 array with this macro.
Actually, it is uglier than that. Of one writes something like:
char buf[20];
buf[0] = 0x20;
buf[1] = 0x03;
CMD_SETUP(cmd, buf, 0);
// some other init, up to 5 values, then another CMD_SETUP()
sizeof() will evaluate to 20, and not to 2, with would be the
expected buffer size, and it will pass 18 random values.
IMHO, using sizeof() here is a very bad idea.
Regards,
Mauro
next prev parent reply other threads:[~2019-07-12 17:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-04 10:33 [PATCH v3] media: si2168: Refactor command setup code Marc Gonzalez
2019-07-12 8:43 ` Uwe Kleine-König
2019-07-12 9:37 ` Marc Gonzalez
2019-07-12 15:47 ` Brad Love
2019-07-12 17:45 ` Mauro Carvalho Chehab [this message]
2019-07-12 22:11 ` Marc Gonzalez
2019-07-13 10:02 ` Mauro Carvalho Chehab
2019-07-14 18:31 ` Matthias Schwarzott
2019-07-12 21:41 ` Marc Gonzalez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190712144537.2bad2482@coco.lan \
--to=mchehab+samsung@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=brad@nextdimension.cc \
--cc=crope@iki.fi \
--cc=j.neuschaefer@gmx.net \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=marc.w.gonzalez@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).