From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E946C7618F for ; Tue, 16 Jul 2019 14:47:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3D58120880 for ; Tue, 16 Jul 2019 14:47:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727849AbfGPOrk (ORCPT ); Tue, 16 Jul 2019 10:47:40 -0400 Received: from foss.arm.com ([217.140.110.172]:35908 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726997AbfGPOrk (ORCPT ); Tue, 16 Jul 2019 10:47:40 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2B8F0337; Tue, 16 Jul 2019 07:47:39 -0700 (PDT) Received: from e107155-lin (e107155-lin.cambridge.arm.com [10.1.196.42]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 281E63F59C; Tue, 16 Jul 2019 07:47:36 -0700 (PDT) Date: Tue, 16 Jul 2019 15:47:30 +0100 From: Sudeep Holla To: Ulf Hansson Cc: Lorenzo Pieralisi , Mark Rutland , linux-arm-kernel@lists.infradead.org, "Rafael J . Wysocki" , Daniel Lezcano , "Raju P . L . S . S . S . N" , Amit Kucheria , Bjorn Andersson , Stephen Boyd , Niklas Cassel , Tony Lindgren , Kevin Hilman , Lina Iyer , Viresh Kumar , Vincent Guittot , Geert Uytterhoeven , Souvik Chakravarty , linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Lina Iyer , Andy Gross , Sudeep Holla , David Brown Subject: Re: [PATCH 17/18] arm64: dts: Convert to the hierarchical CPU topology layout for MSM8916 Message-ID: <20190716144730.GA7250@e107155-lin> References: <20190513192300.653-1-ulf.hansson@linaro.org> <20190513192300.653-18-ulf.hansson@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190513192300.653-18-ulf.hansson@linaro.org> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Mon, May 13, 2019 at 09:22:59PM +0200, Ulf Hansson wrote: > From: Lina Iyer > > In the hierarchical layout, we are creating power domains around each CPU > and describes the idle states for them inside the power domain provider > node. Note that, the CPU's idle states still needs to be compatible with > "arm,idle-state". > > Furthermore, represent the CPU cluster as a separate master power domain, > powering the CPU's power domains. The cluster node, contains the idle > states for the cluster and each idle state needs to be compatible with the > "domain-idle-state". > > If the running platform is using a PSCI FW that supports the OS initiated > CPU suspend mode, which likely should be the case unless the PSCI FW is > very old, this change triggers the PSCI driver to enable it. > > Cc: Andy Gross > Cc: David Brown > Signed-off-by: Lina Iyer > Co-developed-by: Ulf Hansson > Signed-off-by: Ulf Hansson > --- [...] > @@ -166,12 +170,57 @@ > min-residency-us = <2000>; > local-timer-stop; > }; > + > + CLUSTER_RET: cluster-retention { > + compatible = "domain-idle-state"; > + arm,psci-suspend-param = <0x1000010>; > + entry-latency-us = <500>; > + exit-latency-us = <500>; > + min-residency-us = <2000>; > + }; > + > + CLUSTER_PWRDN: cluster-gdhs { > + compatible = "domain-idle-state"; > + arm,psci-suspend-param = <0x1000030>; > + entry-latency-us = <2000>; > + exit-latency-us = <2000>; > + min-residency-us = <6000>; > + }; > }; > }; I was trying to understand the composition of composite state parameters in this series and that made me look at these DT examples. What format does the above platform use ? I tried matching them to both original as well as extended format and I fail to understand. Assuming original format: State power_state PowerLevel StateType StateID SPC 0x40000002 0(core) 0(Retention) 0x2 (Res0 b[29]=1?) CLUSTER_RET 0x1000010 1(clusters) 0(Retention) 0x10 CLUSTER_PWRDN 0x1000030 1(clusters) 0(Retention?) 0x30 Now extended format: State power_state StateType StateID SPC 0x40000002 0(Retention) 0x40000002 (Res0 b[29]=1?) CLUSTER_RET 0x1000010 0(Retention) 0x1000010 CLUSTER_PWRDN 0x1000030 0(Retention?) 0x1000030 What am I missing ? -- Regards, Sudeep