From: Stephen Boyd <sboyd@kernel.org>
To: agross@kernel.org, bjorn.andersson@linaro.org,
david.brown@linaro.org, devicetree@vger.kernel.org,
gokulsri@codeaurora.org, jassisinghbrar@gmail.com,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-remoteproc@vger.kernel.org,
mark.rutland@arm.com, mturquette@baylibre.com, ohad@wizery.com,
robh+dt@kernel.org, sricharan@codeaurora.org
Subject: Re: [PATCH 12/12] arm64: dts: qcom: Enable Q6v5 WCSS for ipq8074 SoC
Date: Wed, 17 Jul 2019 13:13:26 -0700 [thread overview]
Message-ID: <20190717201326.DCEB520880@mail.kernel.org> (raw)
In-Reply-To: <1562859668-14209-13-git-send-email-gokulsri@codeaurora.org>
Quoting Gokul Sriram Palanisamy (2019-07-11 08:41:08)
> diff --git a/arch/arm64/boot/dts/qcom/ipq8074.dtsi b/arch/arm64/boot/dts/qcom/ipq8074.dtsi
> index 6a61a63..c24e3f6 100644
> --- a/arch/arm64/boot/dts/qcom/ipq8074.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq8074.dtsi
> @@ -10,6 +10,22 @@
> model = "Qualcomm Technologies, Inc. IPQ8074";
> compatible = "qcom,ipq8074";
>
> + reserved-memory {
> + #address-cells = <2>;
> + #size-cells = <2>;
> + ranges;
> +
> + smem_region:smem@4ab00000 {
Put a space between the colon and the node name. Also, just call it
memory@4ab00000.
smem_region: memory@4ab00000 {
> + no-map;
> + reg = <0x0 0x4ab00000 0x0 0x00100000>;
> + };
> +
> + q6_region: q6@4b000000 {
memory@
> + no-map;
> + reg = <0x0 0x4b000000 0x0 0x05f00000>;
> + };
> + };
> +
> firmware {
> scm {
> compatible = "qcom,scm-ipq8074", "qcom,scm";
> @@ -431,6 +447,115 @@
> "axi_m_sticky";
> status = "disabled";
> };
> + apcs: syscon@b111000 {
Add a newline between nodes please.
> + compatible = "syscon";
> + reg = <0x0B111000 0x1000>;
> + };
> +
> + wcss: smp2p-wcss {
This node should be outside the soc node because it doesn't have a reg
property
> + compatible = "qcom,smp2p";
> + qcom,smem = <435>, <428>;
> +
> + interrupt-parent = <&intc>;
> + interrupts = <0 322 1>;
> +
> + qcom,ipc = <&apcs 8 9>;
> +
> + qcom,local-pid = <0>;
> + qcom,remote-pid = <1>;
> +
> + wcss_smp2p_out: master-kernel {
> + qcom,entry-name = "master-kernel";
> + qcom,smp2p-feature-ssr-ack;
> + #qcom,smem-state-cells = <1>;
> + };
> +
> + wcss_smp2p_in: slave-kernel {
> + qcom,entry-name = "slave-kernel";
> +
> + interrupt-controller;
> + #interrupt-cells = <2>;
> + };
> + };
> +
> + tcsr_q6_block: syscon@1945000 {
Do you really need _block in these aliases?
> + compatible = "syscon";
> + reg = <0x1945000 0xE000>;
> + };
> +
> + tcsr_mutex_block: syscon@193d000 {
> + compatible = "syscon";
> + reg = <0x1905000 0x8000>;
> + };
> +
> + tcsr_mutex: hwlock@193d000 {
> + compatible = "qcom,tcsr-mutex";
> + syscon = <&tcsr_mutex_block 0 0x80>;
> + #hwlock-cells = <1>;
> + };
> +
> + smem: qcom,smem@4AB00000 {
lowercase please. And just 'smem' I guess.
> + compatible = "qcom,smem";
> + memory-region = <&smem_region>;
> + hwlocks = <&tcsr_mutex 0>;
> + };
> +
> + apcs_glb: mailbox@b111000 {
> + compatible = "qcom,ipq8074-apcs-apps-global";
> + reg = <0xb111000 0x1000>;
These addresses should be padded out to 8 digits for the address part
(not the size).
> +
> + #mbox-cells = <1>;
> + };
> +
> + q6v5_wcss: q6v5_wcss@CD00000 {
lowercase.
> + compatible = "qcom,ipq8074-wcss-pil";
> + reg = <0xCD00000 0x4040>,
> + <0x4AB000 0x20>;
next prev parent reply other threads:[~2019-07-17 20:13 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-11 15:40 [PATCH 00/12] remoteproc: qcom: q6v5-wcss: Add support for secure pil Gokul Sriram Palanisamy
2019-07-11 15:40 ` [PATCH 01/12] remoteproc: qcom: Add PRNG proxy clock Gokul Sriram Palanisamy
2019-07-11 15:40 ` [PATCH 02/12] remoteproc: qcom: Add secure PIL support Gokul Sriram Palanisamy
2019-07-11 15:40 ` [PATCH 03/12] remoteproc: qcom: Add support for split q6 + m3 wlan firmware Gokul Sriram Palanisamy
2019-07-11 15:41 ` [PATCH 04/12] remoteproc: qcom: Add ssr subdevice identifier Gokul Sriram Palanisamy
2019-07-11 15:41 ` [PATCH 05/12] remoteproc: qcom: Update regmap offsets for halt register Gokul Sriram Palanisamy
2019-07-11 15:41 ` [PATCH 06/12] dt-bindings: clock: qcom: Add reset for WCSSAON Gokul Sriram Palanisamy
2019-07-17 20:08 ` Stephen Boyd
2019-07-24 20:37 ` Rob Herring
2019-07-11 15:41 ` [PATCH 07/12] clk: qcom: Add WCSSAON reset Gokul Sriram Palanisamy
2019-07-17 20:09 ` Stephen Boyd
2019-07-11 15:41 ` [PATCH 08/12] dt-bindings: mailbox: qom: Add ipq8074 APPS compatible Gokul Sriram Palanisamy
2019-07-24 20:37 ` Rob Herring
2019-07-11 15:41 ` [PATCH 09/12] mailbox: qcom: Add support for IPQ8074 APCS Gokul Sriram Palanisamy
2019-07-11 15:41 ` [PATCH 10/12] dt-bindings: firmware: qcom: Add compatible for IPQ8074 SoC Gokul Sriram Palanisamy
2019-07-24 20:38 ` Rob Herring
2019-07-11 15:41 ` [PATCH 11/12] arm64: dts: Add support for scm on IPQ8074 SoCs Gokul Sriram Palanisamy
2019-07-11 15:41 ` [PATCH 12/12] arm64: dts: qcom: Enable Q6v5 WCSS for ipq8074 SoC Gokul Sriram Palanisamy
2019-07-17 20:13 ` Stephen Boyd [this message]
2019-07-18 6:24 ` gokulsri
2019-07-12 5:43 ` [PATCH 00/12] remoteproc: qcom: q6v5-wcss: Add support for secure pil gokulsri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190717201326.DCEB520880@mail.kernel.org \
--to=sboyd@kernel.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=gokulsri@codeaurora.org \
--cc=jassisinghbrar@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mturquette@baylibre.com \
--cc=ohad@wizery.com \
--cc=robh+dt@kernel.org \
--cc=sricharan@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).