From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC77CC7618F for ; Thu, 18 Jul 2019 15:47:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B0C6D21849 for ; Thu, 18 Jul 2019 15:47:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="nWn8WF88" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726715AbfGRPrj (ORCPT ); Thu, 18 Jul 2019 11:47:39 -0400 Received: from mail-pl1-f195.google.com ([209.85.214.195]:41114 "EHLO mail-pl1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726608AbfGRPri (ORCPT ); Thu, 18 Jul 2019 11:47:38 -0400 Received: by mail-pl1-f195.google.com with SMTP id m9so14028375pls.8 for ; Thu, 18 Jul 2019 08:47:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=560PSkF5dpA+2PC3MPuVU9QamTae65D5mdIYq7VhBIY=; b=nWn8WF88sGLEvnb9ZAUWfxOrZrBijsDaLNjzEI37z6o1PMe1syCzFJjND489Yc6+ou aVo7+CR6iQQ96mDwliLCqsSjegPmbtIDdNhpeI3ea7KXgmpnSjHA4vcaGA2m/Rr84uV0 9eSKIotIn4R+piPaKAR5DA5aP8DXUpoOME4bUODykpR7rYft9hAXH9px3AqDkyn7sR9d V1IbuNQS1Ht1/R5Y14LlHlIfsbhgoKeTOUBG5ig4YH3t86kCHkw2UN2suZv4xDGQGKhp iDyLapqZz5RLFl50jSV9imMDVllyL94z1u+Dypr+q+Xi8zGJgowlVGDUrJiOnmRnbxDM J7Kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=560PSkF5dpA+2PC3MPuVU9QamTae65D5mdIYq7VhBIY=; b=sKihWKIaa/glazBK4p8IstKqtGgQ01/cE/dhwH4fJXZZkDEQf2rTuXHD0Gqgc8y7GC of2SllfJ9i+DBEGCL61LzjulPNF+F6Y7MjK65pD7MVyfoJJc5Wq20hjO9D7y6LkKBvMf bcz3RNcAeszcqxuDR/zi8qcJzHT4UDb27IZgGkWXeKw6WyMUfc9aEDeThYu6/UGDobLY IjudWUM0bcyfkC9aFBv+DLEdhCsAc49hKWoPjhp7ngfJc08QIGXqU02dTyfu+BIfEtg2 Ut0ggwBJTt7l9gdqtlKpfXncPsk9Qf9IGiH6QSrvkZn+KJLBTWAvB+KSFscrjqPrWrhZ mEnw== X-Gm-Message-State: APjAAAUm8Abzz3+V6OoD6lz/mcAH61i1PSlOYyxLBT/oIi5r0EPJbmmA qOQ+Pfu3/Fc+uptNR6M0VYPxIopboSk= X-Google-Smtp-Source: APXvYqzrkSMa3rD3Yn3FdqMZT++R/bJ0PBNWrljxysyHeNXu8HhFYIihfsp9bFamug8U81UUhmEQDA== X-Received: by 2002:a17:902:2ac7:: with SMTP id j65mr51319606plb.242.1563464857764; Thu, 18 Jul 2019 08:47:37 -0700 (PDT) Received: from tuxbook-pro (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id f197sm28101015pfa.161.2019.07.18.08.47.36 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 18 Jul 2019 08:47:37 -0700 (PDT) Date: Thu, 18 Jul 2019 08:48:54 -0700 From: Bjorn Andersson To: Mathieu Poirier Cc: Sai Prakash Ranjan , Greg Kroah-Hartman , Suzuki K Poulose , Leo Yan , Alexander Shishkin , Mike Leach , Rob Herring , devicetree@vger.kernel.org, David Brown , Mark Rutland , Rajendra Nayak , Vivek Gautam , Sibi Sankar , linux-arm-kernel , Linux Kernel Mailing List , linux-arm-msm , Marc Gonzalez Subject: Re: [PATCHv8 3/5] arm64: dts: qcom: msm8996: Add Coresight support Message-ID: <20190718154854.GB7234@tuxbook-pro> References: <2fa725fbc09306f1a95befc62715a708b4c0fad0.1562940244.git.saiprakash.ranjan@codeaurora.org> <20190717170050.GB4271@xps15> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Thu 18 Jul 08:31 PDT 2019, Mathieu Poirier wrote: > On Wed, 17 Jul 2019 at 23:47, Sai Prakash Ranjan > wrote: > > > > Hi Mathieu, > > > > On 7/17/2019 10:30 PM, Mathieu Poirier wrote: > > > On Fri, Jul 12, 2019 at 07:46:25PM +0530, Sai Prakash Ranjan wrote: > > >> From: Vivek Gautam > > >> > > >> Enable coresight support by adding device nodes for the > > >> available source, sinks and channel blocks on msm8996. > > >> > > >> This also adds coresight cpu debug nodes. > > >> > > >> Signed-off-by: Vivek Gautam > > >> Signed-off-by: Sai Prakash Ranjan > > >> Reviewed-by: Mathieu Poirier > > >> Acked-By: Suzuki K Poulose > > >> --- > > >> arch/arm64/boot/dts/qcom/msm8996.dtsi | 434 ++++++++++++++++++++++++++ > > >> 1 file changed, 434 insertions(+) > > >> > > > > > > We've gone trhough 8 iteration of this set and I'm still finding checkpatch > > > problems, and I'm not referring to lines over 80 characters. > > > > > > > I only get below 2 checkpatch warnings: > > > > If you are talking about the below one, then it was not added manually. > > It was taken automatically when I pulled in the v7. Should I be > > resending this patch for this? > > That depends if you want David and Andy to pickup your patches - I am > sure they'll point out exactly the same thing. > If it's only the capitalization of "By" then I'll just fix it up as I apply the patches (thanks for pointing it out though!). But it seems the discussion on patch 2 needs to settle(?) (And the merge window has to close). Regards, Bjorn > > > > $ ./scripts/checkpatch.pl -g 2fa725fbc09306f1a95befc62715a708b4c0fad0 > > WARNING: 'Acked-by:' is the preferred signature form > > #14: > > Acked-By: Suzuki K Poulose > > > > WARNING: line over 80 characters > > #154: FILE: arch/arm64/boot/dts/qcom/msm8996.dtsi:763: > > + compatible = "arm,coresight-dynamic-replicator", > > "arm,primecell"; > > > > total: 0 errors, 2 warnings, 440 lines checked > > > > > > -Sai > > > > -- > > QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member > > of Code Aurora Forum, hosted by The Linux Foundation