From: Vinod Koul <vkoul@kernel.org>
To: xiaofeis <xiaofeis@codeaurora.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, andrew@lunn.ch,
linux-arm-msm@vger.kernel.org, bjorn.andersson@linaro.org,
vivien.didelot@gmail.com, f.fainelli@gmail.com,
niklas.cassel@linaro.org, xiazha@codeaurora.org
Subject: Re: [PATCH] qca8k: enable port flow control
Date: Fri, 19 Jul 2019 09:48:00 +0530 [thread overview]
Message-ID: <20190719041800.GK12733@vkoul-mobl.Dlink> (raw)
In-Reply-To: <1563504791-43398-1-git-send-email-xiaofeis@codeaurora.org>
On 19-07-19, 10:53, xiaofeis wrote:
> Set phy device advertising to enable MAC flow control.
How about:
to Pause for enabling MAC flow control
>
> Change-Id: Ibf0f554b072fc73136ec9f7ffb90c20b25a4faae
Please remove this
> Signed-off-by: Xiaofei Shen <xiaofeis@codeaurora.org>
> ---
> drivers/net/dsa/qca8k.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/dsa/qca8k.c b/drivers/net/dsa/qca8k.c
> index d93be14..95ac081 100644
> --- a/drivers/net/dsa/qca8k.c
> +++ b/drivers/net/dsa/qca8k.c
> @@ -1,7 +1,7 @@
> /*
> * Copyright (C) 2009 Felix Fietkau <nbd@nbd.name>
> * Copyright (C) 2011-2012 Gabor Juhos <juhosg@openwrt.org>
> - * Copyright (c) 2015, The Linux Foundation. All rights reserved.
> + * Copyright (c) 2015, 2019, The Linux Foundation. All rights reserved.
> * Copyright (c) 2016 John Crispin <john@phrozen.org>
> *
> * This program is free software; you can redistribute it and/or modify
> @@ -800,6 +800,8 @@
> qca8k_port_set_status(priv, port, 1);
> priv->port_sts[port].enabled = 1;
>
> + phy->advertising |= (ADVERTISED_Pause | ADVERTISED_Asym_Pause);
> +
> return 0;
> }
>
> --
> 1.9.1
--
~Vinod
next prev parent reply other threads:[~2019-07-19 4:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-19 2:53 [PATCH] qca8k: enable port flow control xiaofeis
2019-07-19 4:18 ` Vinod Koul [this message]
2019-07-19 9:31 ` Niklas Cassel
2019-07-19 13:14 ` Andrew Lunn
2019-07-19 13:13 ` Andrew Lunn
2019-07-24 5:09 ` xiaofeis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190719041800.GK12733@vkoul-mobl.Dlink \
--to=vkoul@kernel.org \
--cc=andrew@lunn.ch \
--cc=bjorn.andersson@linaro.org \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=niklas.cassel@linaro.org \
--cc=vivien.didelot@gmail.com \
--cc=xiaofeis@codeaurora.org \
--cc=xiazha@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).