From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 251E3C76188 for ; Fri, 19 Jul 2019 09:31:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EF61F21850 for ; Fri, 19 Jul 2019 09:31:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="S3zV3jWk" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726076AbfGSJbk (ORCPT ); Fri, 19 Jul 2019 05:31:40 -0400 Received: from mail-lf1-f67.google.com ([209.85.167.67]:35814 "EHLO mail-lf1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725794AbfGSJbk (ORCPT ); Fri, 19 Jul 2019 05:31:40 -0400 Received: by mail-lf1-f67.google.com with SMTP id p197so21252291lfa.2 for ; Fri, 19 Jul 2019 02:31:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=By7J6Ek1LpU9WXnfTM3TzV8zMVb06NB+DuQro2Ib0n4=; b=S3zV3jWkivnFOV2YNWvQ5KMrY9Hkg7qwkrqAuq62/ewY2tZT18vY8JxDW588j/EMMc VxXYtc0c+pzbIs7CLVyTEFhFi9TK6Q5/h1IxJQdZRpAMLVAvRMgCAtMqTJ+9hhZ/dZjH 4VoPIgdv/VcOnrjOIUkyAX+dDb67ZKX3URdKwF1o30a+CJGA4jiykmzpjlXxjfca1bAA a/zfXJGeCe5wNqfzSpSlUxjg12os/pJUlnhLuNkhmXRN3xxSxbmBwNvcuQFNDyiHq78v F63HQVkQ4TeEYVQ02W92TajdWyjxLZy2Pbg2kl7hhIS/NPEnfoHrz4aKeLQPY98GSr40 6Nfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=By7J6Ek1LpU9WXnfTM3TzV8zMVb06NB+DuQro2Ib0n4=; b=bVFb4EBqCgj/0bkNsUqMZIF+rvJeVQLbhTcnMdOk5xRrRWrE6HHjayn0kQBskzABzQ Y2qrMxqkvwy9RxhqkKWp5TdTkmjvabYG58T2iwW7lfFASYdLlbUU4Nyxk9V1CT8Fd2VU PGrLCYZUNY+THNmLPSzzH6gCPyRJ4gahyC8Q7D9vVgGQTGjYdhwVEvXDtdF7wnv6rlrv Pnpr2NMTVkcCNH4Uq3RkFySqjajmcLr1RynypnjgGEJrvkAInODpr1B03nWJyNcLWJQt IJUqTSNPKQBDdaB7eAB8V5qPtO3rGEE2C1jBZ7j4b8ggKlkiW5lTmH9itZKhwGwd335m B9ZA== X-Gm-Message-State: APjAAAWz1/zxEfarhChVm4GKtSt4YX1BVOnZ0E08wYS1yormhnS+qWM9 AE7BHYf3dt//cIO0vNgZNo2RoA== X-Google-Smtp-Source: APXvYqzFNhQ1C+ObP3q6fexhlWw2GlVsxxZn8IDrRqcrJVED1FxFdaKt5E6eEA9Gz91toW4LWv2UpA== X-Received: by 2002:a19:6557:: with SMTP id c23mr9969655lfj.12.1563528698345; Fri, 19 Jul 2019 02:31:38 -0700 (PDT) Received: from centauri (ua-83-226-229-61.bbcust.telenor.se. [83.226.229.61]) by smtp.gmail.com with ESMTPSA id b25sm4377431lfq.11.2019.07.19.02.31.36 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 19 Jul 2019 02:31:37 -0700 (PDT) Date: Fri, 19 Jul 2019 11:31:35 +0200 From: Niklas Cassel To: xiaofeis Cc: davem@davemloft.net, vkoul@kernel.org, netdev@vger.kernel.org, andrew@lunn.ch, linux-arm-msm@vger.kernel.org, bjorn.andersson@linaro.org, vivien.didelot@gmail.com, f.fainelli@gmail.com, xiazha@codeaurora.org Subject: Re: [PATCH] qca8k: enable port flow control Message-ID: <20190719093135.GA22605@centauri> References: <1563504791-43398-1-git-send-email-xiaofeis@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1563504791-43398-1-git-send-email-xiaofeis@codeaurora.org> User-Agent: Mutt/1.12.0 (2019-05-25) Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Fri, Jul 19, 2019 at 10:53:11AM +0800, xiaofeis wrote: > Set phy device advertising to enable MAC flow control. > > Change-Id: Ibf0f554b072fc73136ec9f7ffb90c20b25a4faae > Signed-off-by: Xiaofei Shen > --- > drivers/net/dsa/qca8k.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/dsa/qca8k.c b/drivers/net/dsa/qca8k.c > index d93be14..95ac081 100644 > --- a/drivers/net/dsa/qca8k.c > +++ b/drivers/net/dsa/qca8k.c > @@ -1,7 +1,7 @@ > /* > * Copyright (C) 2009 Felix Fietkau > * Copyright (C) 2011-2012 Gabor Juhos > - * Copyright (c) 2015, The Linux Foundation. All rights reserved. > + * Copyright (c) 2015, 2019, The Linux Foundation. All rights reserved. > * Copyright (c) 2016 John Crispin > * > * This program is free software; you can redistribute it and/or modify > @@ -800,6 +800,8 @@ > qca8k_port_set_status(priv, port, 1); > priv->port_sts[port].enabled = 1; > > + phy->advertising |= (ADVERTISED_Pause | ADVERTISED_Asym_Pause); Drop the unnecessary parentheses. Question for DSA maintainers: shouldn't this be implemented in the dsa_switch_ops phylink_validate callback, like it's done for other dsa drivers? Kind regards, Niklas > + > return 0; > } > > -- > 1.9.1 >