From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: David Dai <daidavid1@codeaurora.org>
Cc: georgi.djakov@linaro.org, robh+dt@kernel.org, evgreen@google.com,
ilina@codeaurora.org, seansw@qti.qualcomm.com, elder@linaro.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: interconnect: Update Qualcomm SDM845 DT bindings
Date: Sun, 21 Jul 2019 12:10:02 -0700 [thread overview]
Message-ID: <20190721191002.GH7234@tuxbook-pro> (raw)
In-Reply-To: <1563568344-1274-2-git-send-email-daidavid1@codeaurora.org>
On Fri 19 Jul 13:32 PDT 2019, David Dai wrote:
> Redefine the Network-on-Chip devices to more accurately describe
> the interconnect topology on Qualcomm's SDM845 platform. Each
> interconnect device can communicate with different instances of the
> RPMh hardware which are described as RSCs(Resource State Coordinators).
>
> Signed-off-by: David Dai <daidavid1@codeaurora.org>
I like this and we don't have any consumers in DT yet, so I think this
is good.
But we need a patch to the implementation as well, to have the
provider(s) registered with the new compatibles.
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
> ---
> .../bindings/interconnect/qcom,bcm-voter.txt | 32 +++++++++++++++++
> .../bindings/interconnect/qcom,sdm845.txt | 40 +++++++++++++++++-----
> 2 files changed, 63 insertions(+), 9 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/interconnect/qcom,bcm-voter.txt
>
> diff --git a/Documentation/devicetree/bindings/interconnect/qcom,bcm-voter.txt b/Documentation/devicetree/bindings/interconnect/qcom,bcm-voter.txt
> new file mode 100644
> index 0000000..2cf7da2
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/interconnect/qcom,bcm-voter.txt
> @@ -0,0 +1,32 @@
> +Qualcomm BCM-Voter interconnect driver binding
> +-----------------------------------------------------------
> +
> +The Bus Clock Manager (BCM) is a dedicated hardware accelerator
> +that manages shared system resources by aggregating requests
> +from multiple Resource State Coordinators (RSC). Interconnect
> +providers are able to vote for aggregated thresholds values from
> +consumers by communicating through their respective RSCs.
> +
> +Required properties :
> +- compatible : shall contain only one of the following:
> + "qcom,sdm845-bcm-voter",
> +
> +Examples:
> +
> +apps_rsc: rsc@179c0000 {
> + label = "apps_rsc";
> + compatible = "qcom,rpmh-rsc";
> +
> + apps_bcm_voter: bcm_voter {
> + compatible = "qcom,sdm845-bcm-voter";
> + };
> +}
> +
> +disp_rsc: rsc@179d0000 {
> + label = "disp_rsc";
> + compatible = "qcom,rpmh-rsc";
> +
> + disp_bcm_voter: bcm_voter {
> + compatible = "qcom,sdm845-bcm-voter";
> + };
> +}
> diff --git a/Documentation/devicetree/bindings/interconnect/qcom,sdm845.txt b/Documentation/devicetree/bindings/interconnect/qcom,sdm845.txt
> index 5c4f1d9..27f9ed9 100644
> --- a/Documentation/devicetree/bindings/interconnect/qcom,sdm845.txt
> +++ b/Documentation/devicetree/bindings/interconnect/qcom,sdm845.txt
> @@ -4,21 +4,43 @@ Qualcomm SDM845 Network-On-Chip interconnect driver binding
> SDM845 interconnect providers support system bandwidth requirements through
> RPMh hardware accelerators known as Bus Clock Manager (BCM). The provider is
> able to communicate with the BCM through the Resource State Coordinator (RSC)
> -associated with each execution environment. Provider nodes must reside within
> -an RPMh device node pertaining to their RSC and each provider maps to a single
> -RPMh resource.
> +associated with each execution environment. Provider nodes must point to at
> +least one RPMh device child node pertaining to their RSC and each provider
> +can map to multiple RPMh resources.
>
> Required properties :
> - compatible : shall contain only one of the following:
> - "qcom,sdm845-rsc-hlos"
> + "qcom,sdm845-aggre1_noc",
> + "qcom,sdm845-aggre2_noc",
> + "qcom,sdm845-config_noc",
> + "qcom,sdm845-dc_noc",
> + "qcom,sdm845-gladiator_noc",
> + "qcom,sdm845-mem_noc",
> + "qcom,sdm845-mmss_noc",
> + "qcom,sdm845-system_noc",
> - #interconnect-cells : should contain 1
> +- reg : shall contain base register location and length
> +- qcom,bcm-voter : shall contain phandles to bcm voters
>
> Examples:
>
> -apps_rsc: rsc {
> - rsc_hlos: interconnect {
> - compatible = "qcom,sdm845-rsc-hlos";
> - #interconnect-cells = <1>;
> - };
> +aggre1_noc: interconnect@16e0000 {
> + compatible = "qcom,sdm845-aggre1_noc";
> + reg = <0x16e0000 0xd080>;
> + interconnect-cells = <1>;
> + qcom,bcm-voter = <&apps_bcm_voter>;
> };
>
> +mmss_noc: interconnect@1740000 {
> + compatible = "qcom,sdm845-mmss_noc";
> + reg = <0x1740000 0x1c1000>;
> + interconnect-cells = <1>;
> + qcom,bcm-voter = <&apps_bcm_voter>, <&disp_bcm_voter>;
> +};
> +
> +mem_noc: interconnect@1380000 {
> + compatible = "qcom,sdm845-mem_noc";
> + reg = <0 0x1380000 0 0x27200>;
> + #interconnect-cells = <1>;
> + qcom,bcm-voter = <&apps_bcm_voter>, <&disp_bcm_voter>;
> +};
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
next prev parent reply other threads:[~2019-07-21 19:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-19 20:32 [PATCH 0/2] Redefine interconnect provider DT nodes for SDM845 David Dai
2019-07-19 20:32 ` [PATCH 1/2] dt-bindings: interconnect: Update Qualcomm SDM845 DT bindings David Dai
2019-07-21 19:10 ` Bjorn Andersson [this message]
2019-07-23 14:42 ` Stephen Boyd
2019-07-23 21:48 ` David Dai
2019-07-24 14:18 ` Stephen Boyd
2019-07-24 17:22 ` David Dai
2019-07-24 18:27 ` Stephen Boyd
2019-07-24 20:42 ` David Dai
2019-07-19 20:32 ` [PATCH 2/2] arm64: dts: sdm845: Redefine interconnect provider DT nodes David Dai
2019-07-21 19:13 ` Bjorn Andersson
2019-07-23 18:24 ` David Dai
2019-12-12 19:36 ` Evan Green
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190721191002.GH7234@tuxbook-pro \
--to=bjorn.andersson@linaro.org \
--cc=daidavid1@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=elder@linaro.org \
--cc=evgreen@google.com \
--cc=georgi.djakov@linaro.org \
--cc=ilina@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=seansw@qti.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).