From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Vaishali Thakkar <vaishali.thakkar@linaro.org>
Cc: agross@kernel.org, david.brown@linaro.org,
gregkh@linuxfoundation.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, rafael@kernel.org,
vkoul@kernel.org
Subject: Re: [PATCH v5 0/5] soc: qcom: Add SoC info driver
Date: Mon, 22 Jul 2019 16:23:09 -0700 [thread overview]
Message-ID: <20190722232309.GS30636@minitux> (raw)
In-Reply-To: <20190711213911.23180-1-vaishali.thakkar@linaro.org>
On Thu 11 Jul 14:39 PDT 2019, Vaishali Thakkar wrote:
> This patchset adds SoC info driver which can provide information
> such as Chip ID, Chip family and serial number about Qualcomm SoCs
> to user space via sysfs. Furthermore, it allows userspace to get
> information about custom attributes and various image version
> information via debugfs.
>
> The patchset cleanly applies on top of v5.2-rc7.
Hi Vaishali,
There's no context in the patches so they do not apply properly. Please
resubmit them with appropriate context.
Regards,
Bjorn
>
> Changes since v1:
> - Align ifdefs to left, remove unnecessary debugfs dir
> creation check and fix function signatures in patch 3
> - Fix comment for teh case when serial number is not
> available in patch 1
>
> Changes since v2:
> - Reorder patches [patch five -> patch two]
>
> Changes since v3:
> - Add reviewed-bys from Greg
> - Fix build warning when debugfs is disabled
> - Remove extra checks for dir creations in patch 5
>
> Changes since v4:
> - Added Reviewed-bys in multiple patches
> - Bunch of nitpick fixes in patch 3
> - Major refactoring for using core debugfs functions and
> eliminating duplicate code in patch 4 and 5 [detailed info
> can be found under --- in each patch]
>
> Vaishali Thakkar (5):
> base: soc: Add serial_number attribute to soc
> base: soc: Export soc_device_register/unregister APIs
> soc: qcom: Add socinfo driver
> soc: qcom: socinfo: Expose custom attributes
> soc: qcom: socinfo: Expose image information
>
> Documentation/ABI/testing/sysfs-devices-soc | 7 +
> drivers/base/soc.c | 9 +
> drivers/soc/qcom/Kconfig | 8 +
> drivers/soc/qcom/Makefile | 1 +
> drivers/soc/qcom/smem.c | 9 +
> drivers/soc/qcom/socinfo.c | 468 ++++++++++++++++++++
> include/linux/sys_soc.h | 1 +
> 7 files changed, 503 insertions(+)
> create mode 100644 drivers/soc/qcom/socinfo.c
>
> --
> 2.17.1
>
prev parent reply other threads:[~2019-07-22 23:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-11 21:39 [PATCH v5 0/5] soc: qcom: Add SoC info driver Vaishali Thakkar
2019-07-11 21:39 ` [PATCH v5 1/5] base: soc: Add serial_number attribute to soc Vaishali Thakkar
2019-07-11 21:39 ` [PATCH v5 2/5] base: soc: Export soc_device_register/unregister APIs Vaishali Thakkar
2019-07-11 21:39 ` [PATCH v5 3/5] soc: qcom: Add socinfo driver Vaishali Thakkar
2019-07-11 21:39 ` [PATCH v5 4/5] soc: qcom: socinfo: Expose custom attributes Vaishali Thakkar
2019-07-11 21:39 ` [PATCH v5 5/5] soc: qcom: socinfo: Expose image information Vaishali Thakkar
2019-07-22 23:23 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190722232309.GS30636@minitux \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=david.brown@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=vaishali.thakkar@linaro.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).