From: Viresh Kumar <viresh.kumar@linaro.org>
To: Niklas Cassel <niklas.cassel@linaro.org>
Cc: Andy Gross <agross@kernel.org>,
linux-arm-msm@vger.kernel.org, jorge.ramirez-ortiz@linaro.org,
sboyd@kernel.org, vireshk@kernel.org, bjorn.andersson@linaro.org,
ulf.hansson@linaro.org, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 11/13] arm64: dts: qcom: qcs404: Add CPR and populate OPP table
Date: Tue, 23 Jul 2019 07:26:35 +0530 [thread overview]
Message-ID: <20190723015635.rl5a2isjnjn23fzh@vireshk-i7> (raw)
In-Reply-To: <20190719154558.GA32518@centauri>
On 19-07-19, 17:45, Niklas Cassel wrote:
> Hello Viresh,
>
> Could you please have a look at the last two patches here:
> https://git.linaro.org/people/niklas.cassel/kernel.git/log/?h=cpr-opp-hz
There is no sane way of providing review comments with a link to the
git tree :)
I still had a look and I see that you don't search for max frequency
but just any OPP that has required-opps set to the level u want. Also,
can't there be multiple phandles in required-opps in your case ?
> If you like my proposal then I could send out the first patch (the one to
> OPP core) as a real patch (with an improved commit message), and
> incorporate the second patch into my CPR patch series when I send out a V2.
Send them both in your series only, otherwise the first one is useless
anyway.
--
viresh
next prev parent reply other threads:[~2019-07-23 1:56 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-05 9:57 [PATCH 00/13] Add support for QCOM Core Power Reduction Niklas Cassel
2019-07-05 9:57 ` [PATCH 01/13] dt-bindings: cpufreq: Re-organise kryo cpufreq to use it for other nvmem based qcom socs Niklas Cassel
2019-07-08 6:28 ` Ilia Lin
2019-07-24 14:53 ` Rob Herring
2019-07-05 9:57 ` [PATCH 02/13] cpufreq: qcom: " Niklas Cassel
2019-07-08 6:27 ` Ilia Lin
2019-07-10 6:18 ` Viresh Kumar
2019-07-16 11:11 ` Niklas Cassel
2019-07-05 9:57 ` [PATCH 03/13] dt-bindings: cpufreq: qcom-nvmem: Make speedbin related properties optional Niklas Cassel
2019-07-08 6:28 ` Ilia Lin
2019-07-24 14:56 ` Rob Herring
2019-07-05 9:57 ` [PATCH 04/13] cpufreq: qcom: Refactor the driver to make it easier to extend Niklas Cassel
2019-07-08 6:30 ` Ilia Lin
2019-07-10 6:30 ` Viresh Kumar
2019-07-16 11:11 ` Niklas Cassel
2019-07-05 9:57 ` [PATCH 05/13] dt-bindings: cpufreq: qcom-nvmem: Support pstates provided by a power domain Niklas Cassel
2019-07-24 15:26 ` Rob Herring
2019-07-05 9:57 ` [PATCH 06/13] cpufreq: qcom: Add support for qcs404 on nvmem driver Niklas Cassel
2019-07-05 9:57 ` [PATCH 07/13] cpufreq: Add qcs404 to cpufreq-dt-platdev blacklist Niklas Cassel
2019-07-05 9:57 ` [PATCH 08/13] dt-bindings: opp: Add qcom-opp bindings with properties needed for CPR Niklas Cassel
2019-07-24 16:03 ` Rob Herring
2019-07-05 9:57 ` [PATCH 09/13] dt-bindings: power: avs: Add support for CPR (Core Power Reduction) Niklas Cassel
2019-07-24 16:06 ` Rob Herring
2019-07-05 9:57 ` [PATCH 10/13] " Niklas Cassel
2019-07-05 9:57 ` [PATCH 11/13] arm64: dts: qcom: qcs404: Add CPR and populate OPP table Niklas Cassel
2019-07-10 9:03 ` Viresh Kumar
2019-07-15 13:24 ` Niklas Cassel
2019-07-16 10:34 ` Viresh Kumar
2019-07-16 10:53 ` Niklas Cassel
2019-07-17 4:49 ` Viresh Kumar
2019-07-19 15:45 ` Niklas Cassel
2019-07-23 1:56 ` Viresh Kumar [this message]
2019-07-25 10:40 ` Niklas Cassel
2019-07-05 9:57 ` [PATCH 12/13] arm64: defconfig: enable CONFIG_QCOM_CPR Niklas Cassel
2019-07-05 9:57 ` [PATCH 13/13] arm64: defconfig: enable CONFIG_ARM_QCOM_CPUFREQ_NVMEM Niklas Cassel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190723015635.rl5a2isjnjn23fzh@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jorge.ramirez-ortiz@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=niklas.cassel@linaro.org \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).