From: Vinod Koul <vkoul@kernel.org>
To: Stephen Boyd <swboyd@chromium.org>
Cc: Andy Gross <agross@kernel.org>,
linux-arm-msm@vger.kernel.org,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] arm64: dts: qcom: sdm845: Add unit name to soc node
Date: Wed, 24 Jul 2019 09:37:43 +0530 [thread overview]
Message-ID: <20190724040743.GB12733@vkoul-mobl.Dlink> (raw)
In-Reply-To: <5d371e9d.1c69fb81.8d9f4.1ac0@mx.google.com>
On 23-07-19, 07:50, Stephen Boyd wrote:
> Quoting Vinod Koul (2019-07-22 05:34:18)
> > We get a warning about missing unit name for soc node, so add it.
> >
> > arch/arm64/boot/dts/qcom/sdm845.dtsi:623.11-2814.4: Warning (unit_address_vs_reg): /soc: node has a reg or ranges property, but no unit name
> >
> > Signed-off-by: Vinod Koul <vkoul@kernel.org>
> > ---
>
> Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Thanks for the review
>
> > diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> > index 601cfb078bd5..e81f4a6d08ce 100644
> > --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> > @@ -620,7 +620,7 @@
> > method = "smc";
> > };
> >
> > - soc: soc {
> > + soc: soc@0 {
>
> This is kinda sad, but ok. Maybe you can apply this fix to at least all
> the qcom boards then.
Yeah that is the idea, start with sdm845 and 'reduce' the warns on all
qcom dts files
--
~Vinod
next prev parent reply other threads:[~2019-07-24 4:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-22 12:34 [PATCH 0/5] arm64: dts: qcom: sdm845: Fix DTS warnings Vinod Koul
2019-07-22 12:34 ` [PATCH 1/5] arm64: dts: qcom: sdm845: Add unit name to soc node Vinod Koul
2019-07-23 14:50 ` Stephen Boyd
2019-07-24 4:07 ` Vinod Koul [this message]
2019-07-22 12:34 ` [PATCH 2/5] arm64: dts: qcom: sdm845: remove unnecessary properties for dsi nodes Vinod Koul
2019-07-23 14:45 ` Stephen Boyd
2019-07-22 12:34 ` [PATCH 3/5] arm64: dts: qcom: sdm845: remove unit name for thermal trip points Vinod Koul
2019-07-23 14:47 ` Stephen Boyd
2019-07-22 12:34 ` [PATCH 4/5] arm64: dts: qcom: sdm845: remove macro from unit name Vinod Koul
2019-07-22 13:18 ` Marc Gonzalez
2019-07-22 13:48 ` Vinod Koul
2019-07-22 12:34 ` [PATCH 5/5] arm64: dts: qcom: sdm845-cheza: " Vinod Koul
2019-07-23 5:08 ` Amit Kucheria
2019-07-23 5:14 ` Vinod Koul
2019-07-23 5:41 ` Bjorn Andersson
2019-07-23 14:51 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190724040743.GB12733@vkoul-mobl.Dlink \
--to=vkoul@kernel.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).