From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07A5FC433FF for ; Thu, 1 Aug 2019 06:18:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A18F3216C8 for ; Thu, 1 Aug 2019 06:18:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564640285; bh=P7+ACBH9J5mTnDheikQW7WOAS+HoMLWPjzJygxs6sMA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=tebmQr1Z4T7b0L3qgkYF/fdFl0FG8yCSTbY+cwRxtSuf4Cn6xJb9bsW7is1ImteI+ 9Ybz+DYSJ3aeXpw0uktJNN5Ekf2EqQEVTPy/IO09CPOgcSN9RyFa+/WpwMW3Y8n2dU YBqBIYT31nq9tvIrOgRSF8TaJYKizA4f6JF691sM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729226AbfHAGSF (ORCPT ); Thu, 1 Aug 2019 02:18:05 -0400 Received: from mail.kernel.org ([198.145.29.99]:57506 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728884AbfHAGSE (ORCPT ); Thu, 1 Aug 2019 02:18:04 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6EDBC206A3; Thu, 1 Aug 2019 06:18:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564640283; bh=P7+ACBH9J5mTnDheikQW7WOAS+HoMLWPjzJygxs6sMA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Gpc+lB55+mtiUztM8rfj9Me584E3lPqEIfzL0dMJfaRla1hs1CZsZz7iQFjdiJzfU wv3d8zKZ0NSuxjK/IRpQBTGnJ0OeSpcIxKFpWFtpY99JupeJ93Ba0skNlYsMOJewoz yc5sOggjdNqt405T59V7d9QAnkynqcHVMmi05D0s= Date: Thu, 1 Aug 2019 08:18:01 +0200 From: Greg Kroah-Hartman To: Scott Branden Cc: Luis Chamberlain , David Brown , Alexander Viro , "Rafael J . Wysocki" , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-fsdevel@vger.kernel.org, BCM Kernel Feedback , Olof Johansson Subject: Re: [PATCH 2/3] firmware: add offset to request_firmware_into_buf Message-ID: <20190801061801.GA4338@kroah.com> References: <20190523025113.4605-1-scott.branden@broadcom.com> <20190523025113.4605-3-scott.branden@broadcom.com> <20190523055233.GB22946@kroah.com> <15c47e4d-e70d-26bb-9747-0ad0aa81597b@broadcom.com> <20190523165424.GA21048@kroah.com> <44282070-ddaf-3afb-9bdc-4751e3f197ac@broadcom.com> <20190524052258.GB28229@kroah.com> <2f67db0a-27c3-d13c-bbe0-0af5edd4f0da@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2f67db0a-27c3-d13c-bbe0-0af5edd4f0da@broadcom.com> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Wed, Jul 31, 2019 at 05:18:32PM -0700, Scott Branden wrote: > Hi Greg, > > I am now back from leave to continue this patch.  Comment below. > > On 2019-05-23 10:22 p.m., Greg Kroah-Hartman wrote: > > On Thu, May 23, 2019 at 10:01:38PM -0700, Scott Branden wrote: > > > On 2019-05-23 9:54 a.m., Greg Kroah-Hartman wrote: > > > > On Thu, May 23, 2019 at 09:36:02AM -0700, Scott Branden wrote: > > > > > Hi Greg, > > > > > > > > > > On 2019-05-22 10:52 p.m., Greg Kroah-Hartman wrote: > > > > > > On Wed, May 22, 2019 at 07:51:12PM -0700, Scott Branden wrote: > > > > > > > Add offset to request_firmware_into_buf to allow for portions > > > > > > > of firmware file to be read into a buffer. Necessary where firmware > > > > > > > needs to be loaded in portions from file in memory constrained systems. > > > > > > > > > > > > > > Signed-off-by: Scott Branden > > > > > > > --- > > > > > > > drivers/base/firmware_loader/firmware.h | 5 +++ > > > > > > > drivers/base/firmware_loader/main.c | 49 +++++++++++++++++-------- > > > > > > > include/linux/firmware.h | 8 +++- > > > > > > > 3 files changed, 45 insertions(+), 17 deletions(-) > > > > > > No new firmware test for this new option? How do we know it even works? > > > > > I was unaware there are existing firmware tests.  Please let me know where > > > > > these tests exists and I can add a test for this new option. > > > > tools/testing/selftests/firmware/ > > > Unfortunately, there doesn't seem to be a test for the existing > > > request_firmware_into_buf api. > > Are you sure? The test is for userspace functionality, there isn't > > kernel unit tests here. You need to verify that you didn't break > > existing functionality as well as verify that your new functionality > > works. > > I managed to figure out how to build and run > tools/testing/selftest/firmware/fw_run_tests.sh > > and my changes don't break existing functionality. > > But, I find no use of request_firmware_into_buf in lib/test_firmware.c > (triggered by fw_run_tests.sh). > > Is there another test for request_firmware_into_buf? I have no idea, sorry. greg k-h