From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Andy Gross <agross@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: [PATCH] soc: qcom: socinfo: Annotate switch cases with fall through
Date: Wed, 7 Aug 2019 11:50:43 +1000 [thread overview]
Message-ID: <20190807115043.2ff429c1@canb.auug.org.au> (raw)
In-Reply-To: <20190807012457.16820-1-bjorn.andersson@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 499 bytes --]
Hi Bjorn,
On Tue, 6 Aug 2019 18:24:57 -0700 Bjorn Andersson <bjorn.andersson@linaro.org> wrote:
>
> qcom_socinfo->dbg_root,
> &qcom_socinfo->info.raw_device_num);
> + /* Fall through */
> case SOCINFO_VERSION(0, 11):
> + /* Fall through */
> case SOCINFO_VERSION(0, 10):
> + /* Fall through */
> case SOCINFO_VERSION(0, 9):
I don't think you need the comment between consecutive "case"s - just
where there is actual code.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-08-07 1:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190807100803.63007737@canb.auug.org.au>
2019-08-07 1:24 ` [PATCH] soc: qcom: socinfo: Annotate switch cases with fall through Bjorn Andersson
2019-08-07 1:40 ` Gustavo A. R. Silva
2019-08-07 1:50 ` Stephen Rothwell [this message]
2019-08-07 2:18 ` Bjorn Andersson
2019-08-07 2:23 ` [PATCH v2] " Bjorn Andersson
2019-08-07 4:25 ` Vaishali Thakkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190807115043.2ff429c1@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).