From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 125CCC433FF for ; Fri, 9 Aug 2019 17:00:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D24BB21743 for ; Fri, 9 Aug 2019 17:00:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="kH0Y5j1n" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2407515AbfHIRAk (ORCPT ); Fri, 9 Aug 2019 13:00:40 -0400 Received: from mail-pl1-f196.google.com ([209.85.214.196]:42101 "EHLO mail-pl1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2407453AbfHIRAk (ORCPT ); Fri, 9 Aug 2019 13:00:40 -0400 Received: by mail-pl1-f196.google.com with SMTP id ay6so45242703plb.9 for ; Fri, 09 Aug 2019 10:00:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=iQe6ew6EIuFXeLlZv8LtrdQvCD02fcDe9gmuPP3qi/s=; b=kH0Y5j1nHYWzkDq/Qoxxr4NC+cgj7xa9ho1tUL8KA3hZmnbes2pVZZBrUehMulpgE9 ibMetjDE0ZoqqFdfeAqlc83Fgvp/MFu1J3JFJiQ7ej+YSW1Zind6hD5/Y3sx/KtmUfOu WSEPt8T+XVfhruKADp6OaFA7jcNxhqICyhEdeP2uA3HrcwuTy0TqEqNTWjlY5Doftboi 2kOCzU6+nkze2uRTYir0coAyGplP2+rQR8Z1fd1rI5aEYCpiaAHzmkzSfu0H6KiAVM/S Dzu9mdpMeRnVI5DtT1/SqUh7GwG56TX+t/RR1tLTxmflgFXk+cp4orm9bfcz+wW5QcTp deBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=iQe6ew6EIuFXeLlZv8LtrdQvCD02fcDe9gmuPP3qi/s=; b=rVHywO/SOq0g6LmT4stCKYf6MsJFSq0IHUHNj8OIwOiNf09P/FSQsgtECkdem8QWrh 14sye6zI7MW17wABU2hyxJTQPdAH0NhTefrCSuQiAn/uSBXXtllLn4DZQq9G3DGKDqrJ YpvBaK0RpE4eagRgzVwyZab77l0hcvOswge1qyk+Qx3fZKfHZ5d8NeP7aGBCLpKNQ7Th gLlizxbrzhDVsxJvy66mYTXJeAK4VcMSaAlhLFpoHIHRJJ7ek8yRh+PFcZj95wz6lMq0 /KISfbItOetlksisD6wnZBUvmmniUdEyMRE6jmxzIUn2Zz/Xoxs06VeiO43UyfRTTqy+ NiFQ== X-Gm-Message-State: APjAAAWARhImaaPaydpyXeKQVpFsxqNK0jy1DZ2NuvbTMW7e+n0jrlyd 1Jrk6Ia8JTg+9G0yfC0KGgpgAuVixi0= X-Google-Smtp-Source: APXvYqyH7lr5etiJgvdBKU7PpRWbpeGLt963jNmcvwdSEeNDY0Eij8BM6SIM9Ih5P6YBlGFRLHaavg== X-Received: by 2002:a17:902:30d:: with SMTP id 13mr9943532pld.284.1565370039322; Fri, 09 Aug 2019 10:00:39 -0700 (PDT) Received: from tuxbook-pro (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id 5sm35954078pgh.93.2019.08.09.10.00.38 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 09 Aug 2019 10:00:38 -0700 (PDT) Date: Fri, 9 Aug 2019 10:02:13 -0700 From: Bjorn Andersson To: Vinod Koul Cc: Mark Brown , linux-arm-msm@vger.kernel.org, Andy Gross , Liam Girdwood , Rob Herring , Mark Rutland , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH 2/4] regulator: qcom-rpmh: Sort the compatibles Message-ID: <20190809170213.GN26807@tuxbook-pro> References: <20190809073616.1235-1-vkoul@kernel.org> <20190809073616.1235-2-vkoul@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190809073616.1235-2-vkoul@kernel.org> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Archived-At: List-Archive: List-Post: On Fri 09 Aug 00:36 PDT 2019, Vinod Koul wrote: > It helps to keep sorted order for compatibles, so sort them > > Suggested-by: Bjorn Andersson > Signed-off-by: Vinod Koul Reviewed-by: Bjorn Andersson > --- > drivers/regulator/qcom-rpmh-regulator.c | 20 ++++++++++---------- > 1 file changed, 10 insertions(+), 10 deletions(-) > > diff --git a/drivers/regulator/qcom-rpmh-regulator.c b/drivers/regulator/qcom-rpmh-regulator.c > index 693ffec62f3e..0ef2716da3bd 100644 > --- a/drivers/regulator/qcom-rpmh-regulator.c > +++ b/drivers/regulator/qcom-rpmh-regulator.c > @@ -878,18 +878,14 @@ static int rpmh_regulator_probe(struct platform_device *pdev) > } > > static const struct of_device_id rpmh_regulator_match_table[] = { > - { > - .compatible = "qcom,pm8998-rpmh-regulators", > - .data = pm8998_vreg_data, > - }, > - { > - .compatible = "qcom,pmi8998-rpmh-regulators", > - .data = pmi8998_vreg_data, > - }, > { > .compatible = "qcom,pm8005-rpmh-regulators", > .data = pm8005_vreg_data, > }, > + { > + .compatible = "qcom,pm8009-rpmh-regulators", > + .data = pm8009_vreg_data, > + }, > { > .compatible = "qcom,pm8150-rpmh-regulators", > .data = pm8150_vreg_data, > @@ -899,8 +895,12 @@ static const struct of_device_id rpmh_regulator_match_table[] = { > .data = pm8150l_vreg_data, > }, > { > - .compatible = "qcom,pm8009-rpmh-regulators", > - .data = pm8009_vreg_data, > + .compatible = "qcom,pm8998-rpmh-regulators", > + .data = pm8998_vreg_data, > + }, > + { > + .compatible = "qcom,pmi8998-rpmh-regulators", > + .data = pmi8998_vreg_data, > }, > {} > }; > -- > 2.20.1 >