From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BE8FC433FF for ; Wed, 14 Aug 2019 17:23:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 53DD5206C1 for ; Wed, 14 Aug 2019 17:23:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565803393; bh=1PjyB53SE5ISTW3kYQPPKdvQAcURDsEDX3z1n5W5Ncs=; h=In-Reply-To:References:Subject:From:Cc:To:Date:List-ID:From; b=WMSOYvgYp5YdR4Cy4kFArNTvEmg9kywu9DgQ6VJNaLqRIEKMS6zqlQDNx2ZOAxIXz lUv5yQZQbKdu89qIqwcBY7NqmMQkg2h9sTQeC+rb4Qcvl8qStmmIRdxwLMLg5nNe61 DyYfRb25snYSRbtaxhdm1xDrhmGo+ZguNmM5LvHE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729507AbfHNRIF (ORCPT ); Wed, 14 Aug 2019 13:08:05 -0400 Received: from mail.kernel.org ([198.145.29.99]:57900 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730049AbfHNRIF (ORCPT ); Wed, 14 Aug 2019 13:08:05 -0400 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DEFCC214DA; Wed, 14 Aug 2019 17:08:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565802484; bh=1PjyB53SE5ISTW3kYQPPKdvQAcURDsEDX3z1n5W5Ncs=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=RCCzAshXp3+krsNHFGqQiq5XI5PlLhffpj2vyugoA1i9+VSgSe1Ab6xaCzPLzrRRq jgwPdVi/ErGjUXC4wM0jK/zzTYfsgsCAB6tt8aqNcZlA1bGaJg8EtieSfirhKXAbcs xXHddlF/sHlSVloSOI09+Gg8f63YnINcVE/9i+GI= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20190814125012.8700-11-vkoul@kernel.org> References: <20190814125012.8700-1-vkoul@kernel.org> <20190814125012.8700-11-vkoul@kernel.org> Subject: Re: [PATCH 10/22] arm64: dts: qcom: pm8150b: Add pon and adc nodes From: Stephen Boyd Cc: linux-arm-msm@vger.kernel.org, Bjorn Andersson , sibis@codeaurora.org, Vinod Koul , Rob Herring , Mark Rutland , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org To: Andy Gross , Vinod Koul User-Agent: alot/0.8.1 Date: Wed, 14 Aug 2019 10:08:02 -0700 Message-Id: <20190814170803.DEFCC214DA@mail.kernel.org> Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Archived-At: List-Archive: List-Post: Quoting Vinod Koul (2019-08-14 05:50:00) > Add the pon and adc nodes found in pm8150b PMIC. >=20 > Signed-off-by: Vinod Koul > --- > arch/arm64/boot/dts/qcom/pm8150b.dtsi | 54 +++++++++++++++++++++++++++ > 1 file changed, 54 insertions(+) Squash? >=20 > diff --git a/arch/arm64/boot/dts/qcom/pm8150b.dtsi b/arch/arm64/boot/dts/= qcom/pm8150b.dtsi > index c0a678b0f159..846197bd65cd 100644 > --- a/arch/arm64/boot/dts/qcom/pm8150b.dtsi > +++ b/arch/arm64/boot/dts/qcom/pm8150b.dtsi > @@ -2,6 +2,7 @@ > // Copyright (c) 2017-2019, The Linux Foundation. All rights reserved. > // Copyright (c) 2019, Linaro Limited > =20 > +#include > #include > #include > =20 > @@ -11,6 +12,59 @@ > reg =3D <0x2 SPMI_USID>; > #address-cells =3D <1>; > #size-cells =3D <0>; > + > + pon@800 { Maybe pon node name should be 'key' or 'power-on'? > + compatible =3D "qcom,pm8916-pon"; > + reg =3D <0x0800>; > + }; > + > + adc@3100 { > + compatible =3D "qcom,spmi-adc5"; > + reg =3D <0x3100>; > + #address-cells =3D <1>; > + #size-cells =3D <0>; > + #io-channel-cells =3D <1>; > + interrupts =3D <0x2 0x31 0x0 IRQ_TYPE_EDGE_RISING= >; > + > + ref-gnd@0 { > + reg =3D ; > + qcom,pre-scaling =3D <1 1>; > + label =3D "ref_gnd"; > + }; > + > + vref-1p25@1 { > + reg =3D ; > + qcom,pre-scaling =3D <1 1>; > + label =3D "vref_1p25"; > + }; > + > + die-temp@6 { > + reg =3D ; > + qcom,pre-scaling =3D <1 1>; > + label =3D "die_temp"; > + }; > + > + chg-temp@9 { > + reg =3D ; > + qcom,pre-scaling =3D <1 1>; > + label =3D "chg_temp"; > + }; > + > + smb1390-therm@14 { > + reg =3D ; > + qcom,hw-settle-time =3D <200>; > + qcom,pre-scaling =3D <1 1>; > + label =3D "smb1390_therm"; > + }; > + > + smb1355-therm@78 { > + reg =3D ; > + qcom,ratiometric; > + qcom,hw-settle-time =3D <200>; > + qcom,pre-scaling =3D <1 1>; > + label =3D "smb1355_therm"; > + }; Again, are these board level details? Maybe should be provided here with status =3D "disabled" and then added by the boards that use these ADCs. > + }; > };