From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4327CC32757 for ; Wed, 14 Aug 2019 17:18:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 19302206C2 for ; Wed, 14 Aug 2019 17:18:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565803101; bh=FAAciiWxMv2HbnmTuQi2r+sFmhndjmM10hnTqGnrU6s=; h=In-Reply-To:References:Subject:From:Cc:To:Date:List-ID:From; b=B0PjOy1qHPjJFU65v0oBI6GhzrwZxHP/ILJZGF4p4AYvyIkkfV+o01+q/MaAMlRlM 1MakjCqX56Pd+348kARAUK/cv7n1K19L3XzW5PuzEkPySOU6oA38sWmpn+949Gjkp/ sW43FLKQ5y1DqPnNgdway0YfWKqSEzmrnYPEID7U= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730414AbfHNRSU (ORCPT ); Wed, 14 Aug 2019 13:18:20 -0400 Received: from mail.kernel.org ([198.145.29.99]:36510 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730764AbfHNRMg (ORCPT ); Wed, 14 Aug 2019 13:12:36 -0400 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6BE1721721; Wed, 14 Aug 2019 17:12:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565802755; bh=FAAciiWxMv2HbnmTuQi2r+sFmhndjmM10hnTqGnrU6s=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=IZW4vquRvp6nTj8xECSl2DsQWLZ9UlVhL77SlELIL1od7nOKA4H1KK2IJ3DhqvmQA pWFJi505fBwDJQKH4P1EgHfemTDtb6CLSkLWLJ7IFrp3ho57pMsC/kv7b2r1NNbqgQ 4gNEeH53a9ZmaPLH/dF/81wJdJXYiNBuCFP+4r9c= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20190814125012.8700-18-vkoul@kernel.org> References: <20190814125012.8700-1-vkoul@kernel.org> <20190814125012.8700-18-vkoul@kernel.org> Subject: Re: [PATCH 17/22] arm64: dts: qcom: sm8150: Add apss_shared and apps_rsc nodes From: Stephen Boyd Cc: linux-arm-msm@vger.kernel.org, Bjorn Andersson , sibis@codeaurora.org, Vinod Koul , Rob Herring , Mark Rutland , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org To: Andy Gross , Vinod Koul User-Agent: alot/0.8.1 Date: Wed, 14 Aug 2019 10:12:34 -0700 Message-Id: <20190814171235.6BE1721721@mail.kernel.org> Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Quoting Vinod Koul (2019-08-14 05:50:07) > Add apss_shared and apps_rsc node including the rpmhcc child node >=20 > Signed-off-by: Vinod Koul > --- Can't this be squashed with the original dtsi file? > arch/arm64/boot/dts/qcom/sm8150.dtsi | 30 ++++++++++++++++++++++++++++ > 1 file changed, 30 insertions(+) >=20 > diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/q= com/sm8150.dtsi > index 5c6b103b042b..5258b79676f6 100644 > --- a/arch/arm64/boot/dts/qcom/sm8150.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi > @@ -4,6 +4,7 @@ > =20 > #include > #include > +#include But not the rpmh clk bindings? > @@ -272,6 +279,29 @@ > }; > }; > =20 > + apps_rsc: rsc@18200000 { > + label =3D "apps_rsc"; > + compatible =3D "qcom,rpmh-rsc"; > + reg =3D <0x18200000 0x10000>, > + <0x18210000 0x10000>, > + <0x18220000 0x10000>; > + reg-names =3D "drv-0", "drv-1", "drv-2"; > + interrupts =3D , > + , > + ; > + qcom,tcs-offset =3D <0xd00>; > + qcom,drv-id =3D <2>; > + qcom,tcs-config =3D , > + , > + , > + ; > + > + rpmhcc: clock-controller { > + compatible =3D "qcom,sm8150-rpmh-clk"; > + #clock-cells =3D <1>; Should take some sort of clocks property to get the board clock for XO? > + }; > + }; > + =20