Linux-ARM-MSM Archive on lore.kernel.org
 help / color / Atom feed
From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Vinod Koul <vkoul@kernel.org>
Cc: Andy Gross <agross@kernel.org>,
	linux-arm-msm@vger.kernel.org, sibis@codeaurora.org,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Stephen Boyd <sboyd@kernel.org>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 10/22] arm64: dts: qcom: pm8150b: Add pon and adc nodes
Date: Wed, 14 Aug 2019 11:00:47 -0700
Message-ID: <20190814180047.GH6167@minitux> (raw)
In-Reply-To: <20190814125012.8700-11-vkoul@kernel.org>

On Wed 14 Aug 05:50 PDT 2019, Vinod Koul wrote:

> Add the pon and adc nodes found in pm8150b PMIC.
> 
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
> ---
>  arch/arm64/boot/dts/qcom/pm8150b.dtsi | 54 +++++++++++++++++++++++++++
>  1 file changed, 54 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/pm8150b.dtsi b/arch/arm64/boot/dts/qcom/pm8150b.dtsi
> index c0a678b0f159..846197bd65cd 100644
> --- a/arch/arm64/boot/dts/qcom/pm8150b.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pm8150b.dtsi
> @@ -2,6 +2,7 @@
>  // Copyright (c) 2017-2019, The Linux Foundation. All rights reserved.
>  // Copyright (c) 2019, Linaro Limited
>  
> +#include <dt-bindings/iio/qcom,spmi-vadc.h>
>  #include <dt-bindings/interrupt-controller/irq.h>
>  #include <dt-bindings/spmi/spmi.h>
>  
> @@ -11,6 +12,59 @@
>  		reg = <0x2 SPMI_USID>;
>  		#address-cells = <1>;
>  		#size-cells = <0>;
> +
> +		pon@800 {
> +			compatible = "qcom,pm8916-pon";
> +			reg = <0x0800>;
> +		};
> +
> +		adc@3100 {
> +			compatible = "qcom,spmi-adc5";
> +			reg = <0x3100>;
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +			#io-channel-cells = <1>;
> +			interrupts = <0x2 0x31 0x0 IRQ_TYPE_EDGE_RISING>;
> +
> +			ref-gnd@0 {
> +				reg = <ADC5_REF_GND>;
> +				qcom,pre-scaling = <1 1>;
> +				label = "ref_gnd";
> +			};
> +
> +			vref-1p25@1 {
> +				reg = <ADC5_1P25VREF>;
> +				qcom,pre-scaling = <1 1>;
> +				label = "vref_1p25";
> +			};
> +
> +			die-temp@6 {
> +				reg = <ADC5_DIE_TEMP>;
> +				qcom,pre-scaling = <1 1>;
> +				label = "die_temp";
> +			};
> +
> +			chg-temp@9 {
> +				reg = <ADC5_CHG_TEMP>;
> +				qcom,pre-scaling = <1 1>;
> +				label = "chg_temp";
> +			};
> +

I believe the above items are internal, so it makes sense to keep them
here, the below amux ones relates to board configuration so I think
those should go in the board file.

Regards,
Bjorn

> +			smb1390-therm@14 {
> +				reg = <ADC5_AMUX_THM2>;
> +				qcom,hw-settle-time = <200>;
> +				qcom,pre-scaling = <1 1>;
> +				label = "smb1390_therm";
> +			};
> +
> +			smb1355-therm@78 {
> +				reg = <ADC5_AMUX_THM2_100K_PU>;
> +				qcom,ratiometric;
> +				qcom,hw-settle-time = <200>;
> +				qcom,pre-scaling = <1 1>;
> +				label = "smb1355_therm";
> +			};
> +		};
>  	};
>  
>  	qcom,pm8150@3 {
> -- 
> 2.20.1
> 

  parent reply index

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-14 12:49 [PATCH 00/22] arm64: dts: qcom: sm8150: Add SM8150 DTS Vinod Koul
2019-08-14 12:49 ` [PATCH 01/22] arm64: dts: qcom: sm8150: add base dts file Vinod Koul
2019-08-14 16:58   ` Stephen Boyd
2019-08-14 17:44     ` Bjorn Andersson
2019-08-14 18:35       ` Stephen Boyd
2019-08-14 19:02         ` Bjorn Andersson
2019-08-14 17:50   ` Bjorn Andersson
2019-08-14 12:49 ` [PATCH 02/22] arm64: dts: qcom: sm8150-mtp: " Vinod Koul
2019-08-14 17:53   ` Bjorn Andersson
2019-08-14 12:49 ` [PATCH 03/22] arm64: dts: qcom: sm8150: add tlmm node Vinod Koul
2019-08-14 17:01   ` Stephen Boyd
2019-08-19 17:09     ` Vinod Koul
2019-08-14 12:49 ` [PATCH 04/22] arm64: dts: qcom: sm8150-mtp: add tlmm reserved range Vinod Koul
2019-08-14 17:01   ` Stephen Boyd
2019-08-14 12:49 ` [PATCH 05/22] arm64: dts: qcom: sm8150: Add spmi node Vinod Koul
2019-08-14 17:01   ` Stephen Boyd
2019-08-14 12:49 ` [PATCH 06/22] arm64: dts: qcom: pm8150: Add Base DTS file Vinod Koul
2019-08-14 17:03   ` Stephen Boyd
2019-08-19 17:28     ` Vinod Koul
2019-08-14 12:49 ` [PATCH 07/22] arm64: dts: qcom: pm8150: Add pon and rtc nodes Vinod Koul
2019-08-14 17:03   ` Stephen Boyd
2019-08-19 17:32     ` Vinod Koul
2019-08-14 12:49 ` [PATCH 08/22] arm64: dts: qcom: pm8150: Add vadc node Vinod Koul
2019-08-14 17:05   ` Stephen Boyd
2019-08-14 12:49 ` [PATCH 09/22] arm64: dts: qcom: pm8150b: Add Base DTS file Vinod Koul
2019-08-14 17:05   ` Stephen Boyd
2019-08-14 12:50 ` [PATCH 10/22] arm64: dts: qcom: pm8150b: Add pon and adc nodes Vinod Koul
2019-08-14 17:08   ` Stephen Boyd
2019-08-19 17:43     ` Vinod Koul
2019-08-19 17:56       ` Stephen Boyd
2019-08-20  3:46         ` Vinod Koul
2019-08-14 18:00   ` Bjorn Andersson [this message]
2019-08-14 12:50 ` [PATCH 11/22] arm64: dts: qcom: pm8150b: Add gpio node Vinod Koul
2019-08-14 17:08   ` Stephen Boyd
2019-08-14 12:50 ` [PATCH 12/22] arm64: dts: qcom: pm8150l: Add Base DTS file Vinod Koul
2019-08-14 17:10   ` Stephen Boyd
2019-08-14 12:50 ` [PATCH 13/22] arm64: dts: qcom: pm8150l: Add pon and adc nodes Vinod Koul
2019-08-14 17:10   ` Stephen Boyd
2019-08-14 12:50 ` [PATCH 14/22] arm64: dts: qcom: pm8150l: Add gpio node Vinod Koul
2019-08-14 12:50 ` [PATCH 15/22] arm64: dts: qcom: sm8150-mtp: Include pmics Vinod Koul
2019-08-14 12:50 ` [PATCH 16/22] arm64: dts: qcom: sm8150-mtp: Add resin node Vinod Koul
2019-08-14 12:50 ` [PATCH 17/22] arm64: dts: qcom: sm8150: Add apss_shared and apps_rsc nodes Vinod Koul
2019-08-14 17:12   ` Stephen Boyd
2019-08-19 17:35     ` Vinod Koul
2019-08-14 12:50 ` [PATCH 18/22] arm64: dts: qcom: sm8150: Add reserved-memory regions Vinod Koul
2019-08-14 17:13   ` Stephen Boyd
2019-08-19 17:36     ` Vinod Koul
2019-08-14 12:50 ` [PATCH 19/22] arm64: dts: qcom: sm8150-mtp: Add regulators Vinod Koul
2019-08-14 12:50 ` [PATCH 20/22] arm64: dts: qcom: sm8150: Add pmu node to SM8150 SoC Vinod Koul
2019-08-14 17:15   ` Stephen Boyd
2019-08-14 12:50 ` [PATCH 21/22] arm64: dts: qcom: sm8150: Add SMEM nodes Vinod Koul
2019-08-14 17:16   ` Stephen Boyd
2019-08-14 12:50 ` [PATCH 22/22] arm64: dts: qcom: sm8150: Add APSS shared mailbox Vinod Koul
2019-08-14 17:17   ` Stephen Boyd
2019-08-19 17:41     ` Vinod Koul
2019-08-20  6:20       ` Sibi Sankar
2019-08-20  6:37         ` Vinod Koul

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190814180047.GH6167@minitux \
    --to=bjorn.andersson@linaro.org \
    --cc=agross@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=sibis@codeaurora.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-ARM-MSM Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-arm-msm/0 linux-arm-msm/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-arm-msm linux-arm-msm/ https://lore.kernel.org/linux-arm-msm \
		linux-arm-msm@vger.kernel.org linux-arm-msm@archiver.kernel.org
	public-inbox-index linux-arm-msm

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-arm-msm


AGPL code for this site: git clone https://public-inbox.org/ public-inbox