From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7532FC3A589 for ; Thu, 15 Aug 2019 22:51:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3A7D12086C for ; Thu, 15 Aug 2019 22:51:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=onstation.org header.i=@onstation.org header.b="kbBRmB2A" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733242AbfHOWvI (ORCPT ); Thu, 15 Aug 2019 18:51:08 -0400 Received: from onstation.org ([52.200.56.107]:49700 "EHLO onstation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730406AbfHOWvH (ORCPT ); Thu, 15 Aug 2019 18:51:07 -0400 Received: from localhost (c-98-239-145-235.hsd1.wv.comcast.net [98.239.145.235]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: masneyb) by onstation.org (Postfix) with ESMTPSA id D89F23E998; Thu, 15 Aug 2019 22:51:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=onstation.org; s=default; t=1565909466; bh=GlErRnlbnhtp3xOCD8QDuEBNzdpIzm/CEjl/t+YePi4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kbBRmB2Ag3E2vXFKqyIe3P3JBKnDCf2Gw4yfO4jcxecQTEdBlDWG3wDJ+vxPQ+XQN a1BNwFsIm8w50ApVariWEfK20tN4ggz3LwN3Ya5I93TAxtpu1h1nThdsONxNN6uX7o QkSapavjafeT34+PmnZN/YYXcO0hocqwBz5MLwfA= Date: Thu, 15 Aug 2019 18:51:04 -0400 From: Brian Masney To: Linus Walleij Cc: Bjorn Andersson , Rob Herring , Andy Gross , Andrzej Hajda , Neil Armstrong , Rob Clark , Sean Paul , Dave Airlie , Daniel Vetter , Mark Rutland , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Enric Balletbo i Serra , "open list:DRM PANEL DRIVERS" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "linux-kernel@vger.kernel.org" , MSM , Linux ARM , freedreno Subject: Re: [PATCH RFC 06/11] drm/bridge: analogix-anx78xx: add support for avdd33 regulator Message-ID: <20190815225104.GB32072@onstation.org> References: <20190815004854.19860-1-masneyb@onstation.org> <20190815004854.19860-7-masneyb@onstation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Thu, Aug 15, 2019 at 10:22:45AM +0200, Linus Walleij wrote: > On Thu, Aug 15, 2019 at 2:49 AM Brian Masney wrote: > > > Add support for the avdd33 regulator to the analogix-anx78xx driver. > > Note that the regulator is currently enabled during driver probe and > > disabled when the driver is removed. This is currently how the > > downstream MSM kernel sources do this. > > > > Let's not merge this upstream for the mean time until I get the external > > display fully working on the Nexus 5 and then I can submit proper > > support then that powers down this regulator in the power off function. > > > > Signed-off-by: Brian Masney > > > +static void anx78xx_disable_regulator_action(void *_data) > > +{ > > + struct anx78xx_platform_data *pdata = _data; > > + > > + regulator_disable(pdata->avdd33); > > +} > (...) > > + err = devm_add_action(dev, anx78xx_disable_regulator_action, > > + pdata); > > Clever idea. Good for initial support, probably later on it would > need to be reworked using runtime PM so it's not constantly > powered up. Yes, that's my plan. I suspect that I may have a regulator disabled somewhere so I was planning to leave this on all the time for the time being to match the downstream behavior until I get the hot plug detect GPIO working. > Reviewed-by: Linus Walleij Thanks, Brian