From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81BEBC3A589 for ; Tue, 20 Aug 2019 12:35:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5301522DD3 for ; Tue, 20 Aug 2019 12:35:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566304556; bh=nJ0mcbMfylwac8G88uFjWYi2IIkTy/0t3muFG+48Pwo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=OoT54oky3QecQS3huP29Wiyt63/3q9JTzzf4sD1cXA8cUiFybIGnxwLCf7hKwwYdp fPmTuzhgyTq+TCraCe+eojnRq4wxQl3r094kRcAqMyJ/hKq+tp7ckGThxJrWrRTvcE 6sUGmcAajCA6AXc5pIoRiUlmWKVHy6ejTY72/Q1w= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728777AbfHTMfz (ORCPT ); Tue, 20 Aug 2019 08:35:55 -0400 Received: from mail.kernel.org ([198.145.29.99]:38096 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727006AbfHTMfz (ORCPT ); Tue, 20 Aug 2019 08:35:55 -0400 Received: from localhost (unknown [106.201.62.126]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 51B3222DA7; Tue, 20 Aug 2019 12:35:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566304555; bh=nJ0mcbMfylwac8G88uFjWYi2IIkTy/0t3muFG+48Pwo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=eo5zTxquyKft1fh7Dl1i0gfO749DVg6E05GBvwPBx6Bhjs434sfYJN+6g5kMyzihI ioENbddmBvHJKd7HzIIUPkSg6TFJkg8Yi/9yPOMlCSqok+HisyEC5R4QzOOiDRv78f T6igoogdaQtVfX0wn7HN7TMbfPtP/qdu6bmFnAFk= Date: Tue, 20 Aug 2019 18:04:43 +0530 From: Vinod Koul To: Niklas Cassel Cc: Andy Gross , linux-arm-msm@vger.kernel.org, Bjorn Andersson , Rob Herring , Mark Rutland , Stephen Boyd , Sibi Sankar , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/8] arm64: dts: qcom: pm8150: Add Base DTS file Message-ID: <20190820123443.GA12733@vkoul-mobl.Dlink> References: <20190820064216.8629-1-vkoul@kernel.org> <20190820064216.8629-3-vkoul@kernel.org> <20190820122719.GD31261@centauri> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190820122719.GD31261@centauri> User-Agent: Mutt/1.11.3 (2019-02-01) Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 20-08-19, 14:27, Niklas Cassel wrote: > On Tue, Aug 20, 2019 at 12:12:10PM +0530, Vinod Koul wrote: > > Add base DTS file for pm8150 along with GPIOs, power-on, rtc and vadc > > nodes > > > > Signed-off-by: Vinod Koul > > --- > > arch/arm64/boot/dts/qcom/pm8150.dtsi | 95 ++++++++++++++++++++++++++++ > > 1 file changed, 95 insertions(+) > > create mode 100644 arch/arm64/boot/dts/qcom/pm8150.dtsi > > > > diff --git a/arch/arm64/boot/dts/qcom/pm8150.dtsi b/arch/arm64/boot/dts/qcom/pm8150.dtsi > > new file mode 100644 > > index 000000000000..4a678be46d37 > > --- /dev/null > > +++ b/arch/arm64/boot/dts/qcom/pm8150.dtsi > > @@ -0,0 +1,95 @@ > > +// SPDX-License-Identifier: BSD-3-Clause > > +// Copyright (c) 2017-2019, The Linux Foundation. All rights reserved. > > +// Copyright (c) 2019, Linaro Limited > > + > > +#include > > +#include > > +#include > > +#include > > + > > +&spmi_bus { > > + pm8150_0: pmic@0 { > > + compatible = "qcom,pm8150", "qcom,spmi-pmic"; > > + reg = <0x0 SPMI_USID>; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + pon: power-on@800 { > > + compatible = "qcom,pm8916-pon"; > > + reg = <0x0800>; > > + pwrkey { > > + compatible = "qcom,pm8941-pwrkey"; > > + interrupts = <0x0 0x8 0 IRQ_TYPE_EDGE_BOTH>; > > Here you use 0 for 3rd cell > > > + debounce = <15625>; > > + bias-pull-up; > > + linux,code = ; > > + > > + status = "disabled"; > > + }; > > + }; > > + > > + pm8150_adc: adc@3100 { > > + compatible = "qcom,spmi-adc5"; > > + reg = <0x3100>; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + #io-channel-cells = <1>; > > + interrupts = <0x0 0x31 0x0 IRQ_TYPE_EDGE_RISING>; > > Here you use 0x0 for 3rd cell, be consistent. Will make it either at this and other places, thanks for pointing! -- ~Vinod