From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FA1AC3A5A2 for ; Thu, 22 Aug 2019 10:27:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 355DC2341E for ; Thu, 22 Aug 2019 10:27:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="bpk27jgM" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729552AbfHVK12 (ORCPT ); Thu, 22 Aug 2019 06:27:28 -0400 Received: from mail-lj1-f194.google.com ([209.85.208.194]:44803 "EHLO mail-lj1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727685AbfHVK12 (ORCPT ); Thu, 22 Aug 2019 06:27:28 -0400 Received: by mail-lj1-f194.google.com with SMTP id e24so5022788ljg.11 for ; Thu, 22 Aug 2019 03:27:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=1sY/jJYsZ/Y8HplWdr+MRRPypzy+MY6MFI9cf4FZtZo=; b=bpk27jgMbEtZBVqG1CXQ3WQkCcbGFhVLCR/qFQYW8++ezehtCiq2LgQ0huJWT56wHd AcbSluVFZbuyT9vH9RCYjyLVGIODsmeBmIZ8NsIXc9Rc5iiU6gjxfOuBA9nuTDfyRjdb 55Phb2VI/m2KPNeD8bHWmHOy9aKKXBrP12BGnWg6wtYAWO6X1hiatoJzwTmryhSL9tPe RgLYYQcGe85mfC7ZFIZVeKApZNtHPEBfgaT1TAPMuuZFMzX6vzilt5SF9PWrR5d+M2u2 IiOaIYVErWqtyJlSwf2QPoi35OsnqsiJCZ/+U2aCswFflOsil8XiwVRLc9/K8AmU9Wi3 l+rQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=1sY/jJYsZ/Y8HplWdr+MRRPypzy+MY6MFI9cf4FZtZo=; b=sSk75t4eHNwLoQWw31fvMeM3BauqyGzWNC3uFmi5EdQNOizWPS4gHP0AWgipE5pHbO OBTmkXTg7ELnjskXOyLwkJNLbFgOeUzQkrYvLF6+0GPEZI8bFQv56W0ldrLCpiBZt8xK XDK6RwfICAuI7mfuYQ9eLwAOZ68DckyghkTrRCQj0bF5H+G9xwWoRQCPpGpLDDDriWiF z4Zth/ciyeSnBPtOdb0nm9VM1UfS23/CPKxRkrzeEVltjNYBJ65n7r86jOl0ZLOtOsDj 55Xoe0wLrChgw13aRl8BN5rEvoFpbJvQX38AgVUiGzzecnmKAehrwSy7EUBce+7AiVVW wAeg== X-Gm-Message-State: APjAAAWz8hLElhL2A7AMq5XC/nGgTsZ6ZDX1Q6TwhlDAaU4gqhQ0z+5/ NfvZoWGX5Zy0pTN6xx58VvgVAQ== X-Google-Smtp-Source: APXvYqw9ELcfWAaOIRUHdmTqNqxavdwdByFmys1TchCBhziZhIJ8bAJRlc9uHWY43bt1oOR0dlb94g== X-Received: by 2002:a2e:a202:: with SMTP id h2mr21448448ljm.146.1566469645923; Thu, 22 Aug 2019 03:27:25 -0700 (PDT) Received: from centauri (ua-84-219-138-247.bbcust.telenor.se. [84.219.138.247]) by smtp.gmail.com with ESMTPSA id q30sm4371622lfd.27.2019.08.22.03.27.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Aug 2019 03:27:25 -0700 (PDT) Date: Thu, 22 Aug 2019 12:27:23 +0200 From: Niklas Cassel To: Stephen Boyd Cc: Andy Gross , Ilia Lin , Nishanth Menon , Viresh Kumar , linux-arm-msm@vger.kernel.org, jorge.ramirez-ortiz@linaro.org, bjorn.andersson@linaro.org, ulf.hansson@linaro.org, Rob Herring , Rob Herring , Mark Rutland , linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 06/14] dt-bindings: cpufreq: qcom-nvmem: Support pstates provided by a power domain Message-ID: <20190822102723.GB8494@centauri> References: <20190725104144.22924-7-niklas.cassel@linaro.org> <20190819100957.17095-1-niklas.cassel@linaro.org> <5d5ae389.1c69fb81.cb730.3225@mx.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5d5ae389.1c69fb81.cb730.3225@mx.google.com> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Mon, Aug 19, 2019 at 10:59:36AM -0700, Stephen Boyd wrote: > Quoting Niklas Cassel (2019-08-19 03:09:57) > > + > > +soc { > > +.... > > + cprpd: cpr@b018000 { > > Maybe node name should be 'avs' for the industry standard adaptive > voltage scaling acronym? I see where this is coming from, but "git grep avs" gives a single result. Also, since the label is cprpd, it doesn't make sense to simply rename the node name, and I don't think that avspd would be a good name, since it is less correct. So if you don't insist, I would prefer to leave it as it is. > > > > + compatible = "qcom,qcs404-cpr", "qcom,cpr"; > > + reg = <0x0b018000 0x1000>; > > + .... > > + vdd-apc-supply = <&pms405_s3>; > > + #power-domain-cells = <0>;