From: Vinod Koul <vkoul@kernel.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Stephen Boyd <sboyd@kernel.org>,
linux-arm-msm@vger.kernel.org, Andy Gross <agross@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 4/4] clk: qcom: clk-rpmh: Add support for SM8150
Date: Thu, 22 Aug 2019 19:31:34 +0530 [thread overview]
Message-ID: <20190822140134.GQ12733@vkoul-mobl.Dlink> (raw)
In-Reply-To: <20190820050944.GL26807@tuxbook-pro>
On 19-08-19, 22:09, Bjorn Andersson wrote:
> On Mon 19 Aug 00:39 PDT 2019, Vinod Koul wrote:
> > +static const struct clk_rpmh_desc clk_rpmh_sm8150 = {
> > + .clks = sm8150_rpmh_clocks,
> > + .num_clks = ARRAY_SIZE(sm8150_rpmh_clocks),
> > +};
>
> Maybe an empty line here?
Sounds better
>
> > static struct clk_hw *of_clk_rpmh_hw_get(struct of_phandle_args *clkspec,
> > void *data)
> > {
> > @@ -453,6 +479,7 @@ static int clk_rpmh_probe(struct platform_device *pdev)
> >
> > static const struct of_device_id clk_rpmh_match_table[] = {
> > { .compatible = "qcom,sdm845-rpmh-clk", .data = &clk_rpmh_sdm845},
> > + { .compatible = "qcom,sm8150-rpmh-clk", .data = &clk_rpmh_sm8150},
> > { }
> > };
> > MODULE_DEVICE_TABLE(of, clk_rpmh_match_table);
>
> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Thanks for the review, will send an update.
--
~Vinod
prev parent reply other threads:[~2019-08-22 14:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-19 7:39 [PATCH v2 0/4] clk: qcom: Add support for SM8150 Vinod Koul
2019-08-19 7:39 ` [PATCH v2 1/4] dt-bindings: clock: Document the parent clocks Vinod Koul
2019-08-20 5:06 ` Bjorn Andersson
2019-08-19 7:39 ` [PATCH v2 2/4] clk: qcom: clk-rpmh: Convert to parent data scheme Vinod Koul
2019-08-20 5:08 ` Bjorn Andersson
2019-08-22 13:59 ` Vinod Koul
2019-08-19 7:39 ` [PATCH v2 3/4] dt-bindings: clock: Document SM8150 rpmh-clock compatible Vinod Koul
2019-08-20 5:08 ` Bjorn Andersson
2019-08-19 7:39 ` [PATCH v2 4/4] clk: qcom: clk-rpmh: Add support for SM8150 Vinod Koul
2019-08-20 5:09 ` Bjorn Andersson
2019-08-22 14:01 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190822140134.GQ12733@vkoul-mobl.Dlink \
--to=vkoul@kernel.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).