From: Vinod Koul <vkoul@kernel.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Stephen Boyd <sboyd@kernel.org>,
linux-arm-msm@vger.kernel.org, Andy Gross <agross@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/4] clk: qcom: clk-rpmh: Convert to parent data scheme
Date: Mon, 26 Aug 2019 11:51:27 +0530 [thread overview]
Message-ID: <20190826062127.GH2672@vkoul-mobl> (raw)
In-Reply-To: <20190824063115.GW26807@tuxbook-pro>
On 23-08-19, 23:31, Bjorn Andersson wrote:
> On Thu 22 Aug 10:01 PDT 2019, Vinod Koul wrote:
>
> > Convert the rpmh clock driver to use the new parent data scheme by
> > specifying the parent data for board clock.
> >
> > Signed-off-by: Vinod Koul <vkoul@kernel.org>
> > ---
> > drivers/clk/qcom/clk-rpmh.c | 10 ++++++++--
> > 1 file changed, 8 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/clk/qcom/clk-rpmh.c b/drivers/clk/qcom/clk-rpmh.c
> > index c3fd632af119..0bced7326a20 100644
> > --- a/drivers/clk/qcom/clk-rpmh.c
> > +++ b/drivers/clk/qcom/clk-rpmh.c
> > @@ -95,7 +95,10 @@ static DEFINE_MUTEX(rpmh_clk_lock);
> > .hw.init = &(struct clk_init_data){ \
> > .ops = &clk_rpmh_ops, \
> > .name = #_name, \
> > - .parent_names = (const char *[]){ "xo_board" }, \
> > + .parent_data = &(const struct clk_parent_data){ \
> > + .fw_name = "xo_board", \
> > + .name = "xo_board", \
>
> Iiuc .name here refers to the global clock namespace and .fw_name refers
> to the device_node local name space. As such I really prefer this to be:
>
> .fw_name = "xo",
> .name = "xo_board",
>
> This ensures the backwards compatibility (when using global lookup),
> without complicating the node-local naming.
Sure, while thinking more on this, should we finalize the name as xo or
cxo, I see latter being also used at few places. It would be great to
get a name and stick to it for longer time :)
--
~Vinod
next prev parent reply other threads:[~2019-08-26 6:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-22 17:01 [PATCH v3 0/4] clk: qcom: Add support for SM8150 Vinod Koul
2019-08-22 17:01 ` [PATCH v3 1/4] dt-bindings: clock: Document the parent clocks Vinod Koul
2019-08-22 17:01 ` [PATCH v3 2/4] clk: qcom: clk-rpmh: Convert to parent data scheme Vinod Koul
2019-08-24 6:31 ` Bjorn Andersson
2019-08-26 6:21 ` Vinod Koul [this message]
2019-09-09 11:26 ` Stephen Boyd
2019-08-22 17:01 ` [PATCH v3 3/4] dt-bindings: clock: Document SM8150 rpmh-clock compatible Vinod Koul
2019-08-22 17:01 ` [PATCH v3 4/4] clk: qcom: clk-rpmh: Add support for SM8150 Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190826062127.GH2672@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).