From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Stephen Boyd <swboyd@chromium.org>
Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-gpio@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
Andy Gross <agross@kernel.org>
Subject: Re: [PATCH] pinctrl: qcom: sdm845: Fix UFS_RESET pin
Date: Tue, 3 Sep 2019 21:10:42 -0700 [thread overview]
Message-ID: <20190904041042.GA3081@tuxbook-pro> (raw)
In-Reply-To: <20190830060227.12792-1-swboyd@chromium.org>
On Thu 29 Aug 23:02 PDT 2019, Stephen Boyd wrote:
> The UFS_RESET pin is the magical pin #150 now, not 153 per the
> sdm845_groups array declared in this file. Fix the order of pins so that
> UFS_RESET is 150 and the SDC pins follow after.
>
Woops, thanks
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> Fixes: 53a5372ce326 ("pinctrl: qcom: sdm845: Expose ufs_reset as gpio")
> Signed-off-by: Stephen Boyd <swboyd@chromium.org>
> ---
> drivers/pinctrl/qcom/pinctrl-sdm845.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/pinctrl/qcom/pinctrl-sdm845.c b/drivers/pinctrl/qcom/pinctrl-sdm845.c
> index 39f498c09906..ce495970459d 100644
> --- a/drivers/pinctrl/qcom/pinctrl-sdm845.c
> +++ b/drivers/pinctrl/qcom/pinctrl-sdm845.c
> @@ -262,10 +262,10 @@ static const struct pinctrl_pin_desc sdm845_pins[] = {
> PINCTRL_PIN(147, "GPIO_147"),
> PINCTRL_PIN(148, "GPIO_148"),
> PINCTRL_PIN(149, "GPIO_149"),
> - PINCTRL_PIN(150, "SDC2_CLK"),
> - PINCTRL_PIN(151, "SDC2_CMD"),
> - PINCTRL_PIN(152, "SDC2_DATA"),
> - PINCTRL_PIN(153, "UFS_RESET"),
> + PINCTRL_PIN(150, "UFS_RESET"),
> + PINCTRL_PIN(151, "SDC2_CLK"),
> + PINCTRL_PIN(152, "SDC2_CMD"),
> + PINCTRL_PIN(153, "SDC2_DATA"),
> };
>
> #define DECLARE_MSM_GPIO_PINS(pin) \
> --
> Sent by a computer through tubes
>
next prev parent reply other threads:[~2019-09-04 4:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-30 6:02 [PATCH] pinctrl: qcom: sdm845: Fix UFS_RESET pin Stephen Boyd
2019-09-04 4:10 ` Bjorn Andersson [this message]
2019-09-04 13:24 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190904041042.GA3081@tuxbook-pro \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).