From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C02BC3A5A8 for ; Wed, 4 Sep 2019 12:43:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 558D122CF5 for ; Wed, 4 Sep 2019 12:43:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730009AbfIDMnm convert rfc822-to-8bit (ORCPT ); Wed, 4 Sep 2019 08:43:42 -0400 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:41681 "EHLO relay7-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726528AbfIDMnl (ORCPT ); Wed, 4 Sep 2019 08:43:41 -0400 X-Originating-IP: 86.250.200.211 Received: from xps13 (lfbn-1-17395-211.w86-250.abo.wanadoo.fr [86.250.200.211]) (Authenticated sender: miquel.raynal@bootlin.com) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 1B4DA2000E; Wed, 4 Sep 2019 12:43:33 +0000 (UTC) Date: Wed, 4 Sep 2019 14:43:32 +0200 From: Miquel Raynal To: YueHaibing Cc: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH -next 01/15] thermal: armada: use devm_platform_ioremap_resource() to simplify code Message-ID: <20190904144332.46ab190f@xps13> In-Reply-To: <20190904122939.23780-2-yuehaibing@huawei.com> References: <20190904122939.23780-1-yuehaibing@huawei.com> <20190904122939.23780-2-yuehaibing@huawei.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi Yue, YueHaibing wrote on Wed, 4 Sep 2019 20:29:25 +0800: > Use devm_platform_ioremap_resource() to simplify the code a bit. > This is detected by coccinelle. > > Reported-by: Hulk Robot > Signed-off-by: YueHaibing > --- > drivers/thermal/armada_thermal.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/thermal/armada_thermal.c b/drivers/thermal/armada_thermal.c > index 709a22f..70fe9c6 100644 > --- a/drivers/thermal/armada_thermal.c > +++ b/drivers/thermal/armada_thermal.c > @@ -708,12 +708,10 @@ static int armada_thermal_probe_legacy(struct platform_device *pdev, > struct armada_thermal_priv *priv) > { > struct armada_thermal_data *data = priv->data; > - struct resource *res; > void __iomem *base; > > /* First memory region points towards the status register */ > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - base = devm_ioremap_resource(&pdev->dev, res); > + base = devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(base)) > return PTR_ERR(base); > Reviewed-by: Miquel Raynal Thanks, Miquèl