From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, UPPERCASE_50_75,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40DE1C43331 for ; Fri, 6 Sep 2019 04:19:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 208602081B for ; Fri, 6 Sep 2019 04:19:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567743578; bh=9wEomr15DqQQFhjsBZXapKuHKKB45PBaOQHhXs8HHp8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=dT3m+AGLRtKPqZfetzF3r9qulxp6wIt5xIrnKwiIrgkiIs5NThEbIEFhXM/kKz/eY B/VKqGE/S+BUCk9TSdyINwALWBQa3fgNqGMKq8AhNQCRvvtoNDL7SdiLzlq3DxFiz1 /ZIPyvWONtAEwMVa07ZK4IlvkKMgFT1VHLF746sw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726149AbfIFETg (ORCPT ); Fri, 6 Sep 2019 00:19:36 -0400 Received: from mail.kernel.org ([198.145.29.99]:48600 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725958AbfIFETg (ORCPT ); Fri, 6 Sep 2019 00:19:36 -0400 Received: from localhost (unknown [223.226.32.145]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6A473206CD; Fri, 6 Sep 2019 04:19:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567743575; bh=9wEomr15DqQQFhjsBZXapKuHKKB45PBaOQHhXs8HHp8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=m1WiMGmptBN2cyjUduyaacqO6M/p/cHX8x1ZtV+FkmhG8+yMNjTy7XbuRmojKpBgk 20yF9UStj0DwHs/HL/OH2iagYGmh6iq4YooP9WYcTwHo1DJSDF/bZt4qj1KAmX6LeO 028BuJAfK6mS5lGVPXXuUXSjNEjn/RYCMby7ACxA= Date: Fri, 6 Sep 2019 09:48:27 +0530 From: Vinod Koul To: Stephen Boyd Cc: Kishon Vijay Abraham I , linux-arm-msm@vger.kernel.org, Bjorn Andersson , Andy Gross , Rob Herring , Mark Rutland , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH 3/3] phy: qcom-qmp: Add SM8150 QMP UFS PHY support Message-ID: <20190906041827.GD2672@vkoul-mobl> References: <20190904100835.6099-1-vkoul@kernel.org> <20190904100835.6099-4-vkoul@kernel.org> <5d70475a.1c69fb81.650ed.0ad0@mx.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5d70475a.1c69fb81.650ed.0ad0@mx.google.com> User-Agent: Mutt/1.12.0 (2019-05-25) Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 04-09-19, 16:23, Stephen Boyd wrote: > Quoting Vinod Koul (2019-09-04 03:08:35) > > @@ -878,6 +883,93 @@ static const struct qmp_phy_init_tbl msm8998_usb3_pcs_tbl[] = { > > QMP_PHY_INIT_CFG(QPHY_V3_PCS_RXEQTRAINING_RUN_TIME, 0x13), > > }; > > > > +static const struct qmp_phy_init_tbl sm8150_ufsphy_serdes_tbl[] = { > > + QMP_PHY_INIT_CFG(QPHY_POWER_DOWN_CONTROL, 0x01), > > + QMP_PHY_INIT_CFG(QSERDES_COM_V4_SYSCLK_EN_SEL, 0xD9), > > Can you use lowercase hex? Sure will update > > + QMP_PHY_INIT_CFG(QSERDES_COM_V4_HSCLK_SEL, 0x11), > > + QMP_PHY_INIT_CFG(QSERDES_COM_V4_HSCLK_HS_SWITCH_SEL, 0x00), > > + QMP_PHY_INIT_CFG(QSERDES_COM_V4_LOCK_CMP_EN, 0x01), > > + QMP_PHY_INIT_CFG(QSERDES_COM_V4_VCO_TUNE_MAP, 0x02), > > + QMP_PHY_INIT_CFG(QSERDES_COM_V4_PLL_IVCO, 0x0F), > > + QMP_PHY_INIT_CFG(QSERDES_COM_V4_VCO_TUNE_INITVAL2, 0x00), > > + QMP_PHY_INIT_CFG(QSERDES_COM_V4_BIN_VCOCAL_HSCLK_SEL, 0x11), > > + QMP_PHY_INIT_CFG(QSERDES_COM_V4_DEC_START_MODE0, 0x82), > > + QMP_PHY_INIT_CFG(QSERDES_COM_V4_CP_CTRL_MODE0, 0x06), > > Gotta love the pile of numbers and register writes... :D -- ~Vinod