From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BEE7EC4CEC9 for ; Wed, 18 Sep 2019 06:34:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 92A40218AE for ; Wed, 18 Sep 2019 06:34:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="X0g3AnbC" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726835AbfIRGeK (ORCPT ); Wed, 18 Sep 2019 02:34:10 -0400 Received: from mail-pf1-f195.google.com ([209.85.210.195]:37301 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727536AbfIRGeH (ORCPT ); Wed, 18 Sep 2019 02:34:07 -0400 Received: by mail-pf1-f195.google.com with SMTP id y5so3690115pfo.4 for ; Tue, 17 Sep 2019 23:34:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=7hTH+QZ0Rg1J8IDO+1UiOPyFh3Jvo6QqRltmoWe2MW4=; b=X0g3AnbCKw+4TwyXRilD5SoauIs7wFaCMcwJKFXFr+zMxnDhMe2h8FvUT7Uilb0cyQ rOHGkNZRi46MCx5F3tyS4fy75friu9ruEtFpKh0Z2S6tWdUkZx4uLAeBKh4xjqoxzzut G81E4cQU5C8fHwDxi0SovdBNlntxF3QSRCx+VA6snwPzZXgabK/h0b2LIylAYFPIKd47 JWy1+Eyc3nQWc3YU6i5tTx4u3XuZVT0CYgFy7OpgYJpZi0MtU3J1bN49gsY96lzLHLk9 z5THRSdFErwm8GSn5Xt6MaUpUggMzlOHC/DVjWGjGE6c61eUSrIhwQ5edcmv5qO4QayY wi/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=7hTH+QZ0Rg1J8IDO+1UiOPyFh3Jvo6QqRltmoWe2MW4=; b=b0srFKljQV4qIKqX9KU22jny5NWiu84daBYxCNEExLIA//yH/bq33Bivx1c+nOkJKP +feF4lEJqQqBMGCy4TqQef7zKwhyS6EzAg88IoDbFcVZhAIn/OJ8e/kVuFH72aSD50sK 7DbLJKubtWDzK0pSzgGaVDExaNMx12r+vZluZDKv6s9/ReSDpNzWyhqLAbh3H2smfFXp iu6mz0sbXxgbRwJuOzPUPXQso5X/HKInzuk3tc+GQNxn9lmSuCFZEaCKmmda2XUdDUpX leKQVMKOLkhvVqjw1CVTReyLpIJVYdVfU4EQzdNKtmYmXRFc+AxA+UIuWMwB3rXulMTQ TxHw== X-Gm-Message-State: APjAAAVFGMn1wVxnnXO8/WPS1358LoIF9H9//xVRRuD3Tmwo9yF+NtF/ FRJNj8dbx1E6PV3uuQRgHjsD+Q== X-Google-Smtp-Source: APXvYqzAcu1KGj9IOpAdn6O/jLmmzMqwMmQyCiZJCCQ7WyfF5e2xkCOUO7dFfLtz2I7kRQrfl391pA== X-Received: by 2002:aa7:8dcf:: with SMTP id j15mr2449689pfr.5.1568788446445; Tue, 17 Sep 2019 23:34:06 -0700 (PDT) Received: from tuxbook-pro (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id y28sm7614921pfq.48.2019.09.17.23.34.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Sep 2019 23:34:05 -0700 (PDT) Date: Tue, 17 Sep 2019 23:34:03 -0700 From: Bjorn Andersson To: Jorge Ramirez-Ortiz Cc: gregkh@linuxfoundation.org, arnd@arndb.de, srinivas.kandagatla@linaro.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH 2/5] misc: fastrpc: fix memory leak from miscdev->name Message-ID: <20190918063403.GD1636@tuxbook-pro> References: <20190913152532.24484-1-jorge.ramirez-ortiz@linaro.org> <20190913152532.24484-3-jorge.ramirez-ortiz@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190913152532.24484-3-jorge.ramirez-ortiz@linaro.org> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Fri 13 Sep 08:25 PDT 2019, Jorge Ramirez-Ortiz wrote: > From: Srinivas Kandagatla > > Fix a memory leak in miscdev->name by using devm_variant > > Orignally reported by kmemleak: > [] kmemleak_alloc+0x50/0x84 > [] __kmalloc_track_caller+0xe8/0x168 > [] kvasprintf+0x78/0x100 > [] kasprintf+0x50/0x74 > [] fastrpc_rpmsg_probe+0xd8/0x20c > [] rpmsg_dev_probe+0xa8/0x148 > [] really_probe+0x208/0x248 > [] driver_probe_device+0x98/0xc0 > [] __device_attach_driver+0x9c/0xac > [] bus_for_each_drv+0x60/0x8c > [] __device_attach+0x8c/0x100 > [] device_initial_probe+0x20/0x28 > [] bus_probe_device+0x34/0x7c > [] device_add+0x420/0x498 > [] device_register+0x24/0x2c > Cc: stable@vger.kernel.org Fixes: f6f9279f2bf0 ("misc: fastrpc: Add Qualcomm fastrpc basic driver model") > Signed-off-by: Srinivas Kandagatla You should append your S-o-b here, as you forwarded the patch. Reviewed-by: Bjorn Andersson Regards, Bjorn > --- > drivers/misc/fastrpc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c > index 8903388993d3..bc03500bfe60 100644 > --- a/drivers/misc/fastrpc.c > +++ b/drivers/misc/fastrpc.c > @@ -1599,8 +1599,8 @@ static int fastrpc_rpmsg_probe(struct rpmsg_device *rpdev) > } > > data->miscdev.minor = MISC_DYNAMIC_MINOR; > - data->miscdev.name = kasprintf(GFP_KERNEL, "fastrpc-%s", > - domains[domain_id]); > + data->miscdev.name = devm_kasprintf(rdev, GFP_KERNEL, "fastrpc-%s", > + domains[domain_id]); > data->miscdev.fops = &fastrpc_fops; > err = misc_register(&data->miscdev); > if (err) > -- > 2.23.0 >