From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA0F1C47404 for ; Fri, 11 Oct 2019 17:05:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 923642054F for ; Fri, 11 Oct 2019 17:05:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="vi3AsMoB" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728503AbfJKRFL (ORCPT ); Fri, 11 Oct 2019 13:05:11 -0400 Received: from mail-pf1-f196.google.com ([209.85.210.196]:33946 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728472AbfJKRFK (ORCPT ); Fri, 11 Oct 2019 13:05:10 -0400 Received: by mail-pf1-f196.google.com with SMTP id b128so6465503pfa.1 for ; Fri, 11 Oct 2019 10:05:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=gH8CN6ifApnuUIuL6rRcDtc3+x1r+DnUSfP1BvRM+tU=; b=vi3AsMoBjn6t2StCoswScx6ITgLZ5Dgh/dkl10r9QPfaugvfwAw+Ks8xKYxym1++tD hvzb7DfDTq4FZZsRTjHm5lK07UpQR6ElOaQUNQh1vMdFAB9EJtAXJ5oRLCJ/gAyvebLp Y3GV0qJzrWd+xi/FPiAMnEJA2HE+WRUffyThCEm0vZX8MhhZCNZUfP4eUuHhX4RiUxMk UU42FAkEi+pbCIS8fIWqciAEA4L0F6B52OPRrzwBXuxRFdbC9yYQi87WND1dKMvBIaRH AhAc1Y3Z+JgaiNtoMDqv2EWxSrCg492dY9oa0cnWWSGU9eXqCgVgLip0sBwe9cQlgmfY tKbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=gH8CN6ifApnuUIuL6rRcDtc3+x1r+DnUSfP1BvRM+tU=; b=KCemnQpHCelzgJ3WxFgjYJChRfDzVDtf4fJYvRqcTUDM7sWL/RRMBnBIzJKHjkVSZo /4GCfXCowpdEMdL2eUNTKi1zKf9lrtIT/TEoLpdWjIOrtAsEVwahLAA6DmiVK8/j7qie uimEkWrGHBb2NoDoXzkb4HB16iSDMzDHru8Wn+G8D1tOh9V+c9n6oZFJrbaGrNnMaX9q yWN9U107St4cgp9bi1M6h/gJHDIvTNRY5cTc+NfKsEbRYAKsros8Jw6rusJGUPMzQC0o xMh0QRNL0q1WWI8fTfzuzRKW9gH2/GyA3+HZLX+uSyvZfFDTkWBGBlkqrX5X3EQ70EPQ X+gw== X-Gm-Message-State: APjAAAWEc2az6ELbr/6FBALa2ClRUVpqSlDpLeXckdXJqq0Uel9BpdbV yEQnGNQOZI0fbCpXdcW7iNVgdw== X-Google-Smtp-Source: APXvYqxCYyvcatZuXiUrQiYQSR8LloHnPBCD0DgKGggGvjPKWDeBhtnUDZ0YgxWXDlWKV/vjoimEdg== X-Received: by 2002:a62:2581:: with SMTP id l123mr17786124pfl.197.1570813509739; Fri, 11 Oct 2019 10:05:09 -0700 (PDT) Received: from minitux (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id 199sm10116069pfv.152.2019.10.11.10.05.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Oct 2019 10:05:08 -0700 (PDT) Date: Fri, 11 Oct 2019 10:05:06 -0700 From: Bjorn Andersson To: Brian Masney Cc: georgi.djakov@linaro.org, robh+dt@kernel.org, agross@kernel.org, mark.rutland@arm.com, linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, jonathan@marek.ca Subject: Re: [PATCH v2 2/2] interconnect: qcom: add msm8974 driver Message-ID: <20191011170506.GD571@minitux> References: <20191005114605.5279-1-masneyb@onstation.org> <20191005114605.5279-3-masneyb@onstation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191005114605.5279-3-masneyb@onstation.org> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Sat 05 Oct 04:46 PDT 2019, Brian Masney wrote: > diff --git a/drivers/interconnect/qcom/msm8974.c b/drivers/interconnect/qcom/msm8974.c [..] > +static void msm8974_icc_rpm_smd_send(struct device *dev, int rsc_type, > + char *name, int id, u64 val) > +{ > + int ret; > + > + if (id == -1) > + return; > + > + /* > + * Setting the bandwidth requests for some nodes fails and this same > + * behavior occurs on the downstream MSM 3.4 kernel sources based on > + * errors like this in that kernel: > + * > + * msm_rpm_get_error_from_ack(): RPM NACK Unsupported resource > + * AXI: msm_bus_rpm_req(): RPM: Ack failed > + * AXI: msm_bus_rpm_commit_arb(): RPM: Req fail: mas:32, bw:240000000 > + * > + * Since there's no publicly available documentation for this hardware, > + * and the bandwidth for some nodes in the path can be set properly, > + * let's not return an error. > + */ So presumably all that matters for paths including these endpoints is the clk_set_rate() on the bus itself. But I prefer that we merge it like you propose and then swing back to work out the details. > + ret = qcom_icc_rpm_smd_send(QCOM_SMD_RPM_ACTIVE_STATE, rsc_type, id, > + val); > + if (ret) > + dev_dbg(dev, "Cannot set bandwidth for node %s (%d): %d\n", > + name, id, ret); > +} > + Reviewed-by: Bjorn Andersson Regards, Bjorn