From: Stephan Gerhold <stephan@gerhold.net>
To: nikitos.tr@gmail.com
Cc: agross@kernel.org, bjorn.andersson@linaro.org,
robh+dt@kernel.org, mark.rutland@arm.com,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] arm64: dts: msm8916-longcheer-l8150: Add Volume buttons
Date: Sat, 12 Oct 2019 17:10:02 +0200 [thread overview]
Message-ID: <20191012151002.GB33229@gerhold.net> (raw)
In-Reply-To: <20191012145821.20846-2-nikitos.tr@gmail.com>
On Sat, Oct 12, 2019 at 07:58:21PM +0500, nikitos.tr@gmail.com wrote:
> From: Nikita Travkin <nikitos.tr@gmail.com>
>
> Add nodes for Volume UP button connected to GPIO and Volume DOWN button,
> which is handled by the pm8916 as is common with msm8916 devices.
>
> Signed-off-by: Nikita Travkin <nikitos.tr@gmail.com>
Reviewed-by: Stephan Gerhold <stephan@gerhold.net>
> ---
> .../boot/dts/qcom/msm8916-longcheer-l8150.dts | 41 +++++++++++++++++++
> 1 file changed, 41 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8916-longcheer-l8150.dts b/arch/arm64/boot/dts/qcom/msm8916-longcheer-l8150.dts
> index e4d467e7dedb..d1ccb9472c8b 100644
> --- a/arch/arm64/boot/dts/qcom/msm8916-longcheer-l8150.dts
> +++ b/arch/arm64/boot/dts/qcom/msm8916-longcheer-l8150.dts
> @@ -5,6 +5,7 @@
> #include "msm8916.dtsi"
> #include "pm8916.dtsi"
> #include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/input/input.h>
>
> / {
> model = "Longcheer L8150";
> @@ -113,9 +114,36 @@
> pinctrl-names = "default";
> pinctrl-0 = <&usb_vbus_default>;
> };
> +
> + gpio-keys {
> + compatible = "gpio-keys";
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&gpio_keys_default>;
> +
> + label = "GPIO Buttons";
> +
> + volume-up {
> + label = "Volume Up";
> + gpios = <&msmgpio 107 GPIO_ACTIVE_LOW>;
> + linux,code = <KEY_VOLUMEUP>;
> + };
> + };
> };
>
> &msmgpio {
> + gpio_keys_default: gpio_keys_default {
> + pinmux {
> + function = "gpio";
> + pins = "gpio107";
> + };
> + pinconf {
> + pins = "gpio107";
> + drive-strength = <2>;
> + bias-pull-up;
> + };
> + };
> +
> usb_vbus_default: usb-vbus-default {
> pinmux {
> function = "gpio";
> @@ -128,6 +156,19 @@
> };
> };
>
> +&spmi_bus {
> + pm8916@0 {
> + pon@800 {
> + volume-down {
> + compatible = "qcom,pm8941-resin";
> + interrupts = <0x0 0x8 1 IRQ_TYPE_EDGE_BOTH>;
> + bias-pull-up;
> + linux,code = <KEY_VOLUMEDOWN>;
> + };
> + };
> + };
> +};
> +
> &smd_rpm_regulators {
> vdd_l1_l2_l3-supply = <&pm8916_s3>;
> vdd_l4_l5_l6-supply = <&pm8916_s4>;
> --
> 2.19.1
>
next prev parent reply other threads:[~2019-10-12 15:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-12 14:58 [PATCH 1/2] arm64: dts: msm8916-longcheer-l8150: Enable WCNSS for WiFi and BT nikitos.tr
2019-10-12 14:58 ` [PATCH 2/2] arm64: dts: msm8916-longcheer-l8150: Add Volume buttons nikitos.tr
2019-10-12 15:10 ` Stephan Gerhold [this message]
2019-10-12 15:08 ` [PATCH 1/2] arm64: dts: msm8916-longcheer-l8150: Enable WCNSS for WiFi and BT Stephan Gerhold
2019-10-15 6:27 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191012151002.GB33229@gerhold.net \
--to=stephan@gerhold.net \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=nikitos.tr@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).