From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7487FA372C for ; Thu, 7 Nov 2019 09:13:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9882C2187F for ; Thu, 7 Nov 2019 09:13:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="bEULiHmO" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733139AbfKGJNn (ORCPT ); Thu, 7 Nov 2019 04:13:43 -0500 Received: from mail-lj1-f194.google.com ([209.85.208.194]:36328 "EHLO mail-lj1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733170AbfKGJNn (ORCPT ); Thu, 7 Nov 2019 04:13:43 -0500 Received: by mail-lj1-f194.google.com with SMTP id k15so1408380lja.3 for ; Thu, 07 Nov 2019 01:13:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=LPQPuxtLS0wBLc1/+9eubfNrLFMix+bCX6gszcE70UI=; b=bEULiHmOuf1HTGFS6AMXpNax+qNhL5eCmZTs+2IVLBW1UN9AReDNy88JQLc9RmoT0/ AglWvZ4JyemQBu4NXnKYeQYM0Zpqmhw5eGnh0Xo3seIxGnEm6eDyVgzRGAUZdEZ2QFe/ uC5D6iKkSoV2H4uvTbDoP2UaF9KHAdp5VncBV2UPBWUtH2dSO8rcM8jdWVJrf+Osd7uv 2RR9xCRjOW8Ou2jwK0LbMje29i+QlpbqBZVajPT85Ef8XV0smsMPNZg1l6cPoKbm23Lq DJE3HvfVQMWCG3A1r3ylgbF32kj5o/7QZCOdXbw3EMT/qJ1Y0cTHkJEVE96ToztyZT3b ht9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=LPQPuxtLS0wBLc1/+9eubfNrLFMix+bCX6gszcE70UI=; b=VOZu35jM6Bpunr6S57dko9H11RhBG6i5Tdrel6v8+SBUscgGdkZExkDj9H2epsIGk8 wVr6BsXsHllAWnHVw8dzl4zqc/actJenWmupr65mheUk53kqdxcJsa+hvTNHe8hAgsjL 2Fhx3MEwE3En37cEilZ6/8js1mQ+FyfG9P2uHII2nA5zOC4d/3wiBMWANdTV+6nfEz2K 1uT9awl9ZYt4IS9Q+YDlpihcs54y4ftz0wEIntbbLJ6RL1IPhGwULkTxA2zX2DhsfawX L9RCphvvezLCkT7vOzRXL6AjeWaqeDFG0aJ1zg5LlFttEouZDLsEHB/6nPX6tgHKKZ9K 8RiQ== X-Gm-Message-State: APjAAAU7GiuLlk8OTAPTDUpOQuBJlVFP3Jf1X9wI945cEOtTY7PoUwil xkEtOe88Tk/3Yj89KYOBzgXeqg== X-Google-Smtp-Source: APXvYqyCjFuNgyt3EBG/w74fgOl3eGm+zGJoqmESg11K2TzP1tc8+EvvcSZonnSAzeV2OuHFP/I7uA== X-Received: by 2002:a2e:2a43:: with SMTP id q64mr1607074ljq.242.1573118018614; Thu, 07 Nov 2019 01:13:38 -0800 (PST) Received: from centauri.lan (ua-84-217-220-205.bbcust.telenor.se. [84.217.220.205]) by smtp.gmail.com with ESMTPSA id i18sm840879lfc.82.2019.11.07.01.13.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Nov 2019 01:13:37 -0800 (PST) Date: Thu, 7 Nov 2019 10:13:35 +0100 From: Niklas Cassel To: Ulf Hansson Cc: "Rafael J . Wysocki" , Daniel Lezcano , Sudeep Holla , Lorenzo Pieralisi , Mark Rutland , Lina Iyer , linux-pm@vger.kernel.org, Rob Herring , Vincent Guittot , Stephen Boyd , Andy Gross , Bjorn Andersson , Kevin Hilman , linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH v2 08/13] cpuidle: psci: Add a helper to attach a CPU to its PM domain Message-ID: <20191107091335.GA1914942@centauri.lan> References: <20191029164438.17012-1-ulf.hansson@linaro.org> <20191029164438.17012-9-ulf.hansson@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191029164438.17012-9-ulf.hansson@linaro.org> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Tue, Oct 29, 2019 at 05:44:33PM +0100, Ulf Hansson wrote: > Introduce a PSCI DT helper function, psci_dt_attach_cpu(), which takes a > CPU number as an in-parameter and tries to attach the CPU's struct device > to its corresponding PM domain. > > Let's makes use of dev_pm_domain_attach_by_name(), as it allows us to > specify "psci" as the "name" of the PM domain to attach to. Additionally, > let's also prepare the attached device to be power managed via runtime PM. > > Note that, the implementation of the new helper function is in a new > separate c-file, which may seems a bit too much at this point. However, > subsequent changes that implements the remaining part of the PM domain > support for cpuidle-psci, helps to justify this split. > > Signed-off-by: Ulf Hansson > --- > > Changes in v2: > - Reorder patch to be the first one that starts adding the PM domain > support. > - Rebased. > > --- > drivers/cpuidle/Makefile | 4 ++- > drivers/cpuidle/cpuidle-psci-domain.c | 36 +++++++++++++++++++++++++++ > drivers/cpuidle/cpuidle-psci.h | 12 +++++++++ > 3 files changed, 51 insertions(+), 1 deletion(-) > create mode 100644 drivers/cpuidle/cpuidle-psci-domain.c > create mode 100644 drivers/cpuidle/cpuidle-psci.h > > diff --git a/drivers/cpuidle/Makefile b/drivers/cpuidle/Makefile > index ee70d5cc5b99..cc8c769d7fa9 100644 > --- a/drivers/cpuidle/Makefile > +++ b/drivers/cpuidle/Makefile > @@ -21,7 +21,9 @@ obj-$(CONFIG_ARM_U8500_CPUIDLE) += cpuidle-ux500.o > obj-$(CONFIG_ARM_AT91_CPUIDLE) += cpuidle-at91.o > obj-$(CONFIG_ARM_EXYNOS_CPUIDLE) += cpuidle-exynos.o > obj-$(CONFIG_ARM_CPUIDLE) += cpuidle-arm.o > -obj-$(CONFIG_ARM_PSCI_CPUIDLE) += cpuidle-psci.o > +obj-$(CONFIG_ARM_PSCI_CPUIDLE) += cpuidle_psci.o > +cpuidle_psci-y := cpuidle-psci.o > +cpuidle_psci-$(CONFIG_PM_GENERIC_DOMAINS_OF) += cpuidle-psci-domain.o > > ############################################################################### > # MIPS drivers > diff --git a/drivers/cpuidle/cpuidle-psci-domain.c b/drivers/cpuidle/cpuidle-psci-domain.c > new file mode 100644 > index 000000000000..bc7df4dc0686 > --- /dev/null > +++ b/drivers/cpuidle/cpuidle-psci-domain.c > @@ -0,0 +1,36 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * PM domains for CPUs via genpd - managed by cpuidle-psci. > + * > + * Copyright (C) 2019 Linaro Ltd. > + * Author: Ulf Hansson > + * > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > + > +#include "cpuidle-psci.h" > + > +struct device *psci_dt_attach_cpu(int cpu) > +{ > + struct device *dev; > + > + /* Currently limit the hierarchical topology to be used in OSI mode. */ > + if (!psci_has_osi_support()) > + return NULL; > + > + dev = dev_pm_domain_attach_by_name(get_cpu_device(cpu), "psci"); Hello Ulf, here you use dev_pm_domain_attach_by_name(), which will call genpd_dev_pm_attach_by_name(), which will call genpd_dev_pm_attach_by_id(), which will call __genpd_dev_pm_attach(virt_dev, dev, index, false); the last argument is power_on, which here is always set to false. In older versions of your patch series, psci_dt_attach_cpu() called dev_pm_domain_attach(dev, true), where the last argument is power_on. Interestingly enough (for the non-ACPI case), dev_pm_domain_attach() ignores the power_on parameter, and simply calls genpd_dev_pm_attach(dev); which will call __genpd_dev_pm_attach(dev, dev, 0, true); the last argument is power_on, which here is always set to true. In other words, your previous patch series always powered on the power domain, while the newer versions do not. Is this change intentional? Perhaps psci_dt_attach_cpu() should call dev_to_genpd(dev)->power_on() after attaching the power domain? (In order to be consistent with the previous behavior of this patch series.) Kind regards, Niklas > + if (IS_ERR_OR_NULL(dev)) > + return dev; > + > + pm_runtime_irq_safe(dev); > + if (cpu_online(cpu)) > + pm_runtime_get_sync(dev); > + > + return dev; > +} > diff --git a/drivers/cpuidle/cpuidle-psci.h b/drivers/cpuidle/cpuidle-psci.h > new file mode 100644 > index 000000000000..0cadbb71dc55 > --- /dev/null > +++ b/drivers/cpuidle/cpuidle-psci.h > @@ -0,0 +1,12 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > + > +#ifndef __CPUIDLE_PSCI_H > +#define __CPUIDLE_PSCI_H > + > +#ifdef CONFIG_PM_GENERIC_DOMAINS_OF > +struct device *psci_dt_attach_cpu(int cpu); > +#else > +static inline struct device *psci_dt_attach_cpu(int cpu) { return NULL; } > +#endif > + > +#endif /* __CPUIDLE_PSCI_H */ > -- > 2.17.1 >