From: Daniel Vetter <daniel@ffwll.ch>
To: Steve Cohen <cohens@codeaurora.org>
Cc: dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org,
linux-arm-msm@vger.kernel.org, adelva@google.com,
pdhaval@codeaurora.org, seanpaul@chromium.org
Subject: Re: [PATCH 0/3] allow DRM drivers to limit creation of blobs
Date: Fri, 8 Nov 2019 09:34:48 +0100 [thread overview]
Message-ID: <20191108083448.GU23790@phenom.ffwll.local> (raw)
In-Reply-To: <1573155554-16248-1-git-send-email-cohens@codeaurora.org>
On Thu, Nov 07, 2019 at 02:39:11PM -0500, Steve Cohen wrote:
> Fuzzers used in Android compliance testing repeatedly call the
> create blob IOCTL which eventually exhausts the system memory.
> This series adds a hook which allows drivers to impose their own
> limitations on the size and/or number of blobs created.
Pretty sure this isn't just a problem for msm/dpu alone, why this very
limited approach?
Also, why are your fuzzers not also allocating enormous amounts of gem
buffers, which will also exhaust memory eventually?
-Daniel
>
> Steve Cohen (3):
> drm: add driver hook for create blob limitations
> drm/msm: add support for createblob_check driver hook
> drm/msm/dpu: check blob limitations during create blob ioctl
>
> drivers/gpu/drm/drm_property.c | 7 +++++++
> drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 14 ++++++++++++++
> drivers/gpu/drm/msm/msm_drv.c | 25 +++++++++++++++++++++++++
> drivers/gpu/drm/msm/msm_kms.h | 1 +
> include/drm/drm_drv.h | 9 +++++++++
> 5 files changed, 56 insertions(+)
>
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
next prev parent reply other threads:[~2019-11-08 8:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-07 19:39 [PATCH 0/3] allow DRM drivers to limit creation of blobs Steve Cohen
2019-11-07 19:39 ` [PATCH 1/3] drm: add driver hook for create blob limitations Steve Cohen
2019-11-07 19:39 ` [PATCH 2/3] drm/msm: add support for createblob_check driver hook Steve Cohen
2019-11-07 19:39 ` [PATCH 3/3] drm/msm/dpu: check blob limitations during create blob ioctl Steve Cohen
2019-11-08 8:34 ` Daniel Vetter [this message]
2019-11-09 0:01 ` [PATCH 0/3] allow DRM drivers to limit creation of blobs cohens
2019-11-10 20:57 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191108083448.GU23790@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=adelva@google.com \
--cc=cohens@codeaurora.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=pdhaval@codeaurora.org \
--cc=seanpaul@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).