From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Brian Masney <masneyb@onstation.org>
Cc: georgi.djakov@linaro.org, agross@kernel.org, robh+dt@kernel.org,
mark.rutland@arm.com, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/4] ARM: qcom_defconfig: add msm8974 interconnect support
Date: Fri, 8 Nov 2019 17:57:37 -0800 [thread overview]
Message-ID: <20191109015737.GB5592@tuxbook-pro> (raw)
In-Reply-To: <20191109004310.GA4494@onstation.org>
On Fri 08 Nov 16:43 PST 2019, Brian Masney wrote:
> On Thu, Oct 24, 2019 at 06:31:37AM -0400, Brian Masney wrote:
> > Add interconnect support for msm8974-based SoCs in order to support the
> > GPU on this platform.
> >
> > Signed-off-by: Brian Masney <masneyb@onstation.org>
> > ---
> > Changes since v1:
> > - Set CONFIG_INTERCONNECT=y since its now a bool instead of a tristate
> >
> > arch/arm/configs/qcom_defconfig | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/arch/arm/configs/qcom_defconfig b/arch/arm/configs/qcom_defconfig
> > index 9792dd0aae0c..cbe4e1d86f9a 100644
> > --- a/arch/arm/configs/qcom_defconfig
> > +++ b/arch/arm/configs/qcom_defconfig
> > @@ -252,6 +252,9 @@ CONFIG_PHY_QCOM_IPQ806X_SATA=y
> > CONFIG_PHY_QCOM_USB_HS=y
> > CONFIG_PHY_QCOM_USB_HSIC=y
> > CONFIG_QCOM_QFPROM=y
> > +CONFIG_INTERCONNECT=y
> > +CONFIG_INTERCONNECT_QCOM=y
> > +CONFIG_INTERCONNECT_QCOM_MSM8974=m
> > CONFIG_EXT2_FS=y
> > CONFIG_EXT2_FS_XATTR=y
> > CONFIG_EXT3_FS=y
>
> Georgi: Since Greg wants to allow compiling the interconnect support as
> a module [1], should I change CONFIG_INTERCONNECT to be a module? Or
> leave this as is? The GPU works fine with interconnect as a module on my
> phone. I know it's more for the cpufreq case.
>
This is the qcom_defconfig file, so it's fine to leave it =y. For the
multi-platform ones we should do the specific drivers =m, where
possible.
> [1] https://lore.kernel.org/lkml/20191107142111.GB109902@kroah.com/
>
Thanks for the pointer, I don't think this is a good idea and did reply.
> Andy/Bjorn: This series didn't get picked up for this upcoming merge
> window. If it's too late for this window (which is fine), then I'll
> hold off on resubmitting this until rc4 since I'll most likely have
> more device tree changes by then.
>
Sorry for missing it in the final preparation for v5.5.
I don't see anything among these patches that would require you to
repost the series, either we pick them up for another PR (although it's
rather late now) or we'll apply them as -rc1 lands (for v5.6).
Regards,
Bjorn
next prev parent reply other threads:[~2019-11-09 1:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-24 10:31 [PATCH v2 0/4] ARM: qcom: add defconfig items and dts nodes Brian Masney
2019-10-24 10:31 ` [PATCH v2 1/4] ARM: qcom_defconfig: add msm8974 interconnect support Brian Masney
2019-11-09 0:43 ` Brian Masney
2019-11-09 1:57 ` Bjorn Andersson [this message]
2019-10-24 10:31 ` [PATCH v2 2/4] ARM: qcom_defconfig: add anx78xx HDMI bridge support Brian Masney
2019-10-24 10:31 ` [PATCH v2 3/4] ARM: dts: qcom: msm8974: add ocmem node Brian Masney
2019-10-24 10:31 ` [PATCH v2 4/4] ARM: dts: qcom: msm8974: add interconnect nodes Brian Masney
2019-10-29 11:18 ` [PATCH v2 0/4] ARM: qcom: add defconfig items and dts nodes Georgi Djakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191109015737.GB5592@tuxbook-pro \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=georgi.djakov@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=masneyb@onstation.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).