Re: [PATCH 2/2] pinctrl: Use new GPIO_LINE_DIRECTION

From: kbuild test robot <lkp@intel.com>
To: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Cc: kbuild-all@lists.01.org, matti.vaittinen@fi.rohmeurope.com,
	mazziesaccount@gmail.com,
	Linus Walleij <linus.walleij@linaro.org>,
	Eric Anholt <eric@anholt.net>, Stefan Wahren <wahrenst@gmx.net>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Ray Jui <rjui@broadcom.com>,
	Scott Branden <sbranden@broadcom.com>,
	bcm-kernel-feedback-list@broadcom.com,
	Sean Wang <sean.wang@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>,
	Gregory Clement <gregory.clement@bootlin.com>,
	Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
	Ludovic Desroches <ludovic.desroches@microchip.com>,
	Nicolas Ferre <nicolas.ferre@microchip.com>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	Chen-Yu Tsai <wens@csie.org>,
	Paul Cercueil <paul@crapouillou.net>,
	Neil Armstrong <narmstrong@baylibre.com>,
	Heiko Stuebner <heiko@sntech.de>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Patrice Chotard <patrice.chotard@st.com>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Alexandre Torgue <alexandre.torgue@st.com>,
	Andy Gross <agross@kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	linux-gpio@vger.kernel.org, linux-rpi-kernel@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
	linux-oxnas@groups.io, linux-rockchip@lists.infradead.org,
	linux-renesas-soc@vger.kernel.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 2/2] pinctrl: Use new GPIO_LINE_DIRECTION
Date: Wed, 13 Nov 2019 14:30:05 +0800	[thread overview]
Message-ID: <201911131438.KT6pnFZ7%lkp@intel.com> (raw)
In-Reply-To: <20191112141819.GA22076@localhost.localdomain>

[-- Attachment #1: Type: text/plain, Size: 2022 bytes --]

Hi Matti,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on 70d97e099bb426ecb3ad4bf31e88dbf2ef4b2e4c]

url:    https://github.com/0day-ci/linux/commits/Matti-Vaittinen/pinctrl-rza1-remove-unnecerssary-static-inline-function/20191113-114104
base:    70d97e099bb426ecb3ad4bf31e88dbf2ef4b2e4c
config: arm-allmodconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 7.4.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.4.0 make.cross ARCH=arm 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   In file included from drivers/pinctrl/vt8500/pinctrl-wmt.c:9:0:
   drivers/pinctrl/vt8500/pinctrl-wmt.c: In function 'wmt_gpio_get_direction':
   include/linux/gpio/driver.h:26:33: warning: statement with no effect [-Wunused-value]
    #define GPIO_LINE_DIRECTION_OUT 0
                                    ^
>> drivers/pinctrl/vt8500/pinctrl-wmt.c:490:3: note: in expansion of macro 'GPIO_LINE_DIRECTION_OUT'
      GPIO_LINE_DIRECTION_OUT;
      ^~~~~~~~~~~~~~~~~~~~~~~

vim +/GPIO_LINE_DIRECTION_OUT +490 drivers/pinctrl/vt8500/pinctrl-wmt.c

   479	
   480	static int wmt_gpio_get_direction(struct gpio_chip *chip, unsigned offset)
   481	{
   482		struct wmt_pinctrl_data *data = gpiochip_get_data(chip);
   483		u32 bank = WMT_BANK_FROM_PIN(offset);
   484		u32 bit = WMT_BIT_FROM_PIN(offset);
   485		u32 reg_dir = data->banks[bank].reg_dir;
   486		u32 val;
   487	
   488		val = readl_relaxed(data->base + reg_dir);
   489		if (val & BIT(bit))
 > 490			GPIO_LINE_DIRECTION_OUT;
   491	
   492		return GPIO_LINE_DIRECTION_IN;
   493	}
   494	

---
0-DAY kernel test infrastructure                 Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 71989 bytes --]