From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Vinod Koul <vkoul@kernel.org>
Cc: John Stultz <john.stultz@linaro.org>,
Mathias Nyman <mathias.nyman@intel.com>,
linux-arm-msm@vger.kernel.org,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
Christian Lamparter <chunkeey@googlemail.com>,
linux-usb@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Todd Kjos <tkjos@google.com>, Alistair Delva <adelva@google.com>
Subject: Re: [PATCH v5 0/4] usb: xhci: Add support for Renesas USB controllers
Date: Wed, 8 Jan 2020 07:24:36 +0100 [thread overview]
Message-ID: <20200108062436.GA2276347@kroah.com> (raw)
In-Reply-To: <20200108040707.GU2818@vkoul-mobl>
On Wed, Jan 08, 2020 at 09:37:07AM +0530, Vinod Koul wrote:
> Hi John,
>
> On 07-01-20, 11:51, John Stultz wrote:
> > On Wed, Nov 6, 2019 at 12:40 AM Vinod Koul <vkoul@kernel.org> wrote:
> > >
> > > This series add support for Renesas USB controllers uPD720201 and uPD720202.
> > > These require firmware to be loaded and in case devices have ROM those can
> > > also be programmed if empty. If ROM is programmed, it runs from ROM as well.
> > >
> > > This includes two patches from Christian which supported these controllers
> > > w/o ROM and later my patches for ROM support and multiple firmware versions.
> > >
> >
> > Hey Vinod!
> > In pushing this series to one of the Android trees for the db845c,
> > there was some concern raised that this series is adding a lot of
> > renesas specific logic to the more generic xhci-pci driver. There was
> > some question if instead that logic should be added to its own
> > file/module? Do you have any thoughts on this?
>
> TBH I have not thought about that and in previous post neither Greg or
> Mathias gave a feedback that this was not acceptable...
>
> We can think about splitting but apart from firmware load there is not
> much extra functionality that we need to add, the controller behaviour
> as a standard xhci-pci. So i am not sure if we gain much by splitting.
>
> > Also, It seems there hasn't been much feedback on this for a few
> > months now. Is there a newer version of the patchset I should sync
> > with? Do you have plans to resubmit soon?
>
> Well am still waiting for feedback :( I dont have any update on top of
> this, I can repost but I dont think that really serves a purpose.
>
> I would really like to hear from Greg if this series is acceptable and
> if not what would he like to see changed.
Greg is not the xhci maintainer :)
next prev parent reply other threads:[~2020-01-08 11:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-06 8:38 [PATCH v5 0/4] usb: xhci: Add support for Renesas USB controllers Vinod Koul
2019-11-06 8:38 ` [PATCH v5 1/4] usb: xhci: add firmware loader for uPD720201 and uPD720202 w/o ROM Vinod Koul
2019-11-06 8:38 ` [PATCH v5 2/4] usb: xhci: Add ROM loader for uPD720201 Vinod Koul
2019-11-06 8:38 ` [PATCH v5 3/4] usb: xhci: allow multiple firmware versions Vinod Koul
2019-11-06 8:38 ` [PATCH v5 4/4] usb: xhci: provide a debugfs hook for erasing rom Vinod Koul
2019-11-21 4:54 ` [PATCH v5 0/4] usb: xhci: Add support for Renesas USB controllers Vinod Koul
2019-11-26 15:59 ` Mathias Nyman
2019-12-06 4:21 ` Vinod Koul
2020-01-07 19:51 ` John Stultz
2020-01-08 4:07 ` Vinod Koul
2020-01-08 6:24 ` Greg Kroah-Hartman [this message]
2020-01-08 16:00 ` Mathias Nyman
2020-01-08 18:29 ` Greg Kroah-Hartman
2020-01-09 12:09 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200108062436.GA2276347@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=adelva@google.com \
--cc=bjorn.andersson@linaro.org \
--cc=chunkeey@googlemail.com \
--cc=john.stultz@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=tkjos@google.com \
--cc=vkoul@kernel.org \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).