From: Douglas Anderson <dianders@chromium.org>
To: Rob Herring <robh@kernel.org>, Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Stephen Boyd <sboyd@codeaurora.org>
Cc: Jeffrey Hugo <jhugo@codeaurora.org>,
Taniya Das <tdas@codeaurora.org>,
devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
harigovi@codeaurora.org, mka@chromium.org,
kalyan_t@codeaurora.org, Mark Rutland <mark.rutland@arm.com>,
linux-clk@vger.kernel.org, hoegsberg@chromium.org,
Douglas Anderson <dianders@chromium.org>,
Michael Turquette <mturquette@baylibre.com>,
linux-kernel@vger.kernel.org, Stephen Boyd <sboyd@kernel.org>,
Rob Herring <robh+dt@kernel.org>
Subject: [PATCH v2 00/10] clk: qcom: Fix parenting for dispcc/gpucc/videocc
Date: Fri, 24 Jan 2020 14:42:15 -0800 [thread overview]
Message-ID: <20200124224225.22547-1-dianders@chromium.org> (raw)
The aim of this series is to get the dispcc and gpucc in a workable
shape upstream for sc7180. I personally wasn't focusing on (and
didn't test) videocc but pulled it along for the ride.
Most of the work in this series deals with the fact that the parenting
info for these clock controllers was in a bad shape. It looks like it
was half transitioned from the old way of doing things (relying on
global names) to the new way of doing things (putting the linkage in
the device tree). This should fully transition us.
As part of this transition I update the sdm845.dtsi file to specify
the info as per the new way of doing things. Although I've now put
the linkage info in the sdm845.dtsi file, though, I haven't updated
the sdm845 clock drivers in Linux so they still work via the global
name matching. It's left as an exercise to the reader to update the
sdm845 clock drivers in Linux.
This series passes these things for me on linux-next:
ARCH=arm64 make dtbs_check \
DT_SCHEMA_FILES=Documentation/devicetree/bindings/clock/qcom,gpucc.yaml
ARCH=arm64 make dtbs_check \
DT_SCHEMA_FILES=Documentation/devicetree/bindings/clock/qcom,dispcc.yaml
ARCH=arm64 make dtbs_check \
DT_SCHEMA_FILES=Documentation/devicetree/bindings/clock/qcom,videocc.yaml
ARCH=arm64 make dt_binding_check \
DT_SCHEMA_FILES=Documentation/devicetree/bindings/clock/qcom,videocc.yaml
ARCH=arm64 make dt_binding_check \
DT_SCHEMA_FILES=Documentation/devicetree/bindings/clock/qcom,gpucc.yaml
ARCH=arm64 make dt_binding_check \
DT_SCHEMA_FILES=Documentation/devicetree/bindings/clock/qcom,dispcc.yaml
I have confirmed that (with extra patches) the display/gpu come up on
sc7180 and sdm845-cheza. You can find the top of my downstream tree at:
https://crrev.com/c/2017976/3
I have confirmed that sdm845-cheza display / GPU come up atop
next-20200124, which is what this series is posted against.
This series is marked as 'v2' because in it I have snarfed up Taniya's
dts patch adding the clock controller nodes to sc7180.dtsi and this is
"v2" of that patch. Everything else is brand new.
Changes in v2:
- Patch ("clk: qcom: rcg2: Don't crash...") new for v2.
- Patch ("dt-bindings: clock: Fix qcom,dispcc...") new for v2.
- Patch ("arm64: dts: qcom: sdm845: Add...dispcc") new for v2.
- Patch ("dt-bindings: clock: Fix qcom,gpucc...") new for v2.
- Patch ("clk: qcom: Fix sc7180 dispcc parent data") new for v2.
- Patch ("arm64: dts: qcom: sdm845: Add...gpucc") new for v2.
- Patch ("clk: qcom: Fix sc7180 gpucc parent data") new for v2.
- Patch ("dt-bindings: clock: Cleanup qcom,videocc") new for v2.
- Patch ("arm64: dts: qcom: sdm845: Add...videocc") new for v2.
- Added includes
- Changed various parent names to match bindings / driver
Douglas Anderson (9):
clk: qcom: rcg2: Don't crash if our parent can't be found; return an
error
dt-bindings: clock: Fix qcom,dispcc bindings for sdm845/sc7180
arm64: dts: qcom: sdm845: Add the missing clocks on the dispcc
dt-bindings: clock: Fix qcom,gpucc bindings for sdm845/sc7180/msm8998
clk: qcom: Fix sc7180 dispcc parent data
arm64: dts: qcom: sdm845: Add the missing clocks on the gpucc
clk: qcom: Fix sc7180 gpucc parent data
dt-bindings: clock: Cleanup qcom,videocc bindings for sdm845/sc7180
arm64: dts: qcom: sdm845: Add the missing clock on the videocc
Taniya Das (1):
arm64: dts: sc7180: Add clock controller nodes
.../bindings/clock/qcom,dispcc.yaml | 87 +++++++++++++++----
.../devicetree/bindings/clock/qcom,gpucc.yaml | 42 ++++++---
.../bindings/clock/qcom,videocc.yaml | 10 ++-
arch/arm64/boot/dts/qcom/sc7180.dtsi | 41 +++++++++
arch/arm64/boot/dts/qcom/sdm845.dtsi | 20 ++++-
drivers/clk/qcom/clk-rcg2.c | 3 +
drivers/clk/qcom/dispcc-sc7180.c | 63 +++++---------
drivers/clk/qcom/gpucc-sc7180.c | 11 ++-
8 files changed, 199 insertions(+), 78 deletions(-)
--
2.25.0.341.g760bfbb309-goog
next reply other threads:[~2020-01-24 22:43 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-24 22:42 Douglas Anderson [this message]
2020-01-24 22:42 ` [PATCH v2 01/10] clk: qcom: rcg2: Don't crash if our parent can't be found; return an error Douglas Anderson
2020-01-28 17:43 ` Matthias Kaehlcke
2020-01-24 22:42 ` [PATCH v2 02/10] dt-bindings: clock: Fix qcom,dispcc bindings for sdm845/sc7180 Douglas Anderson
2020-01-24 22:42 ` [PATCH v2 03/10] arm64: dts: qcom: sdm845: Add the missing clocks on the dispcc Douglas Anderson
2020-01-24 22:42 ` [PATCH v2 04/10] dt-bindings: clock: Fix qcom,gpucc bindings for sdm845/sc7180/msm8998 Douglas Anderson
2020-01-24 22:42 ` [PATCH v2 05/10] clk: qcom: Fix sc7180 dispcc parent data Douglas Anderson
2020-01-28 5:53 ` Taniya Das
2020-01-28 16:33 ` Doug Anderson
2020-01-29 0:51 ` Stephen Boyd
2020-01-30 21:19 ` Doug Anderson
2020-01-24 22:42 ` [PATCH v2 06/10] arm64: dts: qcom: sdm845: Add the missing clocks on the gpucc Douglas Anderson
2020-01-24 22:42 ` [PATCH v2 07/10] clk: qcom: Fix sc7180 gpucc parent data Douglas Anderson
2020-01-28 5:55 ` Taniya Das
2020-01-28 16:37 ` Doug Anderson
2020-01-24 22:42 ` [PATCH v2 08/10] dt-bindings: clock: Cleanup qcom,videocc bindings for sdm845/sc7180 Douglas Anderson
2020-01-24 22:42 ` [PATCH v2 09/10] arm64: dts: qcom: sdm845: Add the missing clock on the videocc Douglas Anderson
2020-01-24 22:42 ` [PATCH v2 10/10] arm64: dts: sc7180: Add clock controller nodes Douglas Anderson
2020-01-28 5:58 ` Taniya Das
2020-01-28 16:40 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200124224225.22547-1-dianders@chromium.org \
--to=dianders@chromium.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=harigovi@codeaurora.org \
--cc=hoegsberg@chromium.org \
--cc=jhugo@codeaurora.org \
--cc=kalyan_t@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mka@chromium.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=sboyd@codeaurora.org \
--cc=sboyd@kernel.org \
--cc=tdas@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).