From: Guenter Roeck <linux@roeck-us.net>
To: ansuelsmth@gmail.com
Cc: 'Andy Gross' <agross@kernel.org>,
'Bjorn Andersson' <bjorn.andersson@linaro.org>,
'Wim Van Sebroeck' <wim@linux-watchdog.org>,
'Rob Herring' <robh+dt@kernel.org>,
'Mark Rutland' <mark.rutland@arm.com>,
linux-arm-msm@vger.kernel.org, linux-watchdog@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: R: R: [PATCH 1/3] watchdog: qcom-wdt: add option to skip pretimeout
Date: Tue, 4 Feb 2020 09:37:18 -0800 [thread overview]
Message-ID: <20200204173718.GA10098@roeck-us.net> (raw)
In-Reply-To: <035f01d5db80$d2ed1fb0$78c75f10$@gmail.com>
On Tue, Feb 04, 2020 at 06:30:40PM +0100, ansuelsmth@gmail.com wrote:
> > On Tue, Feb 04, 2020 at 05:16:34PM +0100, ansuelsmth@gmail.com wrote:
> > > If something like this is used, msm-timer require interrupts. Without
> this
> > > configuration, the device is unbootable as the system froze on system
> > > bootup.
> > >
> > > timer@200a000 {
> > > compatible = "qcom,kpss-timer", "qcom,msm-timer";
> > > interrupts = <GIC_PPI 1 (GIC_CPU_MASK_SIMPLE(2) |
> > > IRQ_TYPE_EDGE_RISING)>,
> > > <GIC_PPI 2 (GIC_CPU_MASK_SIMPLE(2) |
> > > IRQ_TYPE_EDGE_RISING)>,
> > > <GIC_PPI 3 (GIC_CPU_MASK_SIMPLE(2) |
> > > IRQ_TYPE_EDGE_RISING)>,
> > > <GIC_PPI 4 (GIC_CPU_MASK_SIMPLE(2) |
> > > IRQ_TYPE_EDGE_RISING)>,
> > > <GIC_PPI 5 (GIC_CPU_MASK_SIMPLE(2) |
> > > IRQ_TYPE_EDGE_RISING)>;
> > > no-pretimeout;
> > > reg = <0x0200a000 0x100>;
> > > clock-frequency = <25000000>,
> > > <32768>;
> > > clocks = <&sleep_clk>;
> > > clock-names = "sleep";
> > > cpu-offset = <0x80000>;
> > > };
> > >
> >
> > I think this is all wrong; the new property shows up in a node which
> > is completely unrelated to a watchdog. Maybe it wasn't such a good idea
> > to tie the watchdog to the timer node. At the very least, the situation
> > should be handled in the driver via of_table flags. If the situation can't
> > be handled that way, something is even more wrong. In that case it might
> > be better to revert commit 36375491a439 until that is sorted out properly.
> >
> > Guenter
> >
>
> So pretimeout should be enabled only for kpss-wdt and disabled with a flag
> in the of_table of the driver?
>
Correct, if that is the determining factor.
Guenter
prev parent reply other threads:[~2020-02-04 17:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-04 15:21 [PATCH 1/3] watchdog: qcom-wdt: add option to skip pretimeout Ansuel Smith
2020-02-04 15:21 ` [PATCH 2/3] Documentation: watchdog: qcom-wdt: Remove deprecated compatible Ansuel Smith
2020-02-04 16:09 ` Guenter Roeck
2020-02-06 19:15 ` Rob Herring
2020-02-04 15:21 ` [PATCH 3/3] Documentation: watchdog: qcom-wdt: add new no-pretimeout option Ansuel Smith
2020-02-04 16:11 ` Guenter Roeck
2020-02-04 16:08 ` [PATCH 1/3] watchdog: qcom-wdt: add option to skip pretimeout Guenter Roeck
2020-02-04 16:16 ` R: " ansuelsmth
2020-02-04 16:25 ` Guenter Roeck
2020-02-04 17:30 ` R: " ansuelsmth
2020-02-04 17:37 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200204173718.GA10098@roeck-us.net \
--to=linux@roeck-us.net \
--cc=agross@kernel.org \
--cc=ansuelsmth@gmail.com \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).