From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0C78C35247 for ; Thu, 6 Feb 2020 19:24:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7EB6C21775 for ; Thu, 6 Feb 2020 19:24:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581017069; bh=Zp8OE5o5eZFyNVg5lP65tBnz3oUxVU4TkySEXhH+pTE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=kKzZHkjDVWWGN75cYEUM975GFdExU4HtnGiCu0e1IeVjKbrIG2KZ6pyAoy+8Ubpl4 M8PSg/uQ0f9lN5FHuLqWpZ32y1P3nYSN9hetvzRPHmI/OGAC6zTe28bvCP4tUp1rPf PEV7xE90zrtPH9RRrk3ODDL4XA1pKevRtOcXylts= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727830AbgBFTY3 (ORCPT ); Thu, 6 Feb 2020 14:24:29 -0500 Received: from mail.kernel.org ([198.145.29.99]:59550 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727738AbgBFTY2 (ORCPT ); Thu, 6 Feb 2020 14:24:28 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D211F20659; Thu, 6 Feb 2020 19:24:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581017068; bh=Zp8OE5o5eZFyNVg5lP65tBnz3oUxVU4TkySEXhH+pTE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WlsrsrxM4UbQ7/Enn10hE3kLLvWcRbBx/+RtGv3BdR7jlcQYnYbI8U670eWiHqqj8 0+806ZfPfRMVpUQgmCGEiUj2q9Uc4wiKyZEKgEWulr4Bblll52CeeU9Sh3Uqt6ZmQd CuC+xk7bf6G5+AQRXn9DdYe1FEzj51fMwgAsTDuM= Date: Thu, 6 Feb 2020 17:56:06 +0100 From: Greg KH To: Manivannan Sadhasivam Cc: arnd@arndb.de, smohanad@codeaurora.org, jhugo@codeaurora.org, kvalo@codeaurora.org, bjorn.andersson@linaro.org, hemantk@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 02/16] bus: mhi: core: Add support for registering MHI controllers Message-ID: <20200206165606.GA3894455@kroah.com> References: <20200131135009.31477-1-manivannan.sadhasivam@linaro.org> <20200131135009.31477-3-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200131135009.31477-3-manivannan.sadhasivam@linaro.org> Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Fri, Jan 31, 2020 at 07:19:55PM +0530, Manivannan Sadhasivam wrote: > +static void mhi_release_device(struct device *dev) > +{ > + struct mhi_device *mhi_dev = to_mhi_device(dev); > + > + if (mhi_dev->ul_chan) > + mhi_dev->ul_chan->mhi_dev = NULL; That looks really odd. Why didn't you just drop the reference you should have grabbed here for this pointer? You did properly increment it when you saved it, right? :) > + > + if (mhi_dev->dl_chan) > + mhi_dev->dl_chan->mhi_dev = NULL; Same here. thanks, greg k-h