From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D085C35242 for ; Tue, 11 Feb 2020 18:41:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2D03120842 for ; Tue, 11 Feb 2020 18:41:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="IAx8P+Ts" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730464AbgBKSli (ORCPT ); Tue, 11 Feb 2020 13:41:38 -0500 Received: from mail-pj1-f67.google.com ([209.85.216.67]:51654 "EHLO mail-pj1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728375AbgBKSli (ORCPT ); Tue, 11 Feb 2020 13:41:38 -0500 Received: by mail-pj1-f67.google.com with SMTP id fa20so1709506pjb.1 for ; Tue, 11 Feb 2020 10:41:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=xu7EuHlbPmEdsWxeqhcpcHFWwOAxYugDEE3/io8b6Ag=; b=IAx8P+TswPBtEzqo31P99hOqElFCCby5txh+Oscc2zELCGSh+V8oy9xOqlpkGbH7Ef UFy/In+m0b4c3AGRoJGmixJlOzszq2Anj2nYT4LB+CjyumYjiOR9OwKa5M5eVJ9yrCQj LsYE2AgdmmEVKL+ctWTreHKJiTPUspZyAsVoLnq2QY8iA6BJoabhj2etPGc+26+Xoe6H rBe3EuzUVbQp45qhLda9c913cu/r8Soi8GmTUZ114PwZD/pP2wONUEpfJh8PHRkdLViT HKNiH6pd0H7IQUZacCiMT5n8woKav6OgIXxSTJQ+VvypXnIouZyZPQeAplbzEnWV4EGm 0QAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=xu7EuHlbPmEdsWxeqhcpcHFWwOAxYugDEE3/io8b6Ag=; b=CklSM+6Ky97O4jDV/pcwFsuuANEnwgTrbomFfzc+YQYPMLuSqu2f7io5PFlTMbbksP 5H+00EXyt4yyRIgJzML7DP3rUdK5OoMMtLqA+xtEthvxBqX2gm7797H9O9+KjL2d38vj u+i0T/uqkxuKxFsXBF0ooWK5HnFD2BobjA473GtABaIFk5/B6MIOYLyxBj6smZ5CrWN0 dlRKTQyNMjsUBNt91+LwUDkTut/WzoCo6QK961IgsRmuKkQIS6XlpIDwXg08D8Lf7JYz Pkju0Todt6B8SxB8hvs1tIqE2XaOTkLWRH8glbOpuP6v8Ot3I1uGY4l13HygA0Z/HPC4 JhdA== X-Gm-Message-State: APjAAAUR1JWii8M+udQCYVjVv7IVz9PZgAsD2VOR1NzdCULYSA71RC8x QNvuY4lt7oVcvVS8ht/opsVj X-Google-Smtp-Source: APXvYqyCbupqRjFu0F6Wmci9gu6Qa/pIo2z9Yh3R6s5WBj8zjYf0kfRk0xoYd4RlP8k7jZYwU+Q/oA== X-Received: by 2002:a17:90a:a881:: with SMTP id h1mr5209231pjq.50.1581446497757; Tue, 11 Feb 2020 10:41:37 -0800 (PST) Received: from Mani-XPS-13-9360 ([2409:4072:638b:7653:754d:196d:c455:1f88]) by smtp.gmail.com with ESMTPSA id q66sm5543024pfq.27.2020.02.11.10.41.33 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 11 Feb 2020 10:41:37 -0800 (PST) Date: Wed, 12 Feb 2020 00:11:30 +0530 From: Manivannan Sadhasivam To: Greg KH Cc: arnd@arndb.de, smohanad@codeaurora.org, jhugo@codeaurora.org, kvalo@codeaurora.org, bjorn.andersson@linaro.org, hemantk@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 02/16] bus: mhi: core: Add support for registering MHI controllers Message-ID: <20200211184130.GA11908@Mani-XPS-13-9360> References: <20200131135009.31477-1-manivannan.sadhasivam@linaro.org> <20200131135009.31477-3-manivannan.sadhasivam@linaro.org> <20200206165755.GB3894455@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200206165755.GB3894455@kroah.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi Greg, On Thu, Feb 06, 2020 at 05:57:55PM +0100, Greg KH wrote: > On Fri, Jan 31, 2020 at 07:19:55PM +0530, Manivannan Sadhasivam wrote: > > --- /dev/null > > +++ b/drivers/bus/mhi/core/init.c > > @@ -0,0 +1,407 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +/* > > + * Copyright (c) 2018-2020, The Linux Foundation. All rights reserved. > > + * > > + */ > > + > > +#define dev_fmt(fmt) "MHI: " fmt > > This should not be needed, right? The bus/device name should give you > all you need here from what I can tell. So why is this needed? > The log will have only the device name as like PCI-E. But that won't specify where the error is coming from. Having "MHI" prefix helps the users to quickly identify that the error is coming from MHI stack. Thanks, Mani > thanks, > > greg k-h