Linux-ARM-MSM Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] soc: qcom: aoss: Use wake_up_all() instead of wake_up_interruptible_all()
@ 2020-01-22  8:23 Arun Kumar Neelakantam
  2020-02-12  6:31 ` Bjorn Andersson
  0 siblings, 1 reply; 2+ messages in thread
From: Arun Kumar Neelakantam @ 2020-01-22  8:23 UTC (permalink / raw)
  To: bjorn.andersson, clew
  Cc: Arun Kumar Neelakantam, Andy Gross, linux-arm-msm, linux-kernel

During the probe the task is waiting in TASK_UNINTERRUPTIBLE state which
cannot be woken-up by wake_up_interruptible_all() function.

Use wake_up_all() to wake-up both TASK_UNINTERRUPTIBLE and
TASK_INTERRUPTIBLE state tasks.

Signed-off-by: Arun Kumar Neelakantam <aneela@codeaurora.org>
---
 drivers/soc/qcom/qcom_aoss.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/soc/qcom/qcom_aoss.c b/drivers/soc/qcom/qcom_aoss.c
index 006ac40..fe79661 100644
--- a/drivers/soc/qcom/qcom_aoss.c
+++ b/drivers/soc/qcom/qcom_aoss.c
@@ -200,7 +200,7 @@ static irqreturn_t qmp_intr(int irq, void *data)
 {
 	struct qmp *qmp = data;
 
-	wake_up_interruptible_all(&qmp->event);
+	wake_up_all(&qmp->event);
 
 	return IRQ_HANDLED;
 }
-- 
1.9.1

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] soc: qcom: aoss: Use wake_up_all() instead of wake_up_interruptible_all()
  2020-01-22  8:23 [PATCH] soc: qcom: aoss: Use wake_up_all() instead of wake_up_interruptible_all() Arun Kumar Neelakantam
@ 2020-02-12  6:31 ` Bjorn Andersson
  0 siblings, 0 replies; 2+ messages in thread
From: Bjorn Andersson @ 2020-02-12  6:31 UTC (permalink / raw)
  To: Arun Kumar Neelakantam
  Cc: clew, Andy Gross, open list:ARM/QUALCOMM SUPPORT, open list

On Wed 22 Jan 00:23 PST 2020, Arun Kumar Neelakantam wrote:

> During the probe the task is waiting in TASK_UNINTERRUPTIBLE state which
> cannot be woken-up by wake_up_interruptible_all() function.
> 
> Use wake_up_all() to wake-up both TASK_UNINTERRUPTIBLE and
> TASK_INTERRUPTIBLE state tasks.
> 
> Signed-off-by: Arun Kumar Neelakantam <aneela@codeaurora.org>

Applied

Regards,
Bjorn

> ---
>  drivers/soc/qcom/qcom_aoss.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/soc/qcom/qcom_aoss.c b/drivers/soc/qcom/qcom_aoss.c
> index 006ac40..fe79661 100644
> --- a/drivers/soc/qcom/qcom_aoss.c
> +++ b/drivers/soc/qcom/qcom_aoss.c
> @@ -200,7 +200,7 @@ static irqreturn_t qmp_intr(int irq, void *data)
>  {
>  	struct qmp *qmp = data;
>  
> -	wake_up_interruptible_all(&qmp->event);
> +	wake_up_all(&qmp->event);
>  
>  	return IRQ_HANDLED;
>  }
> -- 
> 1.9.1

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-22  8:23 [PATCH] soc: qcom: aoss: Use wake_up_all() instead of wake_up_interruptible_all() Arun Kumar Neelakantam
2020-02-12  6:31 ` Bjorn Andersson

Linux-ARM-MSM Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-arm-msm/0 linux-arm-msm/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-arm-msm linux-arm-msm/ https://lore.kernel.org/linux-arm-msm \
		linux-arm-msm@vger.kernel.org
	public-inbox-index linux-arm-msm

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-arm-msm


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git