From: Vinod Koul <vkoul@kernel.org>
To: Stephen Boyd <sboyd@kernel.org>
Cc: agross@kernel.org, bjorn.andersson@linaro.org,
devicetree@vger.kernel.org, jshriram@codeaurora.org,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org, mark.rutland@arm.com,
mturquette@baylibre.com, psodagud@codeaurora.org,
robh+dt@kernel.org, tdas@codeaurora.org, tsoni@codeaurora.org,
vnkgutta@codeaurora.org
Subject: Re: [PATCH v2 7/7] arm64: dts: qcom: sm8250: Add sm8250 dts file
Date: Fri, 14 Feb 2020 18:44:29 +0530 [thread overview]
Message-ID: <20200214131429.GW2618@vkoul-mobl> (raw)
In-Reply-To: <20200205194750.464C020730@mail.kernel.org>
On 05-02-20, 11:47, Stephen Boyd wrote:
> > + CPU7: cpu@700 {
> > + device_type = "cpu";
> > + compatible = "qcom,kryo485";
> > + reg = <0x0 0x700>;
> > + enable-method = "psci";
> > + next-level-cache = <&L2_700>;
> > + L2_700: l2-cache {
> > + compatible = "cache";
> > + next-level-cache = <&L3_0>;
> > + };
> > + };
> > + };
> > +
> > + firmware: firmware {
>
> Does this need a label?
Nope, removed
> > + soc: soc@0 {
> > + #address-cells = <2>;
> > + #size-cells = <2>;
> > + ranges = <0 0 0 0 0x10 0>;
> > + dma-ranges = <0 0 0 0 0x10 0>;
> > + compatible = "simple-bus";
> > +
> > + gcc: clock-controller@100000 {
> > + compatible = "qcom,gcc-sm8250";
> > + reg = <0x0 0x00100000 0x0 0x1f0000>;
> > + #clock-cells = <1>;
> > + #reset-cells = <1>;
> > + #power-domain-cells = <1>;
> > + clock-names = "bi_tcxo",
> > + "sleep_clk";
>
> Weird tabbign here.
Fixed this and rest of them
> > + #interrupt-cells = <2>;
> > + interrupt-parent = <&intc>;
> > + interrupt-controller;
> > + };
> > +
> > + spmi_bus: qcom,spmi@c440000 {
>
> Node name should be 'spmi'.
Yup, changed
> > +
> > + rpmhcc: clock-controller {
> > + compatible = "qcom,sm8250-rpmh-clk";
> > + #clock-cells = <1>;
> > + clock-names = "xo";
> > + clocks = <&xo_board>;
> > + };
> > + };
> > +
> > + tcsr_mutex_regs: syscon@1f40000 {
> > + compatible = "syscon";
> > + reg = <0x0 0x01f40000 0x0 0x40000>;
> > + };
> > +
> > + timer@17c20000 {
>
> Doug fixed these in another thread to use offset. Run dt_bindings_check
> and see how it fails.
will do
>
> > + #address-cells = <2>;
> > + #size-cells = <2>;
> > + ranges;
> > + compatible = "arm,armv7-timer-mem";
> > + reg = <0x0 0x17c20000 0x0 0x1000>;
> > + clock-frequency = <19200000>;
>
> Remove this. Firmware should set it up properly.
Sure
--
~Vinod
next prev parent reply other threads:[~2020-02-14 13:14 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-24 22:32 [PATCH v2 0/7] Add device tree and clock drivers for SM8250 SoC Venkata Narendra Kumar Gutta
2020-01-24 22:32 ` [PATCH v2 1/7] dt-bindings: clock: Add RPMHCC bindings for SM8250 Venkata Narendra Kumar Gutta
2020-02-12 23:05 ` Stephen Boyd
2020-01-24 22:32 ` [PATCH v2 2/7] clk: qcom: rpmh: Add support for RPMH clocks on SM8250 Venkata Narendra Kumar Gutta
2020-02-12 23:05 ` Stephen Boyd
2020-01-24 22:32 ` [PATCH v2 3/7] clk: qcom: clk-alpha-pll: Refactor and cleanup trion PLL Venkata Narendra Kumar Gutta
2020-02-12 23:09 ` Stephen Boyd
2020-01-24 22:32 ` [PATCH v2 4/7] clk: qcom: clk-alpha-pll: Add support for controlling Lucid PLLs Venkata Narendra Kumar Gutta
2020-02-05 19:33 ` Stephen Boyd
2020-02-10 5:56 ` Vinod Koul
2020-01-24 22:32 ` [PATCH v2 5/7] dt-bindings: clock: Add SM8250 GCC clock bindings Venkata Narendra Kumar Gutta
2020-02-04 7:13 ` Stephen Boyd
2020-01-24 22:32 ` [PATCH v2 7/7] arm64: dts: qcom: sm8250: Add sm8250 dts file Venkata Narendra Kumar Gutta
2020-01-24 22:49 ` Bjorn Andersson
2020-02-05 19:47 ` Stephen Boyd
2020-02-14 13:14 ` Vinod Koul [this message]
[not found] ` <1579905147-12142-7-git-send-email-vnkgutta@codeaurora.org>
2020-02-05 19:40 ` [PATCH v2 6/7] clk: qcom: gcc: Add global clock controller driver for SM8250 Stephen Boyd
2020-02-14 13:09 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200214131429.GW2618@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jshriram@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mturquette@baylibre.com \
--cc=psodagud@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=tdas@codeaurora.org \
--cc=tsoni@codeaurora.org \
--cc=vnkgutta@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).