From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E914C34056 for ; Wed, 19 Feb 2020 18:09:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 21B7A24656 for ; Wed, 19 Feb 2020 18:09:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="gNqxcpBy" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726682AbgBSSJw (ORCPT ); Wed, 19 Feb 2020 13:09:52 -0500 Received: from mail-pf1-f195.google.com ([209.85.210.195]:41584 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726582AbgBSSJw (ORCPT ); Wed, 19 Feb 2020 13:09:52 -0500 Received: by mail-pf1-f195.google.com with SMTP id j9so447597pfa.8 for ; Wed, 19 Feb 2020 10:09:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=DT9b2JqUNcas1GieQOO1UADd6ZveitNnuHA65yQ4esE=; b=gNqxcpByNWRFu0kl0YvLf68XNvjty9vaYNkQyj4UDT0CK1Ig4GRS+PwQznc7FIMoK6 TgXzwabcsTBPFnXM77EN8+5Zku0ln7/W1A8zwCJHQiwcJA/d9ndPnODOU14PDRDcC6ai 7moER/4RsiWjejAX48uDiH3/nQWS4BpmwI9qA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=DT9b2JqUNcas1GieQOO1UADd6ZveitNnuHA65yQ4esE=; b=pNOgKKrqsy6bAQooqbZRMlBYBnNKFpyvuu/vQ/+sjd5Uv2u+hG4cFpx/6GdPzCMCDO KwhkrLIkb/EiVZ88qsbYUEEdm6aYbRX+X6IbmP4meJ9bsOASqHH5FWVcdLVr4hwvepfi q7bAhcVwy5ws4bSPD2mxSteuSyz2VGQpommBoyhDXjD/CzHdm8/ku2C4srpz9rh+ynZ6 yLCDWX8xfb3ujrtrWespOc2A/2m8OZfu+6iaJx9Z7OUHbq+rT+t7U0bgVaevQmzdZyTl OFPsqVs5ie7ZyFQknFUagvM/6refiHaiR43xDnYSR6OxyBih9sVtePX3g1DVH5roFbwC 885A== X-Gm-Message-State: APjAAAWkFoRdyej8QZC0+UtR76+myr/CUgxhrOTpAEF5Yo85etGyZ16D eHAoh/Y4aUydky9DvbFQV+NsOg== X-Google-Smtp-Source: APXvYqyBuOdfaFMKcgQz2InWVMXt9wu5jkvAcdKhlsUWQ2aZek1+MLFnc2VNa4KJ8eoMdzeMh4L0gg== X-Received: by 2002:aa7:96b6:: with SMTP id g22mr27963352pfk.206.1582135791976; Wed, 19 Feb 2020 10:09:51 -0800 (PST) Received: from localhost ([2620:15c:202:1:4fff:7a6b:a335:8fde]) by smtp.gmail.com with ESMTPSA id q21sm281382pff.105.2020.02.19.10.09.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Feb 2020 10:09:51 -0800 (PST) Date: Wed, 19 Feb 2020 10:09:50 -0800 From: Matthias Kaehlcke To: Akash Asthana Cc: gregkh@linuxfoundation.org, agross@kernel.org, bjorn.andersson@linaro.org, wsa@the-dreams.de, broonie@kernel.org, mark.rutland@arm.com, robh+dt@kernel.org, linux-i2c@vger.kernel.org, linux-spi@vger.kernel.org, devicetree@vger.kernel.org, swboyd@chromium.org, mgautam@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-serial@vger.kernel.org, dianders@chromium.org Subject: Re: [PATCH 4/6] spi: spi-geni-qcom: Add interconnect support Message-ID: <20200219180950.GA24720@google.com> References: <1581946205-27189-1-git-send-email-akashast@codeaurora.org> <1581946205-27189-5-git-send-email-akashast@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1581946205-27189-5-git-send-email-akashast@codeaurora.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Mon, Feb 17, 2020 at 07:00:03PM +0530, Akash Asthana wrote: > Get the interconnect paths for SPI based Serial Engine device > and vote according to the current bus speed of the driver. > > Signed-off-by: Akash Asthana > --- > drivers/spi/spi-geni-qcom.c | 65 ++++++++++++++++++++++++++++++++++++++++++--- > 1 file changed, 62 insertions(+), 3 deletions(-) > > diff --git a/drivers/spi/spi-geni-qcom.c b/drivers/spi/spi-geni-qcom.c > index c397242..a066ef26 100644 > --- a/drivers/spi/spi-geni-qcom.c > +++ b/drivers/spi/spi-geni-qcom.c > @@ -608,16 +653,25 @@ static int spi_geni_remove(struct platform_device *pdev) > spi_unregister_master(spi); > > free_irq(mas->irq, spi); > + geni_spi_icc_put(&mas->se); > pm_runtime_disable(&pdev->dev); > return 0; > } > > static int __maybe_unused spi_geni_runtime_suspend(struct device *dev) > { > + int ret; > struct spi_master *spi = dev_get_drvdata(dev); > struct spi_geni_master *mas = spi_master_get_devdata(spi); > > - return geni_se_resources_off(&mas->se); > + ret = geni_se_resources_off(&mas->se); > + if (ret) > + return ret; > + > + icc_set_bw(mas->se.icc_path[GENI_TO_CORE], 0, 0); This causes my SC7180 system to reset at boot time: [ 3.509652] qcom-qmp-phy 88e9000.phy-wrapper: Registered Qcom-QMP phy [ 3.516956] qcom-qusb2-phy 88e3000.phy: Registered Qcom-QUSB2 phy [ 3.524450] geni_se_qup 8c0000.geniqup: Adding to iommu group 4 [ 3.533896] spi_master spi0: will run message pump with realtime priority The system does not reset when passing 'Bps_to_icc(1000)' (=> 1) instead of 0.