From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BEC69C10DCE for ; Sat, 7 Mar 2020 00:00:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 977A9206E2 for ; Sat, 7 Mar 2020 00:00:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Ajyi7mY5" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727065AbgCGAAc (ORCPT ); Fri, 6 Mar 2020 19:00:32 -0500 Received: from mail-pg1-f193.google.com ([209.85.215.193]:36252 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727049AbgCGAAb (ORCPT ); Fri, 6 Mar 2020 19:00:31 -0500 Received: by mail-pg1-f193.google.com with SMTP id d9so1808202pgu.3 for ; Fri, 06 Mar 2020 16:00:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=DtwnhE0dOU4dEaL21NqjZxyyLnhVLXbLrNjUI3+1LHU=; b=Ajyi7mY5V2YVrTRed4RoA9Adv9oko3wM83sy5Rryw4RSC0yYjH2yyl3If2ZOinXpDl MDQ0hoLsbVrsQ/cLdx5AWK6RzDQlM0bEQq8iyCL4JkNDHnY1CeoKftRiJJ0Or8c7ZJmL IriehFYK1/mzJRESqSQwtjqEZnW8etENDx1cY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=DtwnhE0dOU4dEaL21NqjZxyyLnhVLXbLrNjUI3+1LHU=; b=NxSziApoAKNIyoBDWg45zapl1bZ/OB/aoaEjJTO8oEWacy3Y9KTWmd6qD0rJjlMpCH vtC+JSGColEq5rZpe0ua8x/le5/g4AQ//ZQZql7h9jj5EidK6zCxa+4C5eAeA7UZE7yj 9a3+sr90jckiB5cEvChUsPC9ns5JOcThaehG1qRuMNIXq914JYiWckWdthgZ3mgzJSnm SJWbQycHehmuyf9V+CzBH/O2haIOXl2egd7oXYhDVgXdiDQCVBEajA1eh76TOWrHdTGG 6sQaddwsSd0kwwJth3WY59Q/Cd/B/R6UCj7p1b3xqaEirdfFUKyc4OGt119zInDLxogG EM6w== X-Gm-Message-State: ANhLgQ2nA79RBoZNYsqTJQDwyCejvNU96VQlNZrNe9YJuVBO13+wL1YU JOUNsQbAULh35MqK1M9LMFEVDg== X-Google-Smtp-Source: ADFU+vvPZPH6LeaFVHC3vVUKJVwBy5v8MzIfDt0+CiXXwiCQmtCmO7Iem66x5vbOyW+E9YuGYPnJ1Q== X-Received: by 2002:a63:c00a:: with SMTP id h10mr5445417pgg.31.1583539229083; Fri, 06 Mar 2020 16:00:29 -0800 (PST) Received: from tictac2.mtv.corp.google.com ([2620:15c:202:1:24fa:e766:52c9:e3b2]) by smtp.gmail.com with ESMTPSA id 9sm32302246pge.65.2020.03.06.16.00.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Mar 2020 16:00:28 -0800 (PST) From: Douglas Anderson To: Andy Gross , Bjorn Andersson , Maulik Shah Cc: Rajendra Nayak , mka@chromium.org, evgreen@chromium.org, swboyd@chromium.org, Lina Iyer , Douglas Anderson , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [RFT PATCH 7/9] drivers: qcom: rpmh-rsc: Warning if tcs_write() used for non-active Date: Fri, 6 Mar 2020 15:59:49 -0800 Message-Id: <20200306155707.RFT.7.I8e187cdfb7a31f5bb7724f1f937f2862ee464a35@changeid> X-Mailer: git-send-email 2.25.1.481.gfbce0eb801-goog In-Reply-To: <20200306235951.214678-1-dianders@chromium.org> References: <20200306235951.214678-1-dianders@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org tcs_write() is documented to only be useful for writing RPMH_ACTIVE_ONLY_STATE. Let's be loud if someone messes up. Signed-off-by: Douglas Anderson --- drivers/soc/qcom/rpmh-rsc.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/soc/qcom/rpmh-rsc.c b/drivers/soc/qcom/rpmh-rsc.c index c63441182358..693873fce895 100644 --- a/drivers/soc/qcom/rpmh-rsc.c +++ b/drivers/soc/qcom/rpmh-rsc.c @@ -550,6 +550,12 @@ static int tcs_write(struct rsc_drv *drv, const struct tcs_request *msg) unsigned long flags; int ret; + /* + * It only makes sense to grab a whole TCS for ourselves if we're + * triggering right away, which we only do for ACTIVE_ONLY. + */ + WARN_ON(msg->state != RPMH_ACTIVE_ONLY_STATE); + tcs = get_tcs_for_msg(drv, msg); if (IS_ERR(tcs)) return PTR_ERR(tcs); -- 2.25.1.481.gfbce0eb801-goog