From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EEBAC10F27 for ; Tue, 10 Mar 2020 15:20:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0CBFF20873 for ; Tue, 10 Mar 2020 15:20:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="m/zNCZ70" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727300AbgCJPUf (ORCPT ); Tue, 10 Mar 2020 11:20:35 -0400 Received: from mail-pf1-f195.google.com ([209.85.210.195]:34157 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727813AbgCJPUf (ORCPT ); Tue, 10 Mar 2020 11:20:35 -0400 Received: by mail-pf1-f195.google.com with SMTP id 23so4827932pfj.1 for ; Tue, 10 Mar 2020 08:20:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=6MhFgIdze8CFf2DOrBawMYLjN6c8ytgEy4KTgM5UsKI=; b=m/zNCZ70DcHzitOz0JSTs00aicOWLVtUPobgMC2juOgSuvBdRUs2ULP0Ups4xAIQ4+ GkiAoRRV7UEuj9/HSK3R8iaYqmCTarzCPhjS+DlYPrfcEvSBosUBkj+izKK2cQjS8BjW GFq1ZXcm0Cgr3caOvqgwfypDmqe3jbdjn018IQLTmBYACIgMYqij/5lRoPNNCUMhGdhX gTfK86J+0GkyCRD62BYej6x5QSHQ4y6zPt7H+6m6gOtGalne8wVoFc0jlhTdYfolU+Qu Ng3TUPVBRljKkoRg3ffG8G99Z61/jah0DJbo9NMGFbjDtP1dnbj6HzePS3abQQ81/6bp UdNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=6MhFgIdze8CFf2DOrBawMYLjN6c8ytgEy4KTgM5UsKI=; b=JwIRTH4HPifwdmK4WmWrmoK10wec7VWEdFaBkq7W39wqbmDOJQl2uuxyzsl8DZ2WaX vJf5cjACkEDD+1D5QEmdwNiEqpYNk8kV8FZUPtRXT6M807Og2Vc083+3s9pv26/L1dm2 yrat645f4m3pGH1ZF/ptxs8WWP6PRcmv4tBVe2KqOSjkBTtFZewNA00a88ovlqGlfFFf YabjAVpxUxw+BWFmkv3VuvVylJMVnZTM7fRyf25HJcl2Cv2bxvjZrB4cqk5pC7S20IGu ZMfqcZ4PljEINABKIQwDqSmnRxMoWKZ8zuyCNffMNtWCtw8i1xP5nOGN4ZJ8sA1Rm1Na hTmQ== X-Gm-Message-State: ANhLgQ1O51OEs+2goZ0G1BbpmrFFh7B9f5Zz3mUKfVT00IyXuOXDG2ha AiHW+I6c6up0i3h3NKwW7XL6Cg== X-Google-Smtp-Source: ADFU+vuDMeVSrBmcnm1f3SeMtYbGOm0trJg8lN9EATMG0oGxhlTM5PSR5uh75bg8T3fDm2w5zn88ZA== X-Received: by 2002:a62:ce48:: with SMTP id y69mr10163479pfg.178.1583853634107; Tue, 10 Mar 2020 08:20:34 -0700 (PDT) Received: from xps15 (S0106002369de4dac.cg.shawcable.net. [68.147.8.254]) by smtp.gmail.com with ESMTPSA id dw19sm2662207pjb.16.2020.03.10.08.20.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Mar 2020 08:20:33 -0700 (PDT) Date: Tue, 10 Mar 2020 09:20:31 -0600 From: Mathieu Poirier To: Bjorn Andersson Cc: Cl?ment Leger , Ohad Ben-Cohen , Jonathan Corbet , Shawn Guo , Sascha Hauer , linux-remoteproc , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Andy Gross , Patrice Chotard , linux-doc , linux-kernel , linux-arm-kernel , linux-arm-msm , Arnaud Pouliquen , Loic PALLARDY , s-anna Subject: Re: [PATCH v5 5/8] remoteproc: Rename rproc_elf_sanity_check for elf32 Message-ID: <20200310152031.GA25781@xps15> References: <20200210162209.23149-1-cleger@kalray.eu> <20200302093902.27849-1-cleger@kalray.eu> <20200302093902.27849-6-cleger@kalray.eu> <20200302231342.GE262924@yoga> <482678048.7666348.1583222551942.JavaMail.zimbra@kalray.eu> <20200310000005.GF14744@builder> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200310000005.GF14744@builder> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Mon, Mar 09, 2020 at 05:00:05PM -0700, Bjorn Andersson wrote: > On Tue 03 Mar 00:02 PST 2020, Cl?ment Leger wrote: > > > Hi Bjorn, > > > > ----- On 3 Mar, 2020, at 00:13, Bjorn Andersson bjorn.andersson@linaro.org wrote: > > > > > On Mon 02 Mar 01:38 PST 2020, Clement Leger wrote: > > > > > >> Since this function will be modified to support both elf32 and elf64, > > >> rename the existing one to elf32 (which is the only supported format > > >> at the moment). This will allow not to introduce possible side effect > > >> when adding elf64 support (ie: all backends will still support only > > >> elf32 if not requested explicitely using rproc_elf_sanity_check). > > >> > > > > > > Is there a reason for preventing ELF64 binaries be loaded? > > > > I decided to go this way to let driver maintainer decide if they want > > to support elf64 to avoid problems with 64bits addresses/sizes which do > > not fit in their native type (size_t for instance). This is probably > > not going to happen and there are additionnal checks before calling > > rproc_da_to_va. And addresses should be filtered by rproc_da_to_va. > > So, actually it seems there is no reason to forbid supporting elf32/64 > > for all drivers. > > > > I was hoping to hear some additional feedback on this from others. I didn't follow up on this one because I agreed with your assesment and didn't think it was needed. Simply put I would rather see rproc_elf_sanity_check() gain support for elf64 and let the platform code decide what to do with format they don't support rather than spinning a new function. > > I've merge the patch as is, but think it would be nice to clean this up > and just have the driver ignore if fed a 32 or 64-elf. It would be really nice to see this cleaned up in time for the coming merge window... Thanks Mathieu > > Regards, > Bjorn > > > Regards, > > > > Clément > > > > > > > > Regards, > > > Bjorn > > > > > >> Signed-off-by: Clement Leger > > >> --- > > >> drivers/remoteproc/remoteproc_core.c | 2 +- > > >> drivers/remoteproc/remoteproc_elf_loader.c | 6 +++--- > > >> drivers/remoteproc/remoteproc_internal.h | 2 +- > > >> drivers/remoteproc/st_remoteproc.c | 2 +- > > >> drivers/remoteproc/st_slim_rproc.c | 2 +- > > >> drivers/remoteproc/stm32_rproc.c | 2 +- > > >> 6 files changed, 8 insertions(+), 8 deletions(-) > > >> > > >> diff --git a/drivers/remoteproc/remoteproc_core.c > > >> b/drivers/remoteproc/remoteproc_core.c > > >> index 4bfaf4a3c4a3..99f0b796fbc7 100644 > > >> --- a/drivers/remoteproc/remoteproc_core.c > > >> +++ b/drivers/remoteproc/remoteproc_core.c > > >> @@ -2055,7 +2055,7 @@ struct rproc *rproc_alloc(struct device *dev, const char > > >> *name, > > >> rproc->ops->load = rproc_elf_load_segments; > > >> rproc->ops->parse_fw = rproc_elf_load_rsc_table; > > >> rproc->ops->find_loaded_rsc_table = rproc_elf_find_loaded_rsc_table; > > >> - rproc->ops->sanity_check = rproc_elf_sanity_check; > > >> + rproc->ops->sanity_check = rproc_elf32_sanity_check; > > >> rproc->ops->get_boot_addr = rproc_elf_get_boot_addr; > > >> } > > >> > > >> diff --git a/drivers/remoteproc/remoteproc_elf_loader.c > > >> b/drivers/remoteproc/remoteproc_elf_loader.c > > >> index c2a9783cfb9a..5a67745f2638 100644 > > >> --- a/drivers/remoteproc/remoteproc_elf_loader.c > > >> +++ b/drivers/remoteproc/remoteproc_elf_loader.c > > >> @@ -25,13 +25,13 @@ > > >> #include "remoteproc_internal.h" > > >> > > >> /** > > >> - * rproc_elf_sanity_check() - Sanity Check ELF firmware image > > >> + * rproc_elf_sanity_check() - Sanity Check ELF32 firmware image > > >> * @rproc: the remote processor handle > > >> * @fw: the ELF firmware image > > >> * > > >> * Make sure this fw image is sane. > > >> */ > > >> -int rproc_elf_sanity_check(struct rproc *rproc, const struct firmware *fw) > > >> +int rproc_elf32_sanity_check(struct rproc *rproc, const struct firmware *fw) > > >> { > > >> const char *name = rproc->firmware; > > >> struct device *dev = &rproc->dev; > > >> @@ -89,7 +89,7 @@ int rproc_elf_sanity_check(struct rproc *rproc, const struct > > >> firmware *fw) > > >> > > >> return 0; > > >> } > > >> -EXPORT_SYMBOL(rproc_elf_sanity_check); > > >> +EXPORT_SYMBOL(rproc_elf32_sanity_check); > > >> > > >> /** > > >> * rproc_elf_get_boot_addr() - Get rproc's boot address. > > >> diff --git a/drivers/remoteproc/remoteproc_internal.h > > >> b/drivers/remoteproc/remoteproc_internal.h > > >> index 0deae5f237b8..28639c588d58 100644 > > >> --- a/drivers/remoteproc/remoteproc_internal.h > > >> +++ b/drivers/remoteproc/remoteproc_internal.h > > >> @@ -54,7 +54,7 @@ void *rproc_da_to_va(struct rproc *rproc, u64 da, size_t len); > > >> phys_addr_t rproc_va_to_pa(void *cpu_addr); > > >> int rproc_trigger_recovery(struct rproc *rproc); > > >> > > >> -int rproc_elf_sanity_check(struct rproc *rproc, const struct firmware *fw); > > >> +int rproc_elf32_sanity_check(struct rproc *rproc, const struct firmware *fw); > > >> u64 rproc_elf_get_boot_addr(struct rproc *rproc, const struct firmware *fw); > > >> int rproc_elf_load_segments(struct rproc *rproc, const struct firmware *fw); > > >> int rproc_elf_load_rsc_table(struct rproc *rproc, const struct firmware *fw); > > >> diff --git a/drivers/remoteproc/st_remoteproc.c > > >> b/drivers/remoteproc/st_remoteproc.c > > >> index a3268d95a50e..a6cbfa452764 100644 > > >> --- a/drivers/remoteproc/st_remoteproc.c > > >> +++ b/drivers/remoteproc/st_remoteproc.c > > >> @@ -233,7 +233,7 @@ static const struct rproc_ops st_rproc_ops = { > > >> .parse_fw = st_rproc_parse_fw, > > >> .load = rproc_elf_load_segments, > > >> .find_loaded_rsc_table = rproc_elf_find_loaded_rsc_table, > > >> - .sanity_check = rproc_elf_sanity_check, > > >> + .sanity_check = rproc_elf32_sanity_check, > > >> .get_boot_addr = rproc_elf_get_boot_addr, > > >> }; > > >> > > >> diff --git a/drivers/remoteproc/st_slim_rproc.c > > >> b/drivers/remoteproc/st_slim_rproc.c > > >> index 09bcb4d8b9e0..3cca8b65a8db 100644 > > >> --- a/drivers/remoteproc/st_slim_rproc.c > > >> +++ b/drivers/remoteproc/st_slim_rproc.c > > >> @@ -203,7 +203,7 @@ static const struct rproc_ops slim_rproc_ops = { > > >> .da_to_va = slim_rproc_da_to_va, > > >> .get_boot_addr = rproc_elf_get_boot_addr, > > >> .load = rproc_elf_load_segments, > > >> - .sanity_check = rproc_elf_sanity_check, > > >> + .sanity_check = rproc_elf32_sanity_check, > > >> }; > > >> > > >> /** > > >> diff --git a/drivers/remoteproc/stm32_rproc.c b/drivers/remoteproc/stm32_rproc.c > > >> index a18f88044111..9a8b5f5e2572 100644 > > >> --- a/drivers/remoteproc/stm32_rproc.c > > >> +++ b/drivers/remoteproc/stm32_rproc.c > > >> @@ -505,7 +505,7 @@ static struct rproc_ops st_rproc_ops = { > > >> .load = rproc_elf_load_segments, > > >> .parse_fw = stm32_rproc_parse_fw, > > >> .find_loaded_rsc_table = rproc_elf_find_loaded_rsc_table, > > >> - .sanity_check = rproc_elf_sanity_check, > > >> + .sanity_check = rproc_elf32_sanity_check, > > >> .get_boot_addr = rproc_elf_get_boot_addr, > > >> }; > > >> > > >> -- > > >> 2.15.0.276.g89ea799