From: Stephen Boyd <swboyd@chromium.org>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: linux-kernel@vger.kernel.org, Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org,
Alok Chauhan <alokc@codeaurora.org>,
Douglas Anderson <dianders@chromium.org>,
Brendan Higgins <brendanhiggins@google.com>
Subject: [PATCH v2 1/3] i2c: qcom-geni: Let firmware specify irq trigger flags
Date: Tue, 10 Mar 2020 08:43:56 -0700 [thread overview]
Message-ID: <20200310154358.39367-2-swboyd@chromium.org> (raw)
In-Reply-To: <20200310154358.39367-1-swboyd@chromium.org>
We don't need to force IRQF_TRIGGER_HIGH here as the DT or ACPI tables
should take care of this for us. Just use 0 instead so that we use the
flags from the firmware. Also, remove specify dev_name() for the irq
name so that we can get better information in /proc/interrupts about
which device is generating interrupts.
Cc: Alok Chauhan <alokc@codeaurora.org>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Brendan Higgins <brendanhiggins@google.com>
Signed-off-by: Stephen Boyd <swboyd@chromium.org>
---
drivers/i2c/busses/i2c-qcom-geni.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/i2c/busses/i2c-qcom-geni.c b/drivers/i2c/busses/i2c-qcom-geni.c
index 17abf60c94ae..4efca130035a 100644
--- a/drivers/i2c/busses/i2c-qcom-geni.c
+++ b/drivers/i2c/busses/i2c-qcom-geni.c
@@ -549,8 +549,8 @@ static int geni_i2c_probe(struct platform_device *pdev)
init_completion(&gi2c->done);
spin_lock_init(&gi2c->lock);
platform_set_drvdata(pdev, gi2c);
- ret = devm_request_irq(&pdev->dev, gi2c->irq, geni_i2c_irq,
- IRQF_TRIGGER_HIGH, "i2c_geni", gi2c);
+ ret = devm_request_irq(&pdev->dev, gi2c->irq, geni_i2c_irq, 0,
+ dev_name(&pdev->dev), gi2c);
if (ret) {
dev_err(&pdev->dev, "Request_irq failed:%d: err:%d\n",
gi2c->irq, ret);
--
Sent by a computer, using git, on the internet
next prev parent reply other threads:[~2020-03-10 15:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-10 15:43 [PATCH v2 0/3] Misc qcom geni i2c driver fixes Stephen Boyd
2020-03-10 15:43 ` Stephen Boyd [this message]
2020-03-10 19:35 ` [PATCH v2 1/3] i2c: qcom-geni: Let firmware specify irq trigger flags Bjorn Andersson
2020-03-11 7:30 ` Amit Kucheria
2020-03-13 14:21 ` Wolfram Sang
2020-03-10 15:43 ` [PATCH v2 2/3] i2c: qcom-geni: Grow a dev pointer to simplify code Stephen Boyd
2020-03-10 19:41 ` Bjorn Andersson
2020-03-11 7:30 ` Amit Kucheria
2020-03-13 14:21 ` Wolfram Sang
2020-03-10 15:43 ` [PATCH v2 3/3] i2c: qcom-geni: Drop of_platform.h include Stephen Boyd
2020-03-10 19:42 ` Bjorn Andersson
2020-03-11 7:30 ` Amit Kucheria
2020-03-13 14:21 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200310154358.39367-2-swboyd@chromium.org \
--to=swboyd@chromium.org \
--cc=agross@kernel.org \
--cc=alokc@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=brendanhiggins@google.com \
--cc=dianders@chromium.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).