From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A798DC10DCE for ; Tue, 10 Mar 2020 19:35:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6B71422525 for ; Tue, 10 Mar 2020 19:35:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="du2E0Fhb" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726918AbgCJTf3 (ORCPT ); Tue, 10 Mar 2020 15:35:29 -0400 Received: from mail-pl1-f195.google.com ([209.85.214.195]:41222 "EHLO mail-pl1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726497AbgCJTf3 (ORCPT ); Tue, 10 Mar 2020 15:35:29 -0400 Received: by mail-pl1-f195.google.com with SMTP id t14so5839487plr.8 for ; Tue, 10 Mar 2020 12:35:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=nKhwu1SDKAkcqVKvzUsWw/zCHl4XPJcIG2el7T4mPBQ=; b=du2E0Fhb4mJ/inZzgatzWqnzcvQZXtDZgmruya9zV4Gw+nnSIHd76VYPct8N7RGUkg UZ7vTHKGlquKipcijaAe92RqfW3igKTUmJRFBWBAA7h+XfKwmD5MCHVMgeW40XLczZKi OIHqUD3+FqEpQilbduiaEaWRgtRo+SsgbHYwfd+DSKp74W8tZJiz/b04q91tSg5Tt7KO Mk7rMARWOxAT1Qsnja4Gjy7Bl9owEbVprtyZGmMNAZjlvx4dZeuHdY0R2D8QvIjz8gB5 tR3qEuKJsUjuy5KRr3kywpFl5nUUFLdDq/9GL5Mkv8KDkvljeeLA6pytKazAgqMlKeQw Dtow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=nKhwu1SDKAkcqVKvzUsWw/zCHl4XPJcIG2el7T4mPBQ=; b=ejZkI52TjipGjw26UDS9dPq4FS19kvk7bTbh2B0Oz7DR2D5u90TmJPMWznuLk6m0+3 K/e0QAuSC+WLVfFGje7bHB36aGembaZ0RivSBpLK7fEQ12TlQvR/taqndr1dgnNu9veC Se9wMOAVYEQOqsD4b7joWic/EpkXysjyPVXeLrwAHNkiokdi7evr2mQHsCaDk6qcGhfA piyrTn/bGwVQXL+vAcGNE04jJFOgWjBV5gjUbv8Y7ne7wQ3fAb0/LrTQLUZu2fmntrL0 vuRI9nTQXKwZ4BuE++LymM5Sz0ULhNXbpan0lOomDEvksgjrT4dxXQG0a2gy5shUWL0i Tb9Q== X-Gm-Message-State: ANhLgQ3AKUx79+KxRhzzJj/uFt8ExrJR5qVYBxlfq8V+5UGGqE5+zNcI ezO1ep3UB1iQhD1iEuFZlrn4ag== X-Google-Smtp-Source: ADFU+vviFtgfAaWW0uY6/ztd897OrmyaVMgQQfuQtxMiBiAI3p2c1h6uHwAJhiBB9BSiymdPB6CFDA== X-Received: by 2002:a17:902:321:: with SMTP id 30mr23122871pld.130.1583868928567; Tue, 10 Mar 2020 12:35:28 -0700 (PDT) Received: from yoga (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id c207sm8147791pfb.47.2020.03.10.12.35.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Mar 2020 12:35:27 -0700 (PDT) Date: Tue, 10 Mar 2020 12:35:25 -0700 From: Bjorn Andersson To: Stephen Boyd Cc: Wolfram Sang , linux-kernel@vger.kernel.org, Andy Gross , linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org, Alok Chauhan , Douglas Anderson , Brendan Higgins Subject: Re: [PATCH v2 1/3] i2c: qcom-geni: Let firmware specify irq trigger flags Message-ID: <20200310193525.GM264362@yoga> References: <20200310154358.39367-1-swboyd@chromium.org> <20200310154358.39367-2-swboyd@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200310154358.39367-2-swboyd@chromium.org> Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Tue 10 Mar 08:43 PDT 2020, Stephen Boyd wrote: > We don't need to force IRQF_TRIGGER_HIGH here as the DT or ACPI tables > should take care of this for us. Just use 0 instead so that we use the > flags from the firmware. Also, remove specify dev_name() for the irq > name so that we can get better information in /proc/interrupts about > which device is generating interrupts. > > Cc: Alok Chauhan > Reviewed-by: Douglas Anderson > Reviewed-by: Brendan Higgins Reviewed-by: Bjorn Andersson > Signed-off-by: Stephen Boyd > --- > drivers/i2c/busses/i2c-qcom-geni.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-qcom-geni.c b/drivers/i2c/busses/i2c-qcom-geni.c > index 17abf60c94ae..4efca130035a 100644 > --- a/drivers/i2c/busses/i2c-qcom-geni.c > +++ b/drivers/i2c/busses/i2c-qcom-geni.c > @@ -549,8 +549,8 @@ static int geni_i2c_probe(struct platform_device *pdev) > init_completion(&gi2c->done); > spin_lock_init(&gi2c->lock); > platform_set_drvdata(pdev, gi2c); > - ret = devm_request_irq(&pdev->dev, gi2c->irq, geni_i2c_irq, > - IRQF_TRIGGER_HIGH, "i2c_geni", gi2c); > + ret = devm_request_irq(&pdev->dev, gi2c->irq, geni_i2c_irq, 0, > + dev_name(&pdev->dev), gi2c); > if (ret) { > dev_err(&pdev->dev, "Request_irq failed:%d: err:%d\n", > gi2c->irq, ret); > -- > Sent by a computer, using git, on the internet >