From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72640C1975A for ; Thu, 12 Mar 2020 04:50:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 580A12074C for ; Thu, 12 Mar 2020 04:50:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="u05buOnh" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387657AbgCLEuR (ORCPT ); Thu, 12 Mar 2020 00:50:17 -0400 Received: from mail-pj1-f65.google.com ([209.85.216.65]:50690 "EHLO mail-pj1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387676AbgCLEuR (ORCPT ); Thu, 12 Mar 2020 00:50:17 -0400 Received: by mail-pj1-f65.google.com with SMTP id u10so2027029pjy.0 for ; Wed, 11 Mar 2020 21:50:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=9Huysc9k69DOetuyPT37xPzZ+YLOLRqnJ/FtV19WEDc=; b=u05buOnhB2ZaHjx7I2VFVZdDS3meih0mc6WZaP2ubEFIX5IRV5PakdbMoocuP1aMet 136201rU4y6u8Z/BRJWEayhmgq6izg7StoG+xiBHPWeICaxzekOrFwczJDFN37vhaqhG 1kw58XU/mfyf4/4oZnJjk92aE03UU/a077dE71+PFVLVGLx6/iA3tlkGQl5FIdnhviBh 3XsuPkEDF8xtLyCuU6ZrY2qrQhM265xHA2AbYFz8FY43oNPUUHgB4+ccFwqE47xUd2S6 W4eYzRJufanpih+BqCLI38xka2OLJnMdlWxDNUS1RZnkjiP6U9kMQyeitCgIeZxffQ0S Klvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=9Huysc9k69DOetuyPT37xPzZ+YLOLRqnJ/FtV19WEDc=; b=TToyxbuQm00Xt1JRVX8JydEtKAyxxG07KN/sIBobYWq+57vpyYgPJ7X/kOgm28Jx16 kUluNJTmZUfaO7+hUhnuVpntjqapmLgYaKI3sGpV6z54UkfiimT6I3b/ct7dXyOv0HH/ Mce6VqjfiYfQMoOhPHB9jAtjknEP59CfZolPyMTtd+xtgBI1bTg27xWKMIxmGzZWIml0 iU1hJDEngEXehal3XUB7UCx/uPmgBiOz4TAnuXktLwIli8u3P+PKJHokUqgAq/xFzZtY w4uLr/fqjKBzJsw8v9mBiGyRsQHqgwsAEzeq/Y9hOhZ48UkWgRrmTUDAYfxpc6xqRl38 4cmg== X-Gm-Message-State: ANhLgQ2kP1BzycNszmKhQZ1/65BdlkNONDxwdcFH3x0cpPGRzP3C+MXi MuhJIG8CSyAawfaIYZAMv9cREg== X-Google-Smtp-Source: ADFU+vtQv6XCgFYw5CWT4cXp6fyTARSMSkMReQUHbK2N7f/ufSK/IBPreQ4I9vHrUgXhd7/6d78Hww== X-Received: by 2002:a17:902:7c0d:: with SMTP id x13mr6162264pll.93.1583988615935; Wed, 11 Mar 2020 21:50:15 -0700 (PDT) Received: from yoga (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id q12sm52827529pfh.158.2020.03.11.21.50.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Mar 2020 21:50:15 -0700 (PDT) Date: Wed, 11 Mar 2020 21:50:12 -0700 From: Bjorn Andersson To: Robert Foss Cc: agross@kernel.org, robh+dt@kernel.org, mark.rutland@arm.com, catalin.marinas@arm.com, will@kernel.org, shawnguo@kernel.org, olof@lixom.net, Anson.Huang@nxp.com, maxime@cerno.tech, leonard.crestez@nxp.com, dinguyen@kernel.org, marcin.juszkiewicz@linaro.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Loic Poulain Subject: Re: [v1 1/6] arm64: dts: msm8916: Add i2c-qcom-cci node Message-ID: <20200312045012.GT264362@yoga> References: <20200311123501.18202-1-robert.foss@linaro.org> <20200311123501.18202-2-robert.foss@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200311123501.18202-2-robert.foss@linaro.org> Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Wed 11 Mar 05:34 PDT 2020, Robert Foss wrote: > From: Loic Poulain > > The msm8916 CCI controller provides one CCI/I2C bus. > > Signed-off-by: Loic Poulain > Signed-off-by: Robert Foss > --- > arch/arm64/boot/dts/qcom/msm8916.dtsi | 27 +++++++++++++++++++++++++++ > 1 file changed, 27 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi > index 9f31064f2374..afe1d73e5cd3 100644 > --- a/arch/arm64/boot/dts/qcom/msm8916.dtsi > +++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi > @@ -1503,6 +1503,33 @@ > }; > }; > > + cci@1b0c000 { This deserves a label, so that it's possible to reference it and alter the status in the board dts. > + compatible = "qcom,msm8916-cci"; > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <0x1b0c000 0x1000>; Please sort nodes my address (and then by name). Apart from these two nits, this looks good. Regards, Bjorn > + interrupts = ; > + clocks = <&gcc GCC_CAMSS_TOP_AHB_CLK>, > + <&gcc GCC_CAMSS_CCI_AHB_CLK>, > + <&gcc GCC_CAMSS_CCI_CLK>, > + <&gcc GCC_CAMSS_AHB_CLK>; > + clock-names = "camss_top_ahb", "cci_ahb", > + "cci", "camss_ahb"; > + assigned-clocks = <&gcc GCC_CAMSS_CCI_AHB_CLK>, > + <&gcc GCC_CAMSS_CCI_CLK>; > + assigned-clock-rates = <80000000>, <19200000>; > + pinctrl-names = "default"; > + pinctrl-0 = <&cci0_default>; > + status = "disabled"; > + > + cci0: i2c-bus@0 { > + reg = <0>; > + clock-frequency = <400000>; > + #address-cells = <1>; > + #size-cells = <0>; > + }; > + }; > + > camss: camss@1b00000 { > compatible = "qcom,msm8916-camss"; > reg = <0x1b0ac00 0x200>, > -- > 2.20.1 >